From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4112EC61D97 for ; Fri, 24 Nov 2023 01:07:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A913C6B06AD; Thu, 23 Nov 2023 20:07:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A41AF6B06AE; Thu, 23 Nov 2023 20:07:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908B76B06AF; Thu, 23 Nov 2023 20:07:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 81BE66B06AD for ; Thu, 23 Nov 2023 20:07:23 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5926AB6FB6 for ; Fri, 24 Nov 2023 01:07:23 +0000 (UTC) X-FDA: 81491059566.21.B28928D Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf29.hostedemail.com (Postfix) with ESMTP id 1BFB0120019 for ; Fri, 24 Nov 2023 01:07:20 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=aLUR6BoF; dmarc=none; spf=pass (imf29.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700788041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2xxxAalZ73cRwdZRWpl45yBEiTMvShJqt0Ovd9kac2g=; b=GH3Y1OUuG7b3DBMpBYXWqAAFD+28VkynUp1eFLdBEkzB5jPonyur/g33o4ngUqYSNjEcDf SBXYpY5GFLCqtxEWXrIDW5zafes7KuNrAdNWLDbz2wfUO6Q5PcXC/49jaXEzCjrlVoCUy0 rytdG5kwWCBPBotm4HTj4KYKU05UtFk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=aLUR6BoF; dmarc=none; spf=pass (imf29.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700788041; a=rsa-sha256; cv=none; b=y3VWBuYnzJJP72kMaYj3hSgSxloZasFYZ8pUgw8FSbFyW8YCDpWGsRvBu2PRS4fRrjGzcb KiZzj/dXGc8zYofRy/rXefnETJ3PCXlVGAubqHI0rihK2yOU5NeN23KvhgJX0M5HrIqK3E 8ebZ0tRkBevJDdn9jWRgVFEY8h1gb5Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1700788038; bh=2xxxAalZ73cRwdZRWpl45yBEiTMvShJqt0Ovd9kac2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aLUR6BoFlBYtiJSS1etIcfjzdaRpP7n06oAX400JbB3OP61oS/wOD/3jq4bPjiHo7 3wV4SPvTP17Yymwb3AVOw5cxJL3maWt8kTqxiWD0fQM4wcqqDzYWLfxL3K9rkKAnFf ojmOBd5/ZElekPwIA7twndtJZFq7XZH8nRc4O9ntZ4Cxpv3JrqzErLQo5ugIGxzrhe AnO4HeawO2liLqIkV6zztDc+3tAcLf8juI796b7ZvbBbqqPK25FTyG884GBMkPQKCQ LJw3I9E1ued7g3z1a+HLCZCJix/By7U4i3qv7cRtce+cFZDtLBozzgMFENOcehn3bS 8PA1SWmy4fqQQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SbxfF0fnlz4wd2; Fri, 24 Nov 2023 12:07:17 +1100 (AEDT) From: Michael Ellerman To: Peter Xu , Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , Matthew Wilcox , Jason Gunthorpe , Axel Rasmussen , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing In-Reply-To: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> Date: Fri, 24 Nov 2023 12:06:24 +1100 Message-ID: <87y1eoq7sf.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1BFB0120019 X-Stat-Signature: ppn3pcazzam4thuzyryttt7qhd76rk4s X-HE-Tag: 1700788040-709392 X-HE-Meta: U2FsdGVkX1+JEOitoQW0yX3oP2/mCD6gl1hF8IvAg+04XeoBnneI3S18Lm9vhZJtyoEHlnap8nnCyLw78vs9c8d2mHP9fAnns2Ei8Ndxh6ZzcSHjJfmAAaFyOrpyMmPnsIygWmdELG8Wwo6qHftm3H7O5CzmvLMbjzWwcB1fKKwsplqnskZElQvcOYLWzAL7CWZGa7s1qMOFcJQ9dZD37nUpdRgRyVm1Rt3F2fBa6UnTzj8j/43R0qZbcvOPpTt0RdOOf2oCyajd5PtAedOSzzbsZIAS/taM1yBc+PYk6iLnJgaph8Ttkt1g8bOGxm6BISSLI7dd+MJ5mNxTjBDWRr7F8DAexUz1gfdv8VMyveSrZJFRWcOV4OFqvknc/jTvDiax8fS9Gt7BwLmgJ3Ma1VXwx/rpRm/ZyyDOCeZxhQE3lrSssWbYS2lo+ALJsyE24Owd2Bp/Nh5t0aMiazPXkrMRxZG5ZgbPSaTiua9ByEDvsawFSAPKIgs2InxbT80qwkgsHiTg2QRsqNyHhjfwu4TDGp2+6tkq5bwDZoRA91CmBLDHBZAe3RlTyYS/iKdeH7Ni8Bi2MKITN0VeJeoeLFgDOshmSIR4RU36i6KMgfh4SsGSyrkO+NMnvCqNIJENo2G9FfJXM2h5tKw+B1IRamfZKiQEs6/v+XBWFcoQnsZmrIFthNoAh9u4i219fZ40lhzJM5VLtwI/SLsAcj805bZUn7XMrthMVefJiNj1nnah6ajOtP/4GIe7ClRUudbmbEFVZ7ZbJJpCsemZvkO3us6ewEVtnQBSlBUhEv9ZpN6zWV9yfigQteOJe5i4g/GwTa858iA+InoxSwvEQIYSoBWp8/i5iEwCv8BOzGaU5LWL95ui45fMDI73L1nmzflWAnJG2w9YINuA6JkpQcHj8YkbNkngiTYaN+UL7M7VVBHVNtYaj0NSfUYR2UMD1yJ3hwfG2BcNbHLR+kuNzuz U3hJTC33 oTclrg2ach6GqVTpY887yY4DOJGXN9t8LBAuB8Vu7oGrW5msy3y00uJ0KGTkTTIguVyFi9jAyn1K86dPYnptYaRIRP3ttbckbWjYbBgOnwRlC8kRs6T78rVi8T5o040QE9hP2kbu0EMU51x7xEe16r7NYTZhGZnnvtF5q4wiCWA0uszI0/xpXmXggCzJv5cLX40RKhGmRmBrvwduQPzy24gEDNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Peter Xu writes: > On Wed, Nov 22, 2023 at 12:00:24AM -0800, Christoph Hellwig wrote: >> On Tue, Nov 21, 2023 at 10:59:35AM -0500, Peter Xu wrote: ... >> >> If dropping the check is the right thing for now (and I think the ppc >> maintainers and willy as the large folio guy might have a more useful >> opinions than I do), leaving a comment in would be very useful. > > Willy is in the loop, and I just notice I didn't really copy ppc list, even > I planned to.. I am adding the list (linuxppc-dev@lists.ozlabs.org) into > this reply. I'll remember to do so as long as there's a new version. Thanks. > The other reason I feel like hugepd may or may not be further developed for > new features like large folio is that I saw Power9 started to shift to > radix pgtables, and afaics hugepd is only supported in hash tables > (hugepd_ok()). Because it's powerpc it's not quite that simple :} Power9 uses the Radix MMU by default, but the hash page table MMU is still supported. However although hugepd is used with the hash page table MMU, that's only when PAGE_SIZE=4K. These days none of the major distros build with 4K pages. But some of the non-server CPU platforms also use hugepd. 32-bit 8xx does, which is actively maintained by Christophe. And I believe Freescale e6500 can use it, but that is basically orphaned, and although I boot test it I don't run any hugetlb tests. (I guess I should do that). cheers