From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62D1C2BBCA for ; Fri, 28 Jun 2024 09:34:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEB126B00A8; Fri, 28 Jun 2024 05:34:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9AC76B00AC; Fri, 28 Jun 2024 05:34:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B61EC6B00AD; Fri, 28 Jun 2024 05:34:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 98BFF6B00A8 for ; Fri, 28 Jun 2024 05:34:11 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 380281217C4 for ; Fri, 28 Jun 2024 09:34:11 +0000 (UTC) X-FDA: 82279786302.12.B7B3AC0 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf08.hostedemail.com (Postfix) with ESMTP id 0AE2116001A for ; Fri, 28 Jun 2024 09:34:07 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LollBX8N; spf=pass (imf08.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719567230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/IwilMAYccNz1ai9ZFYQ3b8pzOQcfXXvjLD5dtN4o3M=; b=xoS6afYNmNrflMGjF+3hHRAk9muDHJpISbWmTsxrjNwJ2UgBp8iEXdDg+I4lOfB2dy2qHD C3x2s+DAEYitgq/C+5jro3BWr79mNlI3GPbQsC7yFFqLqvHBpkP8r2orZPLLqdqlgeB/rN A402OimGnje149nXTWBTUREK7iOV3KA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719567230; a=rsa-sha256; cv=none; b=L1xGt6+Dy1qrocGxdbii/PkBEfRhOEPG1oi+4tw9hFKPxl4auakU8GwNOBiPBtgwlGO9El BnCAh63hKIie7kv1jbx0YfPcynu5kx4jRv3uUta5INT+hy+r3w8zbCg/fk1Y89MfUh3njj IR0SkmXdcOlNYWJnEYvu7KeK/Rblq8U= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LollBX8N; spf=pass (imf08.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719567248; x=1751103248; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=LEVvzNioSQDou1T1dnSAxbhkKOKKKilGUTvJu0AQs5M=; b=LollBX8Nce+1e8WHCnM9dQr5I6wuf2nysuY5MCMz594TnkoYKT0udli9 b8DiAavJ72r0elkLusSZhynDdG+tD5qqMZnt6SrCLkbQ/6bu1+WQcPh6w 2UdnH6vFfbgCMHKWQg9A/A6V62uOUHL1v22PQZzBQsx0y/VK9NGURpaoY zbUwOa+ROFWVrENAVLSQ0t6rlGEfoc9rio6IAGShZlMHQNlPvyvtR6aya uN2TVqOgwlhyvNzk4LQcz0NT0pdOklJdWdTRSrjZnhupFIslKN21UR89Z Iy7sKR8x3cQ42L+378yG25CisVTFnHwB+qlmEP67twhZueUdEgac5wgOY Q==; X-CSE-ConnectionGUID: DYFdbqZJSUydKPP+esEHZA== X-CSE-MsgGUID: zCFhyH6BTumCrEfZ8uFEug== X-IronPort-AV: E=McAfee;i="6700,10204,11116"; a="27364266" X-IronPort-AV: E=Sophos;i="6.09,168,1716274800"; d="scan'208";a="27364266" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 02:34:07 -0700 X-CSE-ConnectionGUID: qRsbWrKJR1a+tDtL0TkKLg== X-CSE-MsgGUID: e9HS4RXUQpKptKvk9Z+pMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,168,1716274800"; d="scan'208";a="49026398" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2024 02:34:03 -0700 From: "Huang, Ying" To: Tvrtko Ursulin Cc: Matthew Wilcox , Tvrtko Ursulin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Mel Gorman , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode In-Reply-To: <22e9cd24-1ed4-4f1d-b7de-b44cefca6009@igalia.com> (Tvrtko Ursulin's message of "Fri, 28 Jun 2024 09:56:05 +0100") References: <20240625132605.38428-1-tursulin@igalia.com> <87bk3lpxp1.fsf@yhuang6-desk2.ccr.corp.intel.com> <22e9cd24-1ed4-4f1d-b7de-b44cefca6009@igalia.com> Date: Fri, 28 Jun 2024 17:32:12 +0800 Message-ID: <87y16po1k3.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: c9tjh74ahjntw3jnzoaw5nzh7kqq3zke X-Rspamd-Queue-Id: 0AE2116001A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719567247-722576 X-HE-Meta: U2FsdGVkX18h9WW2MfryTQpDZcFG7gCb3zSLKEQfWuq7cULy6zRddkCFW+Aqmr/1A26Cocn54+goo2ZtsulAyPr3IRgwPBUxP6t94qLnVDmiOFPFcqmddseyA9OPliweoxbgkAgbfZ2ooFV/NLvIWgqWoOvmOKmPbJGy2K/Ke0yx2+Q84OUA8zHwdXLGcfvCRasHItwagSjCskVsNvQVlMkOHdW2wsHhQvCHluBPJuckqgwaOcTVYePf6Z3ZWlcfKWHkfyJIxvm04ucaDPR4qAGNSx/vQVqQ8xbluzsX2WGBGI5EfaQ/zB4d+SISV+nVYJsob9uti/fX+dGGakU5pjkrmSzujOhc4zCuDCdNNIRzXDoKnbf5yja9P9U6j6LXyfweqoV4GYuSarkScYkQtWSaz1JR3m/C4sho5rQI92JISjZAbPWX5SrY+mrlkbezSGfFPF/U9w5pHRoPcBb3YnzYstmscu7N3sEj4Ce0C/62RM4rnzgGNG0RLUl/spgwItE3dqpvWv6WcRkT6ulLnib5MKTcwYX36Y58haJKgEvLAHLRS3sBwE7vyHL8Pl7SLeqHlM8o+cGro0p5UvwryqfFcs+PikkNT/UzL7pmA6/TYcXJu+la5HyRuhxWwEUMmZ/Ujgu6A3r8X3c9y4e0sGmrW9EvTLgqKiGxt7bHTgh8LEE/CPvIlExPe7vaaUFdCMCnJm+jpuzulUsH052U7knTsu0p3O82YeicOsEZ4Sj8hVsez0izEwAQC5pDhSvUMPbPbslIp47qTo7Y2AVsVYIzuJAgdvIZhcQGN0NBO9cdZg1UtaPiAQBcrARi9tNNHlMpkrM9wLItTfG19qGmG5A2Drej3kQOdbzcTJf90LSrMnoRe9Iin4QBtwPsizPZ59YyMtpFTCaKqrMWBr5CyZIXbuCu8HhCrnB71ifgKiMOCKajoudUadSMxbRY0/o1b3bmLeOS5gW+Ip5O11G FLPoylih RFg20o1TjuZSCJubItDBZd2vmUky4UnJUpRTI2cWeXKwgr6ed+XcvqBwCxSncYOXVTQn99YkWKoijFhkWZTv1YXpjbBDvxngEp/qjFfhrkj0HkAN62nSoXKhFYuVvlEiKX+KVUedZgbKzA53yDesm7X6diatqQeFaK6iWlnGXqGSJDgF3nZNdzFHzaMlifoTa/Npo30qigIkmuXBwtXhmuS7CW5L9bTgirpxdPMbGtkq3yVYHNgvE07ulS3mFrLQdNYf/7t1Lsl53OJRBkCKhKr81zgUKrUQAvRCpUbNqkXG8WuzMtqb5XN+Jxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Tvrtko Ursulin writes: > On 28/06/2024 04:12, Huang, Ying wrote: >> Hi, Matthew, >> Matthew Wilcox writes: >> >>> On Tue, Jun 25, 2024 at 02:26:05PM +0100, Tvrtko Ursulin wrote: >>>> /* >>>> - * Currently, the only defined flags are mutually exclusive >>>> + * The below two flags are mutually exclusive: >>>> */ >>>> if (flags & MPOL_F_STATIC_NODES) >>>> p += snprintf(p, buffer + maxlen - p, "static"); >>>> else if (flags & MPOL_F_RELATIVE_NODES) >>>> p += snprintf(p, buffer + maxlen - p, "relative"); >>>> + >>>> + if (flags & MPOL_F_NUMA_BALANCING) >>>> + p += snprintf(p, buffer + maxlen - p, "balancing"); >>>> } >>> >>> So if MPOL_F_STATIC_NODES and MPOL_F_NUMA_BALANCING are set, then we >>> get a string "staticbalancing"? Is that intended? >>> >>> Or are these three all mutually exclusive and that should have been >>> as "else if"? >> Yes, this is an issue! > > Sigh, my apologies. I was sure I tested it as this patch was part of a > larger series I have, but then I decided to extract it and send out > and the problems obviously go deeper. What I think happened is that I > probably only tested the other direction, setting of via > mpol_parse_str(). > > Andrew please dequeue it if you haven't already? > >> Dig the git history, in commit 2291990ab36b ("mempolicy: clean-up >> mpol-to-str() mempolicy formatting"), the support for multiple flags are >> removed. I think that we need to restore it. >> Done some basic testing. It was found that when >> MPOL_F_NUMA_BALANCING >> is set, /proc/PID/numa_maps always display "default". That is wrong. >> This make me think that this patch has never been tested! >> The "default" displaying is introduced in commit 8790c71a18e5 >> ("mm/mempolicy.c: fix mempolicy printing in numa_maps"). We need to fix >> it firstly for MPOL_F_NUMA_BALANCING with more accurate filtering. The >> fix needs to be backported to -stable kernel. > > Will you work on this or I can follow up if you want? Please go forward to work on this, Thanks! -- Best Regards, Huang, Ying