From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16888C3DA7F for ; Mon, 12 Aug 2024 21:14:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E34F6B00A5; Mon, 12 Aug 2024 17:14:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 194746B00A6; Mon, 12 Aug 2024 17:14:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05AAC6B00A8; Mon, 12 Aug 2024 17:13:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DBCC96B00A5 for ; Mon, 12 Aug 2024 17:13:59 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 634C5120367 for ; Mon, 12 Aug 2024 21:13:59 +0000 (UTC) X-FDA: 82444845798.04.0655903 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 891A9180012 for ; Mon, 12 Aug 2024 21:13:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="wc/yb39E"; dkim=pass header.d=linutronix.de header.s=2020e header.b=4eHEfl5t; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723497203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NeuZC/AEcA8D8HhnUkFw3ytoFkvPiPSOmUvzwUzhsTE=; b=vT0tIMb2XQmF5zF2ZVgr38fjD7tqaVh3D43Wl6Z6NeMge/L34FUk54tqwTFuXmUE98LTRn 9LPkw9mRJ0F1bTbC0acr3cGDCWjam+KKqo2Z6+3of/C5ZpmYOkl7d+9fpeGjJ62+kvb3dJ GRXYBGWmArVvHzKpv3I5Li3EEqM7EQ0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="wc/yb39E"; dkim=pass header.d=linutronix.de header.s=2020e header.b=4eHEfl5t; spf=pass (imf24.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723497203; a=rsa-sha256; cv=none; b=oxgf8Rxayi9PCodaa9/Y/7ZxTECbxqor9qu8I1VIzSd4fSH2dc27D8MdlnrEXeZvWApVdg wjWwcbdn0dZmaskhXVJpC13vSLIzt+yWLPLOBhONzVLoRSz4UGFlDwKbcwgvDQoqOuLuaW ZG1k2dJlwgDT4TnACM6EENZ4KQQeHMQ= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1723497235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NeuZC/AEcA8D8HhnUkFw3ytoFkvPiPSOmUvzwUzhsTE=; b=wc/yb39EmWGMR1ZB4+Z0tZNe/N1pZ6X6IvYLKxL/bigvdlsKIwYH6fJNbDpZlN0ns49E3r WZKb1TBBAAc6eYEaBu/a5YA1ob4s5i/fqPfypjfC3/KRDxYGAD6yVgiYOg/lyvdPkIKi1F jauvhY6tLVXG2LcDIOLnntfM4IuZFD0tkuSh51RXzFCxWq+Gp06gyWPzM5dB4EenXOq/M8 aUJ9FNGsHPJS07dpe0jBCODgyRV9eIfvATHHj2KkSE4nPv847pFFYL+Ay4ESoYWJ8pERcf wxEzTUoCquZ7DruFyYYHRg8GiFMaJXI1oBpxeyzZkaDwe+dV0yCizHJTWnicBA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1723497235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NeuZC/AEcA8D8HhnUkFw3ytoFkvPiPSOmUvzwUzhsTE=; b=4eHEfl5tvOJVNTxtqGe8Ml/b49ud21KXTfzh+r2BchKHsvvV8dMKHmsQNT6Q1XQJUUATmL d7teWs9bIfxE5hCw== To: Max Ramanouski , x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org Cc: Max Ramanouski Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap() In-Reply-To: <20240812203538.82548-1-max8rr8@gmail.com> References: <20240812203538.82548-1-max8rr8@gmail.com> Date: Mon, 12 Aug 2024 23:13:54 +0200 Message-ID: <87y151qwa5.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 891A9180012 X-Stat-Signature: 8boyp7xunao6kh6733rpa1615i7rysqn X-HE-Tag: 1723497237-849791 X-HE-Meta: U2FsdGVkX18M0luqyU0MDjG21Dr6l4IsWOB6Dxj2uSsGWnRWyLU7aK2f5P+DsFuY2GzA7MJ+KdtTfvZlpiawcgaagS29LuBHqMuXWCGKCMv/f635QMBk4rKZdaHfxE9RcwdGxbjfjhvolYxYVSNnAfEdiuqgBc+4VZ3z3xsRuen4mWQQ5XXn4Be2qxAjbR1yeoI8Upmh9DjgUFDLKdAWyE5i8ikHw23/kLnf/moHmE59yDbFsZl7Z7XdsC2W47Ke4o9Oei0++1Qeu8JVnU6q2z9w4m5jESDyhXSgbZVQPQlC1ddKRmfv916zCmKJuqpZEW9yn/2TxWzm01KKyt8/pEEk2NvcVEITs6zS5kGD3ZvgGERAdpiNnxE06TyTpaGlUgXnK+uVuWtGQpMNkSt+rPrFYtzV5UQz6teYa5TESO/uNJ0WJRxaNEknb/Zvx+dTjLBa0bNDpRf6kkyWII3/TfC/wqYTfMmBP9BH+tiuW8pPGrwOZu0zg/vJxZWLOCfQ9nZqZDAeHLoICz7FgBbMo5pyp69a2MULlN9v3VDtATkyd+Sva4xVUpQnYaLqogPG0vZ5biNkbxdAYBQkkye6cDWifzQmkfQagrTYbDFbrlHD021fWu8muZmLxWWqLdfXPhWO34/9yTNkLMbZTH6GbM6YQzDx09v0PkicaLG+t2uOoNcqcpu1X5voj7QlhD6slPgyzRRE250EGvmtvhtmQ7WzAmkFd3bHEWUOnoEd5VAFQFlLSVe591F0tdY1PcgYtPDa3+zkmXIYqWWWdpQHbNRuGXl/hlks1o5eIknJ3K3Wj2JvS+SKwdSPQlfccuc0Z0XyRjAecIff8KMdLFcVn89YphzZkmN7DOnnmIIS/niS8Sdn9BO2lTV8RBonHbztytEnQ14kWk3ZjXAKR00qhLkcTVuApJVT5qsytNwb4HlixPVGukYpEU0+oMzTspJx6Pn4CR/S2oDxLlExTY6 KWQxus0U OMNdWaNKCl3eqhdf5YnkdKpNyGcYraBuIKuwMw/tKEkJTc8uEBH1n0P9/zD2Dj7/oLEM1UIc2nGo2RuqItQpWLOw7u1xf16oLbIdl/jTBaFQYn1MajwAkGimiWFYpJirv6JWSN07u2F5a4O4Wc2EsbwxvH9yK+OwFK6YUrDd0eR2sZFo2k/KDlZqYtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 12 2024 at 23:35, Max Ramanouski wrote: > On systems that use HMM (most notably amdgpu driver) high_memory > can jump over VMALLOC_START due to pages at the end of physical > space being added with add_pages(), while gap for new pages left > by KASLR is as small as 10TB. This results in early exit from > iounmap() leading to leaking, and additional problems with rebinding > devices to vfio_pci from other drivers with error of conflicting > memtypes, as memtypes aren't freed in iounmap(). > > Replace comparison against high_memory with is_ioremap_addr() to > fix the issue and make x86 iounmap() implementation more similar > to generic one, it also uses is_ioremap_addr() to validate pointer. > > Fixes: 41e94a851304 ("add devm_memremap_pages") This fixes absolutely nothing as we discussed already. The underlying problem is that high_memory can spill over into the VMALLOC area. Seriously? Thanks, tglx