From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D865C5320E for ; Tue, 20 Aug 2024 06:26:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 870376B0083; Tue, 20 Aug 2024 02:26:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81FF56B0085; Tue, 20 Aug 2024 02:26:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70F7E6B0088; Tue, 20 Aug 2024 02:26:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 57F6B6B0083 for ; Tue, 20 Aug 2024 02:26:54 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EF5ABC1898 for ; Tue, 20 Aug 2024 06:26:53 +0000 (UTC) X-FDA: 82471640706.12.28B6B7A Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf23.hostedemail.com (Postfix) with ESMTP id B1F6C140007 for ; Tue, 20 Aug 2024 06:26:51 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=ZDNcrElU; spf=pass (imf23.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724135133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EFXLGZEJkQUFQN28krLsjRFbPfS1YdUIsO6keM3oM8o=; b=yCzus6xX73sOuivI1IlYr1J2m34n0xgkgSv7mG8m+UYUi0NrmVJf5WvtYlC6QXOr9sSvS0 mGdqQfs6ikE7U6NXIlJT6vxS0ZxL2bP4AgN9MDEfjR00hiMzO6vxKmJxDNm3BlL8A5nexv LcV0i1ZZAd4mPWcwd60r25eDfbSafDU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724135133; a=rsa-sha256; cv=none; b=YxF+FRwuiG2OeJlqWhah5nMRGJRsZGt4rB6IbPMqTyHW7ZyY4sR3+e3fICW4bBn/w41LTu 6h2mpbZrdHr6m+EBbN87t1Y8wUd+LFTcuekc6qPRMUy8SLZgomQxgenZBBnfLN5Sarrlic CPARux744qbrgOD1vIGChnRXuHgEQYQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=ZDNcrElU; spf=pass (imf23.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1724135209; bh=EFXLGZEJkQUFQN28krLsjRFbPfS1YdUIsO6keM3oM8o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZDNcrElUZ2xY3s8w2eLhoYpi2YViK/FMkN+ADmqFd+TanHYCabHsCvxKxJDrMJmQ3 PALcnEi8+N6YuFVo/NT9ULv1COUzAljpcuypZ5EsiRuQHXj0Y4ejCBMJvxI3/YPw22 Cx1ZzVd1bkUvMnEHpxzGLiv+yEvYtXyS5Oje/tUckPFLL9zIPpyvzxzVgz2GUBwZ3N 6mpBsvhBFEiLa9uIceT/jTftvX4piUfkdT2doVoBbq3BLaEwDAGmCQLSZo7ixVG2WD U/UKzAas2jHBiOPL5qaZxuF4uBCF+93ttNCAf/R7WStVDr/gZVSeIwEjWOctOtHn7y lqUl+TYJ99dZA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4WnzyD15rhz4wd6; Tue, 20 Aug 2024 16:26:44 +1000 (AEST) From: Michael Ellerman To: Linus Torvalds , Nathan Chancellor , Guo Ren , Brian Cain , Dinh Nguyen , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org, christophe.leroy@csgroup.eu, jeffxu@google.com, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, oliver.sang@intel.com, pedro.falcato@gmail.com, linux-um@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon , Linux-sh list Subject: Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping In-Reply-To: References: <20240812082605.743814-1-mpe@ellerman.id.au> <20240819185253.GA2333884@thelio-3990X> <20240819195120.GA1113263@thelio-3990X> Date: Tue, 20 Aug 2024 16:26:43 +1000 Message-ID: <87y14rso9o.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: srf1htdqj7mtsbhujzxe7xf14wj7bfu8 X-Rspamd-Queue-Id: B1F6C140007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724135211-353222 X-HE-Meta: U2FsdGVkX19ztb8UoC88JFslnEGqrNpdC9yuYtvHi5MZl5aq4MUByexpB7yn+xy9ajb/79eBkOmMMDrKmZ5BK4pPMk6duO97TKvsN5xVXbhfwS4HzpLyVthTWQ4TqtblgZwJh5p8hFu6y8ZpAJkE9v894plF/8ZP7Gk6vJ8mTa/jmwH6y7mW+N3GtRLKL+HLOm/ll2I9qOqDYeqZM8cZsC1YOjJosk28DRGy/y9PWPZXXai/v6x7oQoOoW6V0IKerXGbhgmsAZCUIkbM+DsHW10nAp4QXYWrg9/jejLBZAc2gV3ykNGO2PXD9yHTuBQTctf36uFs8VIi/Ee+3XVdkw+rMWpQifZ+pCHuavQwcB0LaqtIvNMTryk0yoyLt9NsHE5LdE/iJuxae9j+NDWam9qSSuB4TAF9iA4dsOp/6kxnVyi4vKi0VYIO+RLX7EqfSkSwwu9bSC/gWUF9XOvVQ4+JtfBSO1rP7p8wSahwNsNAQPWVUgDw1bYYS3bvrIteQxQy3+i49QzDKeJiVit7hBv7659truhOVZKTbJBDamsFzUYwgKH3tNzg01SeHnKmAqiMns44mbB5zXCOANWGqlO0JIAgxHaEOFqixmhU6SSTANxyswnT5pin/LxZ3oxbe82y5zVDtqqMkvtIMGkbhxOy/vGX4LA8TQfnKC0jFmnOpzbLOCH6z4WrCz6Uslu02QybGpBki7dEaPnS+DDvcK8DBSJZbSr6DVxOlq3WnX3E/RxwwNDYB9ImEE8HDcemg8QuNJauNTaxnO7S8l3mFwxJe8kw0JJOeNAMrnVUFz983DJ/qEEJFl83OrOubOfIHH2Xx6ZKAmT/qSaoqooq74HtvzEvxmJnXRyAg0UgpaLZ4DvlRi6vmFvlcG5bSDv13cm4S3TytVsgePhyfhpmqcRNxgL5v3nDk+212VbGn98Zy+eCIDH+PTFEW7pXeTQHJZTH191x5AWDczLuAOI oOR6URvX RSrnW5vIFDDg3bdFLmLnSnwXqYyL0C5unAATbjGNL27PBVbqbyMSpNplTQVjYkp5RX/TpS61pIHvjmDNFlZiZ1iA+oTH4bFqt5DpcuBfQzy2PBo/Nw0fyjVtHjYGMR0eljte3dqxYcapARZzuhFfFlEdO9a+Nw101CXHRoTMEflbX7P1vIJJvoWBE1gPtdcU9UgLISqGRVEovOvOV6MFZA11IUd6KCgkcY2DU8mJ/Vq5vHi9k3f7s7krZxeg/WhORM/gsAq3S4aBuOpbZ/Y9P+jryGxz78F2e5g1dUygvo4/rk2pySj+46eYTppE/JkhRHyn37j2ZSm8P/NIPl3JgJmSPEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Linus Torvalds writes: > On Mon, 19 Aug 2024 at 13:15, Linus Torvalds > wrote: >> >> Ok, I did a quick hack-job to remove that disgusting >> install_special_mapping() legacy case. >> >> With this [..] > > I forgot to actually attach that "this". Here it is. For real, this time. > > Linus > arch/csky/kernel/vdso.c | 28 +++++++++++++++++++++------- > arch/hexagon/kernel/vdso.c | 14 ++++++++++---- > arch/nios2/mm/init.c | 12 ++++++++---- > arch/sh/kernel/vsyscall/vsyscall.c | 14 +++++++++++--- > arch/x86/um/vdso/vma.c | 12 ++++++++---- > include/linux/mm.h | 4 ---- > mm/mmap.c | 32 +++++--------------------------- > 7 files changed, 63 insertions(+), 53 deletions(-) > ... > index 1bd85a6949c4..5e68ab7a8898 100644 > --- a/arch/sh/kernel/vsyscall/vsyscall.c > +++ b/arch/sh/kernel/vsyscall/vsyscall.c > @@ -36,6 +36,10 @@ __setup("vdso=", vdso_setup); > */ > extern const char vsyscall_trapa_start, vsyscall_trapa_end; > static struct page *syscall_pages[1]; > +static struct vm_special_mapping vdso_mapping = { > + .name = "[vdso]", > + .pages = syscall_pages; ^ should be , > +}; cheers