From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16F70CD13CF for ; Mon, 2 Sep 2024 16:15:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B2EC8D00F6; Mon, 2 Sep 2024 12:15:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 862BA8D00EF; Mon, 2 Sep 2024 12:15:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72B318D00F6; Mon, 2 Sep 2024 12:15:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4D40E8D00EF for ; Mon, 2 Sep 2024 12:15:48 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EEB23120271 for ; Mon, 2 Sep 2024 16:15:47 +0000 (UTC) X-FDA: 82520299134.02.29D1565 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by imf18.hostedemail.com (Postfix) with ESMTP id 4F9CC1C001C for ; Mon, 2 Sep 2024 16:15:44 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="HvPl/qqv"; spf=pass (imf18.hostedemail.com: domain of jani.nikula@intel.com designates 192.198.163.19 as permitted sender) smtp.mailfrom=jani.nikula@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725293651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0v1sfSEWY5jSa7FrPlu9e9bEiWlpHydxzypvBUU6qV0=; b=PmKCpM9qes2ixo+aZ04yCe1SDeBw0rMkx5IXFNbIrdmAymRdZthJ3T38gmeKxXrfdmeRPC H1UCrw/mKU7PEJh6Cc1tLP3T8YtNje8cmDaR27trOELij6WCbflbO/Z6u1ZTRfLG6b//sm JHeygsFBXBbeRd/2kir1z9fUvDCrwyA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725293651; a=rsa-sha256; cv=none; b=d9p4MWi1SMDJMds5s5BbFwXjMwzfJKZygso9cuhn5rq3/9xt235+iSUcL/PoYgR0Y+63AG xvw1EOh0mnbCZAa7arqgw3hIFKxbbSaqs2YJ2f3SWMxj3blHVCWQC8JAydECIS+dxwSK2w mRBkCLDZgl5HhEWVFbzcaW6iKarCGUQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="HvPl/qqv"; spf=pass (imf18.hostedemail.com: domain of jani.nikula@intel.com designates 192.198.163.19 as permitted sender) smtp.mailfrom=jani.nikula@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725293744; x=1756829744; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=UvIJZ7bYERYqwsuwrbSpVj2YegamCtPJzXRVn+BwiYc=; b=HvPl/qqvIvuOZSRCPGDjKDcKpQPuoT05jcZnV5kjFmpQSumdE+vihXg7 rpWc6qqwGZhtQK/aa8gWT4uR3ZPx1WvyOlooW000niCnceoE+vR68PKlx ViySTsutsO4SRxvPfd1E7zeWDzdvXt9Ten73mRNB/XI3lfl68Pw436kn7 K+qBUR+hIhKLsb0jAE/lOgRTj2FKKZ0U0y6kmNmFATrV+glKq8tYe2qqJ 3ShD/PyD3vZy9ZOvge6RhwUrM0rPKbtX4+9DTZFZMlvioZKU7qxODoQN2 nOFTjKoVxXNmcSSSSJ/yOojpqZSAwrLVTG8CsP2S0rgf9wnDVvTH65OUF A==; X-CSE-ConnectionGUID: 1DCN/ukPQr6eNCUu0y7BvA== X-CSE-MsgGUID: BI/U+3EWRaK0uaWALj67ew== X-IronPort-AV: E=McAfee;i="6700,10204,11183"; a="23447615" X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="23447615" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 09:15:43 -0700 X-CSE-ConnectionGUID: 1v07Ku3xQw2N05n5BqR9iw== X-CSE-MsgGUID: xUo9z+pJQsG0uufZgZZaMw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="102098298" Received: from ltuz-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.4]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 09:15:40 -0700 From: Jani Nikula To: kernel test robot , oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Daniel Vetter Subject: Re: [linux-next:master 6570/8400] drivers/gpu/drm/tegra/output.c:42 tegra_output_connector_get_modes() error: uninitialized symbol 'drm_edid'. In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: Date: Mon, 02 Sep 2024 19:15:27 +0300 Message-ID: <87y14at4kg.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: ippdfw1zfznifn93fo7qoucepm3nibyi X-Rspamd-Queue-Id: 4F9CC1C001C X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725293744-261097 X-HE-Meta: U2FsdGVkX18P/Gv8tFXpf8aCkQ3YY+/x3WcT8/Zo1br6fwCFWnAu4EXG/nzHObYZnIjjebm8i7lt1qEIsCqOlAW7zB//KH2Xiq2L08jadvf1h4RPfv9BWeCZ8qJI1ubtJSlGIZ5GdGBMOQpyFI3Kaf+EHzRtpcYjL8b1tUH2IglLJs2gpg3s1hRn+TWTNUBSjIExQgaUPoTpHCjE9Mgy3E/+BT3NwVxW0KwME9MpS5lqZ38XI9C04JyhoHLK40qeTxRopxFACv+iUvN36BApb+8hMFfQeyNURoCTODB2swWq/S2czBobkTbVInDyQWKkvBdovs3ZG+B1Gdo8T2sJavdyFtrCY/Y9+qWNgdtxlg7iuj8qg6rgpvLAy5Fny+80zNYMWQ/nVJMDkyKHEBdQSD2xHztFQwZWx3iUafGeOVqqxjfqFLYsaNqKrR6BRm7y/38Hc/EjW20sCFjXfMKu6y1AsrxoYQ8o3VrbA/rmTLRv/2Z8+yYKPrdSr1HjcCzDOAdjMO28PfGZDJrPOI/YFGV3nBkTqsZCo7DFkJYkpU74r30nYUvYLj6Jd462weBhMoC+0WUzrKjKq16czW/luAf1b0jX+a2SZjtRmlIoTaGCs8pwnHTszTN890WWq9vUNzPQD1432OgTB7nXdo5SMl9oRDbuMNuT60JVnfaSAt8H2wbqXmOUs6Jzga3Wiz0jMFVHgRazJg512KGF8BSacwB2nUVj64lu41KvvMKp7qFCspB8ez9LEAOvHLmG3PADW6boyOpfA3JCSGgy27wNWGYaqDPBmx6FL6cidd/bbthVf7V0FHXH7YegJEsvFeUVOHY4LUSO4UK4Vs4kFoznIWbh8D+IKLy7oXY44q4WKWYhjCwhs/UVRGF+R5PeATZ8SUhNjnafqfHK9ah61plDhMP4gS8UBgH08LmvmqygoIsgDtzSnadNozV+LHDKq3NZjIdD4mlCPjtaB3PtrtF rIPHFuOn 3oRnXrXrMnC9FHGRguf2H0Sn3rGT3p7tovtdFAFgehi6L8oJCIKnoWJDmiTDOXGkNtBsuzrU77yGtyj0N0N1TFHL7ZtPvc45mgQWtX87DMVm0HdunFN8U7N5rB445VcYLmgMywjvPN0kFfpsXXWKAqd+80tE0WNkSB+6Zkzmn2P9RB6gPzKrYZ29QoZDnXdQArpebbLlj2eo4nH+zgWWct5NRZsNT8vREzsmsnbVWiw2LFk/dYEuiT+tzdSyyABaH0u8yNBotxzxQg985Ih3uKi6oAXklc283Gjolap1wjXKvJQ+d+m9ZCizsphYu6/UfIsWWzvgnIpWXlw7G0cBsZzKPTl1aWoslPbBP9kY5ty99l+StodX4kOatGvhUumrvmTXNRa2wShvu/5KLN//UQM7QCnwS9UvXCLxr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 02 Sep 2024, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: ecc768a84f0b8e631986f9ade3118fa37852fef0 > commit: 98365ca74cbfae16b793b62a7ecabb5be8d77785 [6570/8400] drm/tegra: convert to struct drm_edid > config: nios2-randconfig-r072-20240902 (https://download.01.org/0day-ci/archive/20240902/202409022236.7pEcEksT-lkp@intel.com/config) > compiler: nios2-linux-gcc (GCC) 14.1.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > | Closes: https://lore.kernel.org/r/202409022236.7pEcEksT-lkp@intel.com/ > > smatch warnings: > drivers/gpu/drm/tegra/output.c:42 tegra_output_connector_get_modes() error: uninitialized symbol 'drm_edid'. > > vim +/drm_edid +42 drivers/gpu/drm/tegra/output.c > > 132085d84fca65 Thierry Reding 2014-11-28 21 int tegra_output_connector_get_modes(struct drm_connector *connector) > d8f4a9eda00678 Thierry Reding 2012-11-15 22 { > d8f4a9eda00678 Thierry Reding 2012-11-15 23 struct tegra_output *output = connector_to_output(connector); > 98365ca74cbfae Jani Nikula 2024-08-22 24 const struct drm_edid *drm_edid; > > There used to be an = NULL here. > > d8f4a9eda00678 Thierry Reding 2012-11-15 25 int err = 0; > d8f4a9eda00678 Thierry Reding 2012-11-15 26 > acde541324dcfe Thierry Reding 2014-01-13 27 /* > acde541324dcfe Thierry Reding 2014-01-13 28 * If the panel provides one or more modes, use them exclusively and > acde541324dcfe Thierry Reding 2014-01-13 29 * ignore any other means of obtaining a mode. > acde541324dcfe Thierry Reding 2014-01-13 30 */ > 9be7d864cf0763 Thierry Reding 2013-08-30 31 if (output->panel) { > 06c4a9c2ae606a Sam Ravnborg 2019-12-07 32 err = drm_panel_get_modes(output->panel, connector); > 9be7d864cf0763 Thierry Reding 2013-08-30 33 if (err > 0) > 9be7d864cf0763 Thierry Reding 2013-08-30 34 return err; > 9be7d864cf0763 Thierry Reding 2013-08-30 35 } > 9be7d864cf0763 Thierry Reding 2013-08-30 36 > 98365ca74cbfae Jani Nikula 2024-08-22 37 if (output->drm_edid) > 98365ca74cbfae Jani Nikula 2024-08-22 38 drm_edid = drm_edid_dup(output->drm_edid); > d8f4a9eda00678 Thierry Reding 2012-11-15 39 else if (output->ddc) > 98365ca74cbfae Jani Nikula 2024-08-22 40 drm_edid = drm_edid_read_ddc(connector, output->ddc); > > I mean presumably either ->drm_edid or ->ddc is true, but you can see why the > checker complains. Yeah, my bad. Fix at [1]. BR, Jani. [1] https://lore.kernel.org/r/20240902161317.2437148-1-jani.nikula@intel.com > > d8f4a9eda00678 Thierry Reding 2012-11-15 41 > 98365ca74cbfae Jani Nikula 2024-08-22 @42 drm_edid_connector_update(connector, drm_edid); > 98365ca74cbfae Jani Nikula 2024-08-22 43 cec_notifier_set_phys_addr(output->cec, > 98365ca74cbfae Jani Nikula 2024-08-22 44 connector->display_info.source_physical_address); > d8f4a9eda00678 Thierry Reding 2012-11-15 45 > 98365ca74cbfae Jani Nikula 2024-08-22 46 err = drm_edid_connector_add_modes(connector); > 98365ca74cbfae Jani Nikula 2024-08-22 47 drm_edid_free(drm_edid); > d8f4a9eda00678 Thierry Reding 2012-11-15 48 > d8f4a9eda00678 Thierry Reding 2012-11-15 49 return err; > d8f4a9eda00678 Thierry Reding 2012-11-15 50 } -- Jani Nikula, Intel