From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3C4CF58D4 for ; Fri, 20 Sep 2024 06:30:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C46136B0082; Fri, 20 Sep 2024 02:30:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF6066B0083; Fri, 20 Sep 2024 02:30:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABDB46B0085; Fri, 20 Sep 2024 02:30:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8E9DE6B0082 for ; Fri, 20 Sep 2024 02:30:28 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EE07B4121F for ; Fri, 20 Sep 2024 06:30:27 +0000 (UTC) X-FDA: 82584142494.07.44FEC65 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf05.hostedemail.com (Postfix) with ESMTP id CF2F110000B for ; Fri, 20 Sep 2024 06:30:24 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Iw10V43D; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726813733; a=rsa-sha256; cv=none; b=0YP57eVqlV5uGI6E3wjX21wIIhjQ4zC/m7OiUjsnzDdU9Zeqm2fXjagxgjyVrGRcXBtLWQ r8WVxlGuzYo806bA3C0x2TPLOE9XeLT/kwb0f75dyGM7suO3xdSzzqpYpJ8mpko6vwVZti y7BeLm3/xW5MxlP13jL+hJb5e9FFRtU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Iw10V43D; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf05.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726813733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CUCTKkIP6TiZiYiRTwdOZazzEM5EBw5r0LZsq9Fet3A=; b=VxuDoQoZtst0Kf5Sc6p7OIx/2SoS1ZO34B1qNZXPo0fSb2XpdJqp5JtMTOY7O9+kkVER6B 8/Pc/q4TP5ZXpIUTrg8t05OWX5uYFUimcHw7jGzNgTVpiP1QCc5IQ1rlYi6Fjcq98OKWjf v569hD0mqM1+xgKMXo6yR6SbaX7Av8k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726813825; x=1758349825; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=Pe+WAPxzuTGsBBQQqGPEUm+5Sp6gIwkpDFcWs09U3uk=; b=Iw10V43DzcX2bcukJO8DLYOoN3U8E+GfsOPgQ2U+j8QkvJrz2Wol3PNL eUnC37/T1jpgcOjnzXf7i2tu8EdBZN7SY0zKCtfX3Vsyi7oxKS+8w2bod pbIoYkdthni7SF8jnzvG+H/Py34MDxiCQ2ywkLLQZW7ZrzSE36rf4q9gw bsR2z8Nc0t9b6ZnZSRZ4zd/FlIY2oR2sjNp4zL/HNoGlvg3PIUvT7ZyH8 IVZZ17/OhBE9iXpGvGmjfrP1FyJ+6UeVxf+qmtlZIgPDmXzkdXDV0EZTX WXUz5Szb2eiHGT/SJkzZvdMedBdpZcaFavcxbJgntmW2mYRfgPyuUudqz w==; X-CSE-ConnectionGUID: 0kOINi9XTYq4NUciZIrS7g== X-CSE-MsgGUID: J3B5N5qzTaqwf6sVGjVPwg== X-IronPort-AV: E=McAfee;i="6700,10204,11200"; a="25955162" X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="25955162" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2024 23:30:23 -0700 X-CSE-ConnectionGUID: s4VNOZFQR3KH1wrfl6dlxA== X-CSE-MsgGUID: qjxvegbvR/WQmnZ/0KgEAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,243,1719903600"; d="scan'208";a="70203435" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2024 23:30:21 -0700 From: "Huang, Ying" To: Waiman Long Cc: Andrew Morton , Alistair Popple , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memory tier: Remove unused default_dram_perf_ref_source In-Reply-To: <20240919191357.49976-1-longman@redhat.com> (Waiman Long's message of "Thu, 19 Sep 2024 15:13:57 -0400") References: <20240919191357.49976-1-longman@redhat.com> Date: Fri, 20 Sep 2024 14:26:48 +0800 Message-ID: <87y13mvo0n.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CF2F110000B X-Stat-Signature: 5ashjr98uqbn9etntrjcrcpa44nhwx1e X-Rspam-User: X-HE-Tag: 1726813824-356102 X-HE-Meta: U2FsdGVkX1/S1Y8EcQOvkEbilRmyawFYEL1gzbQ6CJyury2WRfW3ae6x5koUy3Iagie79U27JwHzju7CxCXt5+5WvA5RfNwxh9oDD8o03jx0r72eNoOptRgCF+4YN4OPVbF12om8gaUvDuXLC65bhXLdmXoVKD4rzKuIfOcjvLaNEv9k6wKzw1A8PUMwbOlgD/HJNLO6dSoBkOhF/gYdy8bIx0oGtSfYQVYLYKhCs6PbQKCA2zPv3M/ayA6EQi5vtgrrx0ZvAJIThqDtTU0RuXOxt4ZzDLBP3qHDwMGhooKLmfSo6duaZjp0+g+aCm6Ms6B2Slb5ILWpYs1KcPfhi6sDb3rVn80tZKu2OokKyYLnX+nc1Lrij6jn1GAZozgkrEeYf8nj+imN523JMLelJ30nvtlBAZB8WIJxsdalRjGZIAev4dxGYQxnmSwk2NWAGvOPlt7RIAdfCS4EoMAc1lSN4osefZwMqxM6SCnHN4gge+CFzMCdH9xQFqBwarZevRSI9iW4mvVj2VDA0QQx9yBV2ma/2pFbtyYiHUjapakChCtmUT2D0w8YE1P43WekrdyoKa0fK2IlnjPqbiIEhjBTuUbzd7OKYmXTRVYRdOaH3+5MBBD99WOhJaZPNfz7ATxo0s++fRLSqwfFW0wQtNnD3ZvOl/LZsE6Vj18t37I+m2tNr/hN3oI1pyFL7mGDazxaqkTuNdN318HbadsDGPsihq6k5oA/2Aeggx5kQfOxD2aH1ywvs/M+3fdVI7k9qGKYDuJI2EqN8UM+u73OePJxOMcf0omOGyPwisknCXZ5BoU4nHOT2XaBFXKR+1qX7lhudV2EAZC6hFphSOBFuOWSn5gEKrmMv5ap5bmGpvMkLFl1fRwiAOMlcJYIR32jPzcnygP4yavw9TXv5Dx7IcOkk/8oXKTlsG4VKOAAuGg7I6IscjCTYXYPfmJKoDFP0GZnM20ijYCzRGfGtUW 0pbS8VYr JC44YF36F98M7JBSB99MVmvhDRKozjVBsSZpVKfWOMd+NOICQMQPxdHjV+3HE+rPVJhXYY1hIsOFb9F9ILGUmJy+tDdw8VVGgOds4ylXWsGj7w/3IkQUffJ8sX7puw4nb2SMmCT5i1jie+ZwAkBj3d23K29u0ZDdfJ3SxPXfBzvXGPtV01ajaKnbY0Nb0Rk4EYTv3QiJJlIo6I6htIdLl1ykMbTt6MCA/YLYLEgvD6yYr5rQpNivrZtCjLiK1yDoPfHuZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Waiman, Waiman Long writes: > Commit 3718c02dbd4c ("acpi, hmat: calculate abstract distance with HMAT") > added a default_dram_perf_ref_source variable that was initialized but > never used. This causes kmemleak to report the following memory leak: > > unreferenced object 0xff11000225a47b60 (size 16): > =C2=A0 comm "swapper/0", pid 1, jiffies 4294761654 > =C2=A0 hex dump (first 16 bytes): > =C2=A0 =C2=A0 41 43 50 49 20 48 4d 41 54 00 c1 4b 7d b7 75 7c =C2=A0ACPI = HMAT..K}.u| > =C2=A0 backtrace (crc e6d0e7b2): > =C2=A0 =C2=A0 [] __kmalloc_node_track_caller_noprof+0x3= 6b/0x440 > =C2=A0 =C2=A0 [] kstrdup+0x36/0x60 > =C2=A0 =C2=A0 [] mt_set_default_dram_perf+0x23a/0x2c0 > =C2=A0 =C2=A0 [] hmat_init+0x2b3/0x660 > =C2=A0 =C2=A0 [] do_one_initcall+0x11c/0x5c0 > =C2=A0 =C2=A0 [] do_initcalls+0x1b4/0x1f0 > =C2=A0 =C2=A0 [] kernel_init_freeable+0x4ae/0x520 > =C2=A0 =C2=A0 [] kernel_init+0x1c/0x150 > =C2=A0 =C2=A0 [] ret_from_fork+0x31/0x70 > =C2=A0 =C2=A0 [] ret_from_fork_asm+0x1a/0x30 Good catch! > Fix this memory leak by removing default_dram_perf_ref_source. We should have used that information. So, I suggest the fix as below. Is it OK for you? ---------------------------8<--------------------------------------- >From 32e6d70f531718cf99064a43fdffc8639aedcc5c Mon Sep 17 00:00:00 2001 From: Huang Ying Date: Fri, 20 Sep 2024 09:47:40 +0800 Subject: [PATCH] memory tiers: use default_dram_perf_ref_source in log mess= age Commit 3718c02dbd4c ("acpi, hmat: calculate abstract distance with HMAT") added a default_dram_perf_ref_source variable that was initialized but never used. This causes kmemleak to report the following memory leak: unreferenced object 0xff11000225a47b60 (size 16): comm "swapper/0", pid 1, jiffies 4294761654 hex dump (first 16 bytes): 41 43 50 49 20 48 4d 41 54 00 c1 4b 7d b7 75 7c ACPI HMAT..K}.u| backtrace (crc e6d0e7b2): [] __kmalloc_node_track_caller_noprof+0x36b/0x440 [] kstrdup+0x36/0x60 [] mt_set_default_dram_perf+0x23a/0x2c0 [] hmat_init+0x2b3/0x660 [] do_one_initcall+0x11c/0x5c0 [] do_initcalls+0x1b4/0x1f0 [] kernel_init_freeable+0x4ae/0x520 [] kernel_init+0x1c/0x150 [] ret_from_fork+0x31/0x70 [] ret_from_fork_asm+0x1a/0x30 This reminds us that we forget to use the performance data source information. So, use the variable in the error log message to help identify the root cause of inconsistent performance number. Fixes: 3718c02dbd4c ("acpi, hmat: calculate abstract distance with HMAT") Signed-off-by: "Huang, Ying" Reported-by: Waiman Long --- mm/memory-tiers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 4775b3a3dabe..0f5ba5c6e0c6 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -749,10 +749,10 @@ int mt_set_default_dram_perf(int nid, struct access_c= oordinate *perf, pr_info( "memory-tiers: the performance of DRAM node %d mismatches that of the refe= rence\n" "DRAM node %d.\n", nid, default_dram_perf_ref_nid); - pr_info(" performance of reference DRAM node %d:\n", - default_dram_perf_ref_nid); + pr_info(" performance of reference DRAM node %d from %s:\n", + default_dram_perf_ref_nid, default_dram_perf_ref_source); dump_hmem_attrs(&default_dram_perf, " "); - pr_info(" performance of DRAM node %d:\n", nid); + pr_info(" performance of DRAM node %d from %s:\n", nid, source); dump_hmem_attrs(perf, " "); pr_info( " disable default DRAM node performance based abstract distance algorithm= .\n"); --=20 2.39.2