From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBCFC36014 for ; Tue, 1 Apr 2025 09:20:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FC46280002; Tue, 1 Apr 2025 05:20:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D2D6280001; Tue, 1 Apr 2025 05:20:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C184280002; Tue, 1 Apr 2025 05:20:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F86C280001 for ; Tue, 1 Apr 2025 05:20:21 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 336791CDE62 for ; Tue, 1 Apr 2025 09:20:22 +0000 (UTC) X-FDA: 83284929084.05.5BE5405 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id CB1D64000F for ; Tue, 1 Apr 2025 09:20:19 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RDsOvLWs; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743499219; a=rsa-sha256; cv=none; b=P0ejhMSl7SvCq0GoaFKAsCxlyRvkjG+Hu/17mv4w+NABO7D8k0sgEche4WLzqkxdOLhJAJ Vh+iAoGEIGiomSdeQ/YFODODC32JgcQSUoFEI1r90r02eDSp4Y8UXOzSCUJKi8DLVWQ34M oflq/Rg6jdIhYVqANj0ff2z7baK8OmA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RDsOvLWs; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743499219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lWbiclfzpKSwLJOdwlITi17a8q/U4ESB6TmKC2UsDZE=; b=BtmOfFHktaGsKLIA7HsUN+necpyvViN5A5j9o/VbonlTh075yrdDmQoRvxFuGAKBLw7m7l 01rnyofwGQTpByv17v7ffwlSzkGvzMoj0viOGRZOVXKeVcyjOIgT2ipJuFVnZUOoPYodM6 6uJrw4dyf3RmFVTzQUyf95tIPE2xfvg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743499219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lWbiclfzpKSwLJOdwlITi17a8q/U4ESB6TmKC2UsDZE=; b=RDsOvLWsIxfhDIoMvX3xV+ISFYioRCKACHPIqzdHQer8Ny48o/1XmEwvrxrBxabcPbtI6Y NPKtBGAPYKaG7J2gnK37d+8C+lSwFtDM2iO+oLCKfveP76vkipfdISLjVWZ53lqpko2a/y YT8FqWXIuxzU7qdVs773NNuAa5y2LwU= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-QJ3UkZGEPmSCJsaImQeD1w-1; Tue, 01 Apr 2025 05:20:17 -0400 X-MC-Unique: QJ3UkZGEPmSCJsaImQeD1w-1 X-Mimecast-MFC-AGG-ID: QJ3UkZGEPmSCJsaImQeD1w_1743499216 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5499a93f894so3334189e87.1 for ; Tue, 01 Apr 2025 02:20:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743499216; x=1744104016; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=heGA+8Yin7XsohFnbU8J4lLXr8jl9xDIj/NCrhpNVe4=; b=d+Tux5Zg4RW1EooAT4NLL28YxrMRznrbpncsTL23siQ/R+Ti9K5/VzaROWXjJqpVQG 8TLWzROxJ24Zi5x4T6XRqjbq/Ae0i9/UBcCe+QqS+e0lGbOKFw5rZ8AshMDYta2RwjzY q9upkrVNsTkI3ZBpDvqLPkta6xR78a0Tw64yCfJj97p9E5N5H2juF+UOH0aTF572dknp Om0B7ZK5MWtQ2PHzVSpxdK7RrB771VOP/30oIR0sZ+9Gqz37dMwckateumpxgjZcsj16 Z3InwZP6VDuwhb5kDZsQJOw9C/LEWHP8ylobxwFP5f+oiXrI1BZ2ZjEb3TM0hQQ2OVdW MW/w== X-Forwarded-Encrypted: i=1; AJvYcCWCvISQhdhp5XZOkL3UkAH9dHzSNBdqQSQbRqcb8n+BYBFUazwYj4c1YhVbLUT4JSBXQF9iUCB/ew==@kvack.org X-Gm-Message-State: AOJu0YzoE462zSja2Qg6F3uurvfl86J2rJX7JKs6tHx49brq+trD4lW7 cH8+8DjyokAREvmjKbY2pwjujstoACRXUeofd06WCLcnpeNU3Py3c/8kep6uEvNNDICIeeT3+fm qZ7V2HTlq40Mh1SJ9DB3O39oti01iczgq2IHPB6cRmM6SIuNy X-Gm-Gg: ASbGnct53sC2quE0oY5hIfGynvXk+iI3a2j0DUyjto8ksIA+rYvuSxvDrHlMblw23KO 5qPbWq+tDuYvpzS1Lymp4vLptVE6LYzK9YdyFMFrY7tVuirz7DuDawgOnJXlcQR1t2dPxuezcVR pad6TD/7TtdB+1OaHCHDdCv9qp/3vRTtjQHneY0fJoVKRcpRwGjVJ6P+IB+BW6guFELYHD6DsJj BF0ncTSV0QpKg1SZXzwem66ktqcwn06hiwq/tkMsLmnyZv476AteoU16MIj80Lu2wvX1hCwNqfP kwmiQxHmyluSBCYhYzdI1An/60PfIPgp971VZkKc X-Received: by 2002:a05:6512:3f04:b0:54b:117f:686e with SMTP id 2adb3069b0e04-54b117f6902mr3637432e87.27.1743499216264; Tue, 01 Apr 2025 02:20:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmmFffSwB8Z29FU4ImF8MFszvFBnxPrac+wWziJPyVeOFUs+I7ScJdTpfzV4RapF89FKPnIA== X-Received: by 2002:a05:6512:3f04:b0:54b:117f:686e with SMTP id 2adb3069b0e04-54b117f6902mr3637402e87.27.1743499215879; Tue, 01 Apr 2025 02:20:15 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b094c1db9sm1297217e87.78.2025.04.01.02.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 02:20:15 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0BCA518FD259; Tue, 01 Apr 2025 11:12:36 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Paolo Abeni , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, Qiuling Ren , Yuying Ma Subject: Re: [PATCH net-next v5 2/2] page_pool: Track DMA-mapped pages and unmap them when destroying the pool In-Reply-To: <38b9af46-0d03-424d-8ecc-461b7daf216c@redhat.com> References: <20250328-page-pool-track-dma-v5-0-55002af683ad@redhat.com> <20250328-page-pool-track-dma-v5-2-55002af683ad@redhat.com> <38b9af46-0d03-424d-8ecc-461b7daf216c@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 01 Apr 2025 11:12:35 +0200 Message-ID: <87y0wkmeik.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: N9dzR45KpprzkBfAfMVT7CMS8a5PmvKYCcmf8srNEq0_1743499216 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CB1D64000F X-Stat-Signature: r484ac4mxmxczz8d851gsrzofwhj9tsy X-HE-Tag: 1743499219-597389 X-HE-Meta: U2FsdGVkX1/mkNdE+MAWypFNbLjtmS7LJIi1RqZJvRASnpTubEMbUVDAYtc5O1Bw3LwUHqs2iDfDbh1mm07gwUFY+M4blAC+rW0GYZlpx64bE4wwajTMFMlVAC6WNtcPWrCbi/qCc6E90YFuyQtQ6IkfzJE8tiTSzInpVvl32RH6nBVM/iZeScRJ7ZmmD/V/QkLUouqNsuetiVH6TO+RBrVjdsY1/7NwA2Nw3K1RM86rXdqquC12pQk16jxgy+jhkDeD+gSQaqY0IGM2We1KIpXldBVyf9J5Wfm4x9v3Wg6HXLZRdqTBOFmRfDzp4VgZC50nRIH4LPFFjKS3kz/XraeHLHjTPZYK6k/NVJZKOzuYP8Kxn0fSJOjhe8P/wZWMUU9BIO93PqdjMecyWJggTBFRSOTWulPZ+m8CbBpZML8f92z4IoEOFU359aqR6pZWf2dtoMp38HgKfBGiXS2qm0cu2zGBHjEyjZNWB5Douq+v19xPtv9j7666kA1rEoSZQjACkum6Av/L7hmVuJzI8RLeK8Pjk0t0/pB7/SMSG3yVUz1NfLEVxZdvD8cXALpd95f9yIjDkmPpKZbL6taF3jej0pQ0oC52TosLGOYWbdM09kcn9HMXwqVn8Iy/jC+08InUbDeMB5Co/bVFzTidcYTDMuaLeIQWRYhWE6QyvGI0DpzK2u6wsgFH/rQgSCpi0/EK/Dpq8m05U5FVuBK4V1+498A72zEeDNxv8v428khFCNcfGASLWXFwBsbcDcpv/ynynfKtmk7CVc7g22BZk3HfV+Fmxeenv/55q91/McuaOdcJWF0vzL31dQ7wAzwwAOGY1okr5tYGMYIsxYfXL87r/6DT/AsAttpUShuyOhdBBfW7levHHong/N7lJMfpiJ+oH86BKeGbk5mXJNs87pHlvv0yvePx03jgoRlsd0+xjfOTYaajAyOQMSJE9JHoHJ+coIkgOzIEVTcFVLK zXzw7n+I 2sx4pwWPXavuPx7SmSCOujLo+Yd+U8R5lZpkMPFEi6yiWO9RkueFMC5+PODPQTB79yJGVL2o9GrPHM3AK2nEyJyEpmYMLZNlhvRoOWj9pvD0GO/yilLAXh3nQ9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Paolo Abeni writes: > On 3/28/25 1:19 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> @@ -463,13 +462,21 @@ page_pool_dma_sync_for_device(const struct page_po= ol *pool, >> =09=09=09 netmem_ref netmem, >> =09=09=09 u32 dma_sync_size) >> { >> -=09if (pool->dma_sync && dma_dev_need_sync(pool->p.dev)) >> -=09=09__page_pool_dma_sync_for_device(pool, netmem, dma_sync_size); >> +=09if (pool->dma_sync && dma_dev_need_sync(pool->p.dev)) { > > Lacking a READ_ONCE() here, I think it's within compiler's right do some > unexpected optimization between this read and the next one. Also it will > make the double read more explicit. Right, good point; will respin! -Toke