From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91099C25B08 for ; Wed, 10 Aug 2022 00:54:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE70C8E0002; Tue, 9 Aug 2022 20:54:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A96838E0001; Tue, 9 Aug 2022 20:54:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 936A68E0002; Tue, 9 Aug 2022 20:54:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 85A6B8E0001 for ; Tue, 9 Aug 2022 20:54:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5290280EA9 for ; Wed, 10 Aug 2022 00:54:07 +0000 (UTC) X-FDA: 79781861334.20.78AA3DB Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf30.hostedemail.com (Postfix) with ESMTP id 957218006E for ; Wed, 10 Aug 2022 00:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660092845; x=1691628845; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=nItkLIlxJEYz2NOoOOtaYjhZi5bSbXZOnKdSyUbLTIA=; b=CQcfN82PwWt8XJqULcta599gCIMoBL/1dJi/6+yxiuogamxtWr0XshRu ystir/YXIxddBGRg6vo9wnBD9u8Y+tmmlfzjJ6BpjyH8oTbVyQbC4SjZT GOEMuqrC0ABbRdWfIrIVC8z3VvjzyShvLD5HEgJroB8XPJaXtxtL6tEFn cjm40QSF0K8W4Kl+XkJ0lL8EABD2jNxoUZM93nnME0Y1kRO2TVqjdwtOQ 2FRT4jC3Q++AF+VYmXkHulhtEWtKv9OHUsu7QfNNlFnyos0jzehvzTMad 3p4G2VJc/V2Vv3Ugc0S6rmuJpHbr8kk9eiHUFvDjfEYV/SnN9sAtfkHiF Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10434"; a="377258668" X-IronPort-AV: E=Sophos;i="5.93,225,1654585200"; d="scan'208";a="377258668" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 17:54:02 -0700 X-IronPort-AV: E=Sophos;i="5.93,225,1654585200"; d="scan'208";a="581024195" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 17:53:58 -0700 From: "Huang, Ying" To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , David Hildenbrand , Minchan Kim , Andrew Morton , Vlastimil Babka , Nadav Amit , Hugh Dickins , Andi Kleen , "Kirill A . Shutemov" , Christoph Hellwig Subject: Re: [PATCH v2 2/2] mm: Remember young/dirty bit for page migrations References: <20220804203952.53665-1-peterx@redhat.com> <20220804203952.53665-3-peterx@redhat.com> <877d3hhksz.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Wed, 10 Aug 2022 08:53:49 +0800 In-Reply-To: (Peter Xu's message of "Tue, 9 Aug 2022 13:59:48 -0400") Message-ID: <87wnbggbqa.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=CQcfN82P; spf=pass (imf30.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660092847; a=rsa-sha256; cv=none; b=N2ZX10f5YRiyZxTt8aYSVCwREi0jKVWqe3UKmx+IFl3NwQZlQLajkaQ3FwvkUDQNLvvFD5 M/LZwZm0yLihJTkeW4QVXLZo4QEC6UZgX0brSzu9TX2lKcEXWsTRygpdebjDydzAPlECd0 ZPYJ8ro6/FCtYXBK263pIG60Rbr3M5Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660092847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=miP9cihNzcErWJWcmDTEoKnlnDOiFQI22mTMj5CISjw=; b=y8GYOmrN3vgWikxNSMHqDc2WXJdN3l++2nhxBY5jnUWapAetivxNocVij+L1S8+la3DFko wMQ3/43326U/yNmI1NB+2RzcBFdTW2vNP84jJM4D8r3+Csew7p5+wbuH83i2ChkIvP+OsZ pr5EBwcGALFNDL49l3vJhfH9jzelJd4= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 957218006E X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=CQcfN82P; spf=pass (imf30.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: u6ipdcfcx6gtey8fi4g8k5akyac74xwm X-HE-Tag: 1660092845-194568 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Peter Xu writes: > On Tue, Aug 09, 2022 at 04:40:12PM +0800, Huang, Ying wrote: [snip] > >> I don't find pte_dirty() is synced to PageDirty() as in >> try_to_migrate_one(). Is it a issue in the original code? > > I think it has? There is: > > /* Set the dirty flag on the folio now the pte is gone. */ > if (pte_dirty(pteval)) > folio_mark_dirty(folio); > Sorry, my original words are confusing. Yes, there's dirty bit syncing in try_to_migrate_one(). But I don't find that in migrate_device.c $ grep dirty mm/migrate_device.c if (pte_soft_dirty(pte)) swp_pte = pte_swp_mksoft_dirty(swp_pte); if (pte_swp_soft_dirty(pte)) swp_pte = pte_swp_mksoft_dirty(swp_pte); entry = pte_mkwrite(pte_mkdirty(entry)); I guess that migrate_device.c is used to migrate between CPU visible page to CPU un-visible page (device visible), so the rule is different? Best Regards, Huang, Ying