From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D0DC433F5 for ; Fri, 30 Sep 2022 16:35:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FD498D0003; Fri, 30 Sep 2022 12:35:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ACC48D0001; Fri, 30 Sep 2022 12:35:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14D608D0003; Fri, 30 Sep 2022 12:35:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 06E798D0001 for ; Fri, 30 Sep 2022 12:35:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CE215815DF for ; Fri, 30 Sep 2022 16:35:47 +0000 (UTC) X-FDA: 79969303134.18.F1F982D Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by imf24.hostedemail.com (Postfix) with ESMTP id 5D0BC18001D for ; Fri, 30 Sep 2022 16:35:47 +0000 (UTC) Received: from in01.mta.xmission.com ([166.70.13.51]:58642) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oeIzJ-00CyVp-Qf; Fri, 30 Sep 2022 10:35:45 -0600 Received: from ip68-110-29-46.om.om.cox.net ([68.110.29.46]:47416 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oeIzI-00Et3R-Sr; Fri, 30 Sep 2022 10:35:45 -0600 From: "Eric W. Biederman" To: Kees Cook Cc: Lukas Bulwahn , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220929203903.9475-1-lukas.bulwahn@gmail.com> <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> <202209291638.BD0B8639@keescook> Date: Fri, 30 Sep 2022 11:35:38 -0500 In-Reply-To: <202209291638.BD0B8639@keescook> (Kees Cook's message of "Thu, 29 Sep 2022 16:39:19 -0700") Message-ID: <87wn9kzup1.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1oeIzI-00Et3R-Sr;;;mid=<87wn9kzup1.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.110.29.46;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX1+v1+HqCxxCIh/LfD/UrB7U7RKTyzEaoz0= X-SA-Exim-Connect-IP: 68.110.29.46 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664555747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHNVUgEuoxyWdL71jArruXWeZZBKafambfkGVNWmmFw=; b=RmKhRRWhp2EhsOwyeorxamtn2nGKaouxNdDxeZ272vpub52vg1hxlj/C0m7z2+N83PIrm5 QD5dawBZ2JMcIW6UBEWjXIiFtb5kMYa8iJMVMHCNJBopsIv4inoButp+67gnqq1KvnMm9m ZlCxPc5eQe9w9QkLAUMwSBEExwe7oLE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.233 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664555747; a=rsa-sha256; cv=none; b=tlkb/7wybTaEx1C8/zWB7OOfA81LOfyK2zV3+JJWPdm1jaz8woi8ohz/x/CJts63EddWAV ZgeZSqcMI/3dY5WnrjzJuePfX8J5JCG6GbdWVraOf2nEtIyzhuwvc/wB+oISDVHbjOVVzG 50kGimS2Vwj+daZL381LJ91Lz3ow0CA= X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5D0BC18001D Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.233 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com X-Stat-Signature: qjetzneij11is46m6mxryykfky7yu364 X-HE-Tag: 1664555747-676049 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kees Cook writes: > On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote: >> Lukas Bulwahn writes: >> >> > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the >> > use of the special taso flag for alpha architectures in the linux_binprm >> > struct is gone. >> > >> > Remove the definition of taso in the linux_binprm struct. >> > >> > No functional change. >> >> Reviewed-by: "Eric W. Biederman" >> >> Alphas binfmt_loader is the only use I can find of that variable >> so let's kill it as well. > > Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the > only place it was accessed. Agreed. :) Yes. I was looking in a tree without my previous change merged. The code in binfmt_loader (which is removed in the my change) was the only user of that variable I could find. Eric