From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A20C43217 for ; Thu, 24 Nov 2022 05:28:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27DAF6B0071; Thu, 24 Nov 2022 00:28:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 22F0A6B0072; Thu, 24 Nov 2022 00:28:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11FFB6B0074; Thu, 24 Nov 2022 00:28:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F26E76B0071 for ; Thu, 24 Nov 2022 00:28:58 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C4C56AB818 for ; Thu, 24 Nov 2022 05:28:58 +0000 (UTC) X-FDA: 80167206756.10.FD333F6 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf28.hostedemail.com (Postfix) with ESMTP id 36543C000C for ; Thu, 24 Nov 2022 05:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669267737; x=1700803737; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=yzllx2aXHanc4RlM697MHQ9doyide2+HpLsBlPh6fPY=; b=fCn+5gZjZrIQ0icyFao54eeif3EJBAMMQ7bMT7gzQTFwFVL2wQbUDli9 aqX9OZqvb2jUt3xZ1EkpRFzLayUMwB8ajL/m3DTaZ1ZQe3VGSsnm3c39C MY9nuYVnJQPUGDRWnbYSCo9WVnr7Ff2DuCvRG0qHRBtpv8V4GdnnJEjRT VRNHUlSAq5HePEXQbQk965aWP04ag2K4iqVxeJrFidcrRK5NA6mPDPHFB uet4CweG1TbENlxGNIze2hY8cCNfEV8bmm7k+yb16UdC9O7oGLF2Zbru/ pFSzTAolX7vFt36RgTGr8XNpWtvpi+PnWD97SggPHSKScrnM9TlCLgOvD w==; X-IronPort-AV: E=McAfee;i="6500,9779,10540"; a="312919662" X-IronPort-AV: E=Sophos;i="5.96,189,1665471600"; d="scan'208";a="312919662" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 21:28:55 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10540"; a="887219634" X-IronPort-AV: E=Sophos;i="5.96,189,1665471600"; d="scan'208";a="887219634" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 21:28:52 -0800 From: "Huang, Ying" To: Mina Almasry Cc: Yang Shi , Yosry Ahmed , Tim Chen , weixugc@google.com, shakeelb@google.com, gthelen@google.com, fvdl@google.com, Andrew Morton , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v1 3/4] mm: Fix demotion-only scanning anon pages References: <20221122203850.2765015-1-almasrymina@google.com> <20221122203850.2765015-3-almasrymina@google.com> Date: Thu, 24 Nov 2022 13:27:51 +0800 In-Reply-To: <20221122203850.2765015-3-almasrymina@google.com> (Mina Almasry's message of "Tue, 22 Nov 2022 12:38:47 -0800") Message-ID: <87wn7korag.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=fCn+5gZj; spf=pass (imf28.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669267737; a=rsa-sha256; cv=none; b=n3pSkAaxrgkbH5+d9J9H0xEZ1bg4BbBNBULoupBmTjRvJNFi/C6lsX94NAkjcjrS6rW5BI Ykltxvpp9ij42eLm7yBniH/+9CH9+lP+KBT/S+gh0SbcRwjwXftVW8t/1UzClikrZyTd5M KxAkTAfv/F3/K177yl1cRsNRvGr+xWc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669267737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jfcAI8GZQfOLkf1jQp712Ps4kNiFpYaclysOsqkl0Hc=; b=SJKVVfbzAbsd9ef3SkaGDsOidSAyEaRrqmYCBkWc4iqK9Rj+M372v8KQoy6GUwG0lgqn6w lu0VioIbwRXenq4uV34cRbx3au8qvs3fFwJgi8l5aF6wS5YNYmI3Zq1q8xGVCfpFGKpGZG aLUVA0ACVTDLwfmIRUaVFd/m5vEm7bY= X-Stat-Signature: fp7i4ds1oamjbsqwdiwasp7u6z5k8p4d X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 36543C000C Authentication-Results: imf28.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=fCn+5gZj; spf=pass (imf28.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-HE-Tag: 1669267736-769277 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mina Almasry writes: > This is likely a missed change from commit a2a36488a61c ("mm/vmscan: Consider > anonymous pages without swap"). Current logic is if !may_swap _or_ > !can_reclaim_anon_pages() then we don't scan anon memory. > > This should be an 'and'. We would like to scan anon memory if we may swap > or if we can_reclaim_anon_pages(). > > Fixes: commit a2a36488a61c ("mm/vmscan: Consider anonymous pages without swap") > > Signed-off-by: Mina Almasry > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 8c1f5416d789..d7e509b3f07f 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2931,7 +2931,7 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, > enum lru_list lru; > > /* If we have no swap space, do not bother scanning anon folios. */ > - if (!sc->may_swap || !can_reclaim_anon_pages(memcg, pgdat->node_id, sc)) { > + if (!sc->may_swap && !can_reclaim_anon_pages(memcg, pgdat->node_id, sc)) { If there is only DRAM but swap device is enabled, sc->may_swap will not work as expected. So we should check can_demote() instead if sc->may_swap. Best Regards, Huang, Ying > scan_balance = SCAN_FILE; > goto out; > } > -- > 2.38.1.584.g0f3c55d4c2-goog