From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A694C32793 for ; Wed, 18 Jan 2023 12:59:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFF3F6B0071; Wed, 18 Jan 2023 07:59:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C88636B0072; Wed, 18 Jan 2023 07:59:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B01C96B007D; Wed, 18 Jan 2023 07:59:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9D46C6B0071 for ; Wed, 18 Jan 2023 07:59:50 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6C1E64096C for ; Wed, 18 Jan 2023 12:59:50 +0000 (UTC) X-FDA: 80367926940.04.195490D Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 7632C8000E for ; Wed, 18 Jan 2023 12:59:44 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="PgZLyda/"; dkim=pass header.d=linutronix.de header.s=2020e header.b=twkPO4xq; spf=pass (imf30.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674046784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ia5mcSSMCX645DNR37kXbpCtB0DOcgHMBUz20RFHfC4=; b=3IGBKXzhmJIg+sd96zgr2AN5CS1ale1z2Z+GBD3DGg4oRsiu8Sdu2+j2MwIL5TJ6ltYfh8 YckdbLJLKhutO3pUa0k3eyHNWByOytAG5BMMxSWwhHwQOMCxL9UOsSpUUVPG/QYGxhq+SI 9T3YX9v2oQgY1jCw8m1sIS4QdrK5oN8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b="PgZLyda/"; dkim=pass header.d=linutronix.de header.s=2020e header.b=twkPO4xq; spf=pass (imf30.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674046784; a=rsa-sha256; cv=none; b=hvYY7bVxwIH7rLoTTdKWxwNCYxxI9j9ajFyEicEBft2c8YMeL6//AHrO+oC6x5EJLSxAhR BetQgbJ8eBJCuMU2b+hbmvkoe/rv9gUD5UZTZf/6obsyK1oKeiJOB5SkR0hXY9yrRIq6+o D0m6KGjALBMdisomggO4dAAEHMVncqU= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1674046774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ia5mcSSMCX645DNR37kXbpCtB0DOcgHMBUz20RFHfC4=; b=PgZLyda/qk+zlwhzR6idZiNhlWjQ9dhxCmeT4rrrl2GneTevgb/CsxE+hZPT77/XxN/D3C OdouussxQq3+fqW0hIcz/Ki25tMkMCvzzYDB8pBZcMQlLCpDT5VZb1pVYMSDA/j2hwWryO XALXhf/W98qKDyrndcj1X2VDtSU3suaEkQMvFPFJNRpd3rP5YqRNavHx/iRYRfI3oGDLj7 Fyk2vEI66UfwY0KA5lZAxmspc7UiU9mKVU0asexmqh+7rGYFxRvu36Ar6cF1VNhzA334Kh j+N92wF2QwyoojycoKuUH4XjJ9yjXMXivJ1ePjsam5T0B2hbJpAWejPbykJQrw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1674046774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ia5mcSSMCX645DNR37kXbpCtB0DOcgHMBUz20RFHfC4=; b=twkPO4xqcEqK9BdeHGZeT7P1XO2VXaNzoSGOiyD8GCiyvcCMbRNK/TsG05ivxP6PlVlbsI bMflMGBUtRJ91XBw== To: Byungchul Park , linux-kernel@vger.kernel.org Cc: torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, paolo.valente@linaro.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com Subject: Re: [PATCH RFC v7 07/23] dept: Apply sdt_might_sleep_strong() to wait_for_completion()/complete() In-Reply-To: <1673235231-30302-8-git-send-email-byungchul.park@lge.com> References: <1673235231-30302-1-git-send-email-byungchul.park@lge.com> <1673235231-30302-8-git-send-email-byungchul.park@lge.com> Date: Wed, 18 Jan 2023 13:59:34 +0100 Message-ID: <87wn5khubt.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7632C8000E X-Stat-Signature: qmhn9xkutk3tjziektwn4uogm11s9f4c X-Rspam-User: X-HE-Tag: 1674046784-871000 X-HE-Meta: U2FsdGVkX18643XyaT1GzHE0SaB20y8RMIWH3Mc00+OiwN1wz2Sxc+R9RmLUYN2K6/CCPFQHHNO7oiwOxENhd/Cf62DIGiJdi1yoSry35aemfq78Xrh+ta7WWVT0QohdcopAnmNYTHEbox7pjsevatPfRa15SnMRpzvaCTsOG9mOkZqFDb8oJN+jrN+j6vKKT3JHBr7bz7FBNrtSgGtAO6H546SUmcZ7UTCm31UmPKbSaMEH1s5B6Db5Pq7hLBz/tR22CNs//INcWrGXk/iNo8Z41rOxJdluY6rAso87XvR1rZ1PluhiZy7HNog1ds06uJK5E8ruoKNtGeMifo6xxGB3K7pr4ypdgbzvDcjFEjxggn7VovbaXDjUKB/BPOTa368HSvSXm1IJlAoYOJ/swzMJehFBaPz2ZzU+oxV0cQThM9DoEF0uLvciHMIcyuPvp3EuQD/2bpprtpaMmaKQtk8tg0dFAjTpulQlZDtLRy58sxUSa+xpl1nj7iv7S5hQAvbqCb8sjPfXhnYnIw8D2pYOix47OjWstrD69qO31175w7B2TOS0RarzBpyEk8fZboxP6/gb2o7QNXXfLgZgh28MpWMRMFNkb3kYtxmLlPfxwZNNnvPcvrQCTSAE1m/6M4j+g1pqZPCAtR45Drj3u8RUWtrXG2HRekG5tKi+ffQMhF9T0ugA6L+WHxtDTIOemTlDXUJ0GOyHeaDvQE1vZBd3O+8UX8BHWDv3ehqlbr7D32AR7vnTV0sIPccBwFSM4LQ0IfhuvLbBCl1Dbg18V4G/blZ4kGiQ2CVLbh1uAxRvSxepQBgKMqe7m3TST7cJCsVZQGaD8M2Dbk27jULw1VYdsWkgD3UygNTw2DYRtqINulmkvdvyPgGPyrwktn0DfhkTtguDWGs5TOLSPfb+gqshpIU3DeOdBo/t2AmMlnAFRr2JgIHmxJsIzGvFLjcR24eVoLmzyDs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 09 2023 at 12:33, Byungchul Park wrote: > Makes Dept able to track dependencies by > wait_for_completion()/complete(). > > In order to obtain the meaningful caller points, replace all the > wait_for_completion*() declarations with macros in the header. That's just wrong. > -extern void wait_for_completion(struct completion *); > +extern void raw_wait_for_completion(struct completion *); > +#define wait_for_completion(x) \ > +({ \ > + sdt_might_sleep_strong(NULL); \ > + raw_wait_for_completion(x); \ > + sdt_might_sleep_finish(); \ > +}) The very same can be achieved with a proper annotation which does not enforce THIS_IP but allows to use __builtin_return_address($N). That's what everything else uses too. Thanks, tglx