From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E67B0C61DA3 for ; Wed, 22 Feb 2023 01:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C0526B0075; Tue, 21 Feb 2023 20:03:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 670576B0078; Tue, 21 Feb 2023 20:03:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 539226B007B; Tue, 21 Feb 2023 20:03:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 433EF6B0075 for ; Tue, 21 Feb 2023 20:03:55 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1735DA0758 for ; Wed, 22 Feb 2023 01:03:54 +0000 (UTC) X-FDA: 80493130830.02.2F5EE87 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf03.hostedemail.com (Postfix) with ESMTP id BFB532000B for ; Wed, 22 Feb 2023 01:03:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ngnHYIUG; spf=pass (imf03.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677027833; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eynMycAKmkrlOOZDBGt7a2Wc5l4o2RwSOU15lLVmgYE=; b=ehxbQhbsmayaVCj8XdBAu5h2s9XkyA1s9kzDcYZrT/2QmFk2d4LlIMiROz+jKmrOPsZQzm S2QZI7TEJgWZxXbIYac7yYfIh35o7JW/tmenLsJ+5rmfgHne3y+T1/wKfVYOQ4S2W6KpfC yCAitgrWFZm9DuhKaOJmnyD5EoDxj5w= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ngnHYIUG; spf=pass (imf03.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677027833; a=rsa-sha256; cv=none; b=kOLAk7fRIfUBZ+2Oa4VJjH8vrkqoczhAX0V/Io5lsA68s5WDR1k8ruqWtl4ZI8491V0RIV SoVa2yzrv8MBNELqfknLH4m9ZHlqGomm+an7tZ9Bd3ue2jIYb+Vms1Q28ob7AuV1gZByNp vNISmLO56GOxzGp9CRE10HQFwv3T4cA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677027832; x=1708563832; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=LOZAvauTBVXSHkNwf9NULS0f0XiM5osi+19XTZiW0Jg=; b=ngnHYIUGAF+9JJDM3N+lXrNHvMXuJUHQRNmLvf4vf7JW6Tuz1O2bwEwn hvr/y/PnRPu7G4Aqs7/Oq0bIVSV20Syfsb5RTD2FJI4mGtVjjbPEtSUPx ha33PIrpErb3xFgzCJR7magsC/G9SsGC8kW9f7EvrQKQv7L97ePet7S9Y HWXXqWhRQwBHKvtmmfybTeyWDbkHnhfbE02LWxfnafYHW7WrqNDB70lTh 9bXjjGPBhTnu5Uq24zTpHAdrRZRZDSdai0cSYv3rFX3PNwVVPAoY6dZRB yLPvCSJuVveaXNpQkLH4PoMEtT/KQj3LyNGXCF+vCpeOgVhOvkJmvKIoM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="332803711" X-IronPort-AV: E=Sophos;i="5.97,317,1669104000"; d="scan'208";a="332803711" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 17:03:50 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="704271120" X-IronPort-AV: E=Sophos;i="5.97,317,1669104000"; d="scan'208";a="704271120" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 17:03:44 -0800 From: "Huang, Ying" To: Hugh Dickins Cc: Andrew Morton , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador , Matthew Wilcox , Bharata B Rao , Alistair Popple , Xin Hao , Minchan Kim , Mike Kravetz , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Xu, Pengfei" , Christoph Hellwig , Stefan Roesch , Tejun Heo Subject: Re: [PATCH -v5 0/9] migrate_pages(): batch TLB flushing References: <20230213123444.155149-1-ying.huang@intel.com> <87a6c8c-c5c1-67dc-1e32-eb30831d6e3d@google.com> <874jrg7kke.fsf@yhuang6-desk2.ccr.corp.intel.com> <2ab4b33e-f570-a6ff-6315-7d5a4614a7bd@google.com> <871qmjdsj0.fsf@yhuang6-desk2.ccr.corp.intel.com> <20f1628e-96a7-3a5d-fef5-dae31f8eb196@google.com> Date: Wed, 22 Feb 2023 09:02:41 +0800 In-Reply-To: <20f1628e-96a7-3a5d-fef5-dae31f8eb196@google.com> (Hugh Dickins's message of "Tue, 21 Feb 2023 14:25:41 -0800 (PST)") Message-ID: <87wn4acy1a.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: pm4kbqk8who1skyn4f63i94yzen4thwj X-Rspamd-Queue-Id: BFB532000B X-HE-Tag: 1677027832-626308 X-HE-Meta: U2FsdGVkX1+y0hSk/KPlijSR/eYPWFA8kE6FoH1AkIfqMXXPWfXGVUCuMxkVtryYhBm05PkEb4/VfDdxLkoBZ/kwMiGXmW+VxNLLnEb8AbB1w8tQwn2n/5kBx1kdy6s5oMPO7ArtYe05BfXVpDZKskA+dm+C37vo7NT8bjlduCn+TA/hC1Wq9P6i5NbF/vzq5P/4CnrCmwCTlaglAaNgL4ljoCW5HQNR7uuJBdMRhzxWo0cNlw2lDB/t1xEdS/GvPz8U6pySPiEQclltHQsuY2BncruVUOTRXJC2vkXyF7oa8aCfIxWGSwLi+5937EwBvt88BPFKcsSGgpXt/5ANLzrHGjjpNA6xk5oZcL4genE+TOQYAtr1NmcPEibQN0tjD27Km+WDzhVhEc2Xn9ytMVHibvLah8K//l3Mwb5IuSlxoIo0Qa3tqFIj87HdLBMSeLe9ML0v0VBWq1XkerXiqAu8YKtUKK1qc9pVwaww4VLb2L6RLJsQFc00aJ88puJgoKTGe/uv+qq/kOHVEUnbx7qa1u/lFD9QDLuYgN/5SzGFNkDI5W+k+fdZ7sZRzwB8u1+rgAJgepiaPA1dlczBzZfmSDbp1W77iN1ygyBk9pmdE+MUmjij1AkHWq1YNkqlv3euWNZaR7WO3M6W9Cfeps79/UNvPqo6bYaKTxtQkZGtpTf40aB9WfQtKjSLmqyyysUpGUVduVZLFOzB8xRjyCjCEYHAevPWeeB1EDx6gcJcOLxjNLRNuAtPdvrhruhkA227BBrpuiLZ7oSMdy8EWBV9f58KgPbgL+e6kHc/BV/8jC6pViz8Ek+bNyJLTgh0dujm61qNtAORv/z4GV+8/AlWwWW+ztO2cdCzobwMbkpwduWjYec0sYCfbcFwPQDQVU+MIWFmj7rxp04R+yw+j4/KvFhHVdxz9HcCnZyrmOlehEajOZmbxdCda3b0ZiVr3LCqb12h1gqZE+f6dCI 5XV4Uabw 5kK1zVZJphEbHWBkjOmPlNGrvIVhVTNlwM6pP/GRIze6vghby8ZR8wucnx5haLvdur98v7QH/vz5Oam/68dDVAfVL4XVMqf0oqac8CA25wseB0ps1PQ+4+NCyy0+T5N39J7fTKPPxJz6sI8duUrgKtbd1SDuLh8zdDSLfDCYe5d7YCMF14kHPpoGlL2Krzis0kbLeeYxJCAoUBu9EpJz0x1H0T8g3ozTHUKyYIHpIAaxiJ1bLP756rikYTdnE0dk7LQJjAdjySF8GjRGHpHt/JlsTitBIFuxJwUgB7PgpmsW5zOVarkblX+/7Hg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hugh Dickins writes: > On Tue, 21 Feb 2023, Huang, Ying wrote: >> >> On second thought, I think that it may be better to provide a fix as >> simple as possible firstly. Then we can work on a more complex fix as >> we discussed above. The simple fix is easy to review now. And, we will >> have more time to test and review the complex fix. >> >> In the following fix, I disabled the migration batching except for the >> MIGRATE_ASYNC mode, or the split folios of a THP folio. After that, I >> will work on the complex fix to enable migration batching for all modes. >> >> What do you think about that? > > I don't think there's a need to rush in the wrong fix so quickly. > Your series was in (though sometimes out of) linux-next for some > while, without causing any widespread problems. Andrew did send > it to Linus yesterday, I expect he'll be pushing it out later today > or tomorrow, but I don't think it's going to cause big problems. > Aiming for a fix in -rc2 would be good. Sure, I will target to fix in -rc2. Thanks for suggestion! > Why would it be complex? Now, I think the big picture could be, if (MIGRATE_ASYNC) { migrate_pages_batch(from,); } else { migrate_pages_batch(from,, MIGRATE_ASYNC,); list_for_each_entry_safe (folio,, from) { migrate_pages_batch(one_folio, , MIGRATE_SYNC,); } } That is, for synchronous migration, try asynchronous batched migration firstly, then fall back to synchronous migration one by one. This will make the retry logic easier to be understood. This needs some code change. Anyway, I will try to do that and show the code. Best Regards, Huang, Ying