From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA5C5C77B7C for ; Mon, 8 May 2023 02:27:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6A6B6B0078; Sun, 7 May 2023 22:27:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF3D56B007D; Sun, 7 May 2023 22:27:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C94366B007E; Sun, 7 May 2023 22:27:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B6F116B0078 for ; Sun, 7 May 2023 22:27:26 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8473EC0786 for ; Mon, 8 May 2023 02:27:26 +0000 (UTC) X-FDA: 80765501292.17.BBD2287 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf14.hostedemail.com (Postfix) with ESMTP id EA3E7100006 for ; Mon, 8 May 2023 02:27:23 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nIF7pexJ; spf=pass (imf14.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683512844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Z+cfKJS4H8zig8MLC5cdW+pN0XNFjWMiaO3nFVYa/Y=; b=SBwpgeSVA/061mWHYqgxGs9AheT+Srpl3MMoBqtYqri0bYZO0VqjHHTkFy7Ycx3rJhE1U3 oOU0+EL+5iQiwN2fwyItMtJk+HejnDPDnTSMIAbliGj2SCn/WHIjzMqP9w5lTUVq12Ko/6 ErVr1UL9552u19ehxYFLMnQ572vJocU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nIF7pexJ; spf=pass (imf14.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683512844; a=rsa-sha256; cv=none; b=S+IARneuZR8izFGO5/OmwIa+wJ7UDA8TEQiB6ECkmYYLE/j507kuCjShcB6aNzX8oMOp0l Of9d7NNsdhL14R5I4DzqzeDsozSj7UJlr7znYcU9YP1K886X2oI1z0yymYbZTYKQ898wLU iYtBf7AsYiYu2U0e4A/T+E6y18sGe9Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683512844; x=1715048844; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=zKRd4CcYhxWuZ8dosZrKjFL/E+GzhFM8aaQzoYaruc4=; b=nIF7pexJk2h42wBIwSJBJi79DF3ZBwBp8GmIAP3UnQXzfNMuYpCp4yFB mk5sKg75hVyGizrUcLTGrr90JzteHnJVijvfUiOdzAO0U+UGiAviBu/UT PQeMTbIH1LiCSxmoUZdI3rIYskGwAxuOHWZXr2Qt/Scc06bFuXmUAtAXQ O6rM7mT9+0L+c4IxVk1YYmIwUS8QZuiEXhZc0aFfVGnVD0/TGZLJSvijA ZlCsBtGoz2DuYt+HIMtHg0EjOASTv2TQQQmCCdwEOCleOueAxRbYK5npc wG0WV5hDfLD5Qyfl3udTaTJJNFdz1kzed7zoBdb9edvPNZcu47taBiOzV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10703"; a="348365122" X-IronPort-AV: E=Sophos;i="5.99,258,1677571200"; d="scan'208";a="348365122" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2023 19:27:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10703"; a="787932513" X-IronPort-AV: E=Sophos;i="5.99,258,1677571200"; d="scan'208";a="787932513" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2023 19:27:19 -0700 From: "Huang, Ying" To: mpenttil@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, apopple@nvidia.com, jhubbard@nvidia.com, rcampbell@nvidia.com Subject: Re: [PATCH] mm/migrate_device: Try to handle swapcache pages. References: <20230507061726.13422-1-mpenttil@redhat.com> Date: Mon, 08 May 2023 10:26:16 +0800 In-Reply-To: <20230507061726.13422-1-mpenttil@redhat.com> (mpenttil@redhat.com's message of "Sun, 7 May 2023 09:17:26 +0300") Message-ID: <87wn1ja793.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 5qfqsfdtekypyiqnja41k3km5z1ts6ew X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EA3E7100006 X-Rspam-User: X-HE-Tag: 1683512843-526912 X-HE-Meta: U2FsdGVkX18LBTeTyAJEPibgMfdNFLF7o3D8ugNSKWoxl5NLGdMNgMfcsXK8JO2Y8KHGCVWNnfLl4QKOvVaqvLWHm/2zQZVn9V+8gB65MZ6KYSCMtwyljXmb1qvddYp0RceSitlYZoJjKW2ZdK3NK2BqoCN9fdkqL2IJeexb2EbrtP8HW8RMBu8GN8uDtFymUo+DIvCIjBLMriEcphomCemRl+L6vDnCAm5NyxkT4WqMnyDOLQg2jzsQStOqU4xI6vCqzwvTq7+Bhy2rZvwp8/akFqQueKk1Icd06lvFYdpdzUYVhKGanSoHFl/7WfRS/qQr+CpNeM/2S5o+zrEDQiooUNM2veR0xpAk4ZP4Ii4t0y4bdg6Fo0U2qOAa1tHCB62BFRDqcLOI6ZDIS+TNAt2zqOFgfma3a5XyvRiVeQ+plx2IMknb6JSiYevrDJgk6NWgZymllo79hsXML4AbFA95aCRjM93b3XVgEIbhor30KodeZ4FY58Q5TKUrIkDOWcg+tA1RQZ5OqQ2WEI0MvbKIqm2ZLf2OOsvDELTCY7tcSu5np10GssUK9+zUqmVZQQ04/N/5W7itQH4Sro1iy7U6pIm09bp+qbS+tvIPmO+wQdwftMht1dnG7CBlv008YNAhJbzZgb3SYE1Dg/3OpTPq87dOn8baRP/WTzEBRI9enGJP9BVZzAgyE/Wuo38SXuVOZ094sqveMXQRxaVOugdPgAFVb4seXX8ckGZFPz4/LlD2Mj2Ndk7h+BC1UUEWv41nK8t8yB9XI7Hozs1iQtLp2VpunsxZFkVdC+NDz7aN9gYUcdsfru5ewxBh75Uq0yEwScOOPqWG+VZ2Q7jQeQNQME246GIviBNy8Fxtvv9Jh4wB1tnx+FS7XwjMAmpr4eGy3uGtqGD6URV7oOIiAM92d0B89blW13gd82Amo20O9UqN7bXmR3zxhytGxOJx6I7GQxKoPalOpOiEbFe wfkLSgmn RCdpAeBfN1G+jZxmR2/HAwmiwa4Coy80BfMUsOZjqLQN4d6hw1fODln/ockXso/qwnvQ9FUKizaYiBSTLmHE1S67/mEoxLHZ6B/Z2+g0/KrNeS0MayMZtokjjjAJimBtCvpQBtCfiZhXTOIBxYmimf9FpEQczyHJTKaIAFhMEoRC0zh1i6AvMWLwxUNXeTT+YRPGV0e37SsWyV3Vp0bXd7AjG3aOjj9iXeD6FOLSj/aSjOm9ZPb7ZaHDsXfzeE1iuW55Qo1HJbRO0DOU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: mpenttil@redhat.com writes: > From: Mika Penttil=C3=A4 > > Migrating file pages and swapcache pages into device memory is not suppor= ted. > The decision is done based on page_mapping(). For now, swapcache pages ar= e not migrated. > > Things can however be improved, for swapcache pages. Try to get rid of th= e swap cache, > and if successful, go ahead as with other anonymous pages. > > As a detail, do not mess with shmem pages, as they handle swap internally. > > Cc: Alistair Popple > Cc: John Hubbard > Cc: Ralph Campbell > Signed-off-by: Mika Penttil=C3=A4 > --- > mm/migrate_device.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index d30c9de60b0d..e8169c58c341 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -750,10 +751,17 @@ static void __migrate_device_pages(unsigned long *s= rc_pfns, > /* > * For now only support anonymous memory migrating to > * device private or coherent memory. > + * > + * Try to get rid of swap cache if possible. > + * Leave shmem pages alone, they handle swap internally > + * > */ > if (mapping) { > - src_pfns[i] &=3D ~MIGRATE_PFN_MIGRATE; > - continue; > + if (shmem_mapping(mapping) || > + !folio_free_swap(page_folio(page))) { Should we filter out file pages firstly? > + src_pfns[i] &=3D ~MIGRATE_PFN_MIGRATE; > + continue; > + } > } > } else if (is_zone_device_page(newpage)) { > /* Best Regards, Huang, Ying