From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B074BC77B7F for ; Fri, 19 May 2023 13:49:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04D1F900004; Fri, 19 May 2023 09:49:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3E3B900003; Fri, 19 May 2023 09:49:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5448900004; Fri, 19 May 2023 09:49:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D7B2E900003 for ; Fri, 19 May 2023 09:49:40 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 81C0C1A0A6C for ; Fri, 19 May 2023 13:49:40 +0000 (UTC) X-FDA: 80807137320.06.57188F4 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf12.hostedemail.com (Postfix) with ESMTP id 923B840011 for ; Fri, 19 May 2023 13:49:38 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=RLTvUPb+; dkim=pass header.d=linutronix.de header.s=2020e header.b=3GGH4vCF; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf12.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684504178; a=rsa-sha256; cv=none; b=6AOTA8xBFvCO7NUk5F5eNCqtwYgtwaREJSi9tlJvZnnpCeBb6Nxn+2XgZKVpVXAMknNbiO JmhwXLKZqb2EagZLkpJXjepHhPyz1d3inRGYA9CbnHQa4NTGk4QTUtn8hwZK9oViiCvLBp XdgqbILIjAlRDl7jaJYpxo8bSl38HCg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=RLTvUPb+; dkim=pass header.d=linutronix.de header.s=2020e header.b=3GGH4vCF; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf12.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684504178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7YB/wKT/1bpvMrLNerVNPlSTQb06G6thmKxqchw5MIs=; b=E4QrRqz51jQX8+7nXD6MvkJ/vLPQBsb9mNi8rc3vZWBvPqokc64p080JfetZyQhWhaUr7P +4+9Cz6H7UASN4NxK2BK6uvKUi+OP519Yawbp1HYSbYhLt1ec8Iddw0Mt5gy9Rz6rU061V j6Iaz9aKc16q5nrWnY7/xB0XPBH00gU= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684504175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7YB/wKT/1bpvMrLNerVNPlSTQb06G6thmKxqchw5MIs=; b=RLTvUPb+0WIGsMGKDHv5enz4fluw7kxP1wuSc+UBfCBgI73xKCuj9mm5xvYHhnBDUKdYjh aHqdLYN6PL0xdX2al9zlPfsPXTPhncLhECp+xsn+2P319xImnVgG8qLzHBq2OHByt4bIFj ynfwLhJfB3xyYlyAKmPCSILv8XG2FYjQw0r5kD2uBq8sC/hSUI0U0Cg4O9Kt6SZM6AyJfN xlRBfZnkzKNB1RDc3DI9JjTDOqe0T4H2yFPfPrCvWr3Z7xrRkdzl1WGV9C8e0487DR20Fh eUAlUFb3pUf2UfIB4/SmGUz2jRC2K8579T5m0OkHRXqo5HpOg/DnwEHkcwPg5g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684504175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7YB/wKT/1bpvMrLNerVNPlSTQb06G6thmKxqchw5MIs=; b=3GGH4vCFFYjxEq+NVk+8a8qjxhINNqwuu632bnXERmLiv6Ttmkh3BcM1FJZeo5ZpTx0IkS 5e5XnyUzQdSpimCg== To: "Russell King (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , Baoquan He , John Ogness , linux-arm-kernel@lists.infradead.org, Mark Rutland , Marc Zyngier , x86@kernel.org, Nadav Amit Subject: Re: Excessive TLB flush ranges In-Reply-To: <874joc8x7d.ffs@tglx> References: <87a5y5a6kj.ffs@tglx> <87353x9y3l.ffs@tglx> <87zg658fla.ffs@tglx> <87r0rg93z5.ffs@tglx> <87ilcs8zab.ffs@tglx> <87fs7w8z6y.ffs@tglx> <874joc8x7d.ffs@tglx> Date: Fri, 19 May 2023 15:49:35 +0200 Message-ID: <87wn144ej4.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 923B840011 X-Stat-Signature: seeqtijs7fne3j8tzqbh4i5n41t83t1m X-HE-Tag: 1684504178-429391 X-HE-Meta: U2FsdGVkX19jC1f1gWvfeai4uP2BPk9H6zV88v4PUOH0jm453xAG3lQWHomGlOkZC9TErwp81V9NXtMCc49RmoSGWDk59PuwXbo/jfalYG6ME9x+FtPvoRuYc7F9aYzbf/OuVuhmKn+5nxFTsAJXKBMlLo20YQgGeFXfNQt7851fd75/ocm5esg9txsEuxrmtCjP4RqH0Z1faq0+iRCYmvbDopUtnaKyqThZ4b/+mbVcm9pHaJp/xxhh7sopXepH8fSYzWiMzedNoUn6/3MluUOZoQfSUlS9fTmJGZ0iDAy/X41rBJOWwGymRERJMVKIgBouesrlRwHoInmOvaWzObLur54e5FosgY5U0vw216yuphHm1p3YcImW6GAp9GFNrcrXzqgjc5mmRci2T8jwRKgWKgGsaTMMPOZDfbkl1Nwx6OqD5kgZ710d4hFnRmxEH+ylLXz3iLPw7U61qpW60IXYO2lLL4yVR53FBHzBhXkopBW93dD4bNjgoh6juOEtkUPEuHhgnI3KbdoYt+mgLeJuvJZe3/OAhwFOqyh6JX7lm8piaGX186gnHLodc/VLeqVImlqOY21+GR/73uzU2BDCBLxgjliRIuXZH5U3DvsmvxrNGTJPL6YMXQA1ypGFHEqQBk1vdUIAOCq1qb5wGcdPTqLHbvezzESb0SSi6aXCC2G1DO0wzxCxffRz7Omt+mLJ4kK225D9Q4SJDyo3fGuP/RTqI5uDEwvZytoQ7kLBV8UT/VOrdffyp0xJv5jba9QO/8RI0vtjWxeHgzHTkwjSBbUuqxoOsSOJAS8jp8k8TkeuYlnln7if6OV6Bm/OgKyjt+wuJqs4g+J+4TbHF8no+SfrP/pb3QlvRB1EPTzutCoHjfHulrdGAZ2jNTT49miDCsJo48Gm8KI37X6HIcC1Wh37dnOyj+iLSoMwFyElHbvNSFxh81wc97eeMmu5e6o40pR1Y46mzTanjDl 4+xH7p10 kdUpwIxUbpvTmIWwblF8hLvROfI9SKR9ay0FTowih14odc8CEc5PC0qkkd51YQpGa4Hf5Qy+sGZAEtnk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16 2023 at 11:03, Thomas Gleixner wrote: > On Tue, May 16 2023 at 09:27, Russell King wrote: >> implementation, there is flush_tlb_kernel_page() though, which I >> think is what you're referring to above. On ARM32, that will issue >> one IPI each time it's called, and possibly another IPI for the >> Cortex-A15 erratum. >> >> Given that, flush_tlb_kernel_range() is still going to be more >> efficient on ARM32 when tlb_ops_need_broadcast() is true than doing >> it page by page. > > Something like the untested below? The list based individual flush wins over a tlb_flush_all() in that particular scenario. It's almost in the noise while the TLB flush all has an impact of ~1% on the other CPUs computation runtime. That's just a quick check w/o deeper analysis, but that clearly shows that there is potential. Whether the list or as Nadav suggested some other storage turns out to be also benefitial for IPI based flushing is still subject to investigation. Thanks, tglx