From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA5C5C77B73 for ; Wed, 31 May 2023 07:25:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 486FD280002; Wed, 31 May 2023 03:25:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43833280001; Wed, 31 May 2023 03:25:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32760280002; Wed, 31 May 2023 03:25:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 22DE8280001 for ; Wed, 31 May 2023 03:25:47 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DA7B9120242 for ; Wed, 31 May 2023 07:25:46 +0000 (UTC) X-FDA: 80849715492.19.1F18EFF Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf02.hostedemail.com (Postfix) with ESMTP id D778A80015 for ; Wed, 31 May 2023 07:25:43 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TZnDXRWX; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685517944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CtzCcv9ATtaVjVIDh8Ih/ZQHM4Ew7oD9osFrquw77Co=; b=nRxlCxyGGoXfNjRRgJhsyBVEa6jkk5NyOELg4T4rBIpDFp9NOSiIuJRK1PALdWaPkU1MD3 DGQGt3DdNaNDr9ZIxM8NIFPRcXszwatAnHKvzZAmTfFp8AHk2FA5XQn03Ek7Zie9xY85lT CWU0KgOhjROTJb+YXxdowAkeWbHhOGY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=TZnDXRWX; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685517944; a=rsa-sha256; cv=none; b=0vtDpEH0a6ZvneFRXzUjT3aUYkG+tJZMh2ukiWKYm76pwNtxfXAAQVyNA+piguZTU9h5du WdEVSu4Xg+bpGMZfsO9O4R32ucHRJE+io4+PPg/ojhqV9+Iv/3cSMv2vnay+JP/Wz3YGJl sSe9F6IbuFsnzRLcz501NfREJmZk2as= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685517944; x=1717053944; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=NJMHNWlGqt9fFaT1Uo3VmPdw4bNAlscWO8HebrvoySo=; b=TZnDXRWXYFRqfB6Sx+fjfX0R8WmAQ0CFv3sCh12qzYLIM0Q/rDye1gFo 8mq9ZatuaD0sUkCkXej1xLqielcYsAyDszR5GTMYNuRpEE4APcnN3CX13 LZfzQPaBLic3yaIJujmTzO/asThnt2e8JT4mGGwE6ap/8R7N8+t62xH/E PTVkiBki1iREw5oaYBS2A28J82Eoqy3sYcKzlRDnkaFUfVExIkai/kxLA qLg5tGUK9Wkq4s+KVw5XTb3Vj4DnctS/UdZ/qDZKB293OfVbKoWm9WmWm YNTOWr/l5MaO9aWPRW0lJIHZ7UrqmEe/RsiQumwsbuXMatg1Wqnwl7i+G Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="358423762" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="358423762" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2023 00:25:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="851107618" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="851107618" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2023 00:25:40 -0700 From: "Huang, Ying" To: mpenttil@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alistair Popple , John Hubbard , Ralph Campbell Subject: Re: [PATCH v2] mm/migrate_device: Try to handle swapcache pages References: <20230531044018.17893-1-mpenttil@redhat.com> Date: Wed, 31 May 2023 15:24:32 +0800 In-Reply-To: <20230531044018.17893-1-mpenttil@redhat.com> (mpenttil@redhat.com's message of "Wed, 31 May 2023 07:40:18 +0300") Message-ID: <87wn0pt13j.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D778A80015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kzzoqus8t7a5ckn46kaod59o9wp5hk48 X-HE-Tag: 1685517943-590134 X-HE-Meta: U2FsdGVkX19yfK7US6k3s+CL8TNwwEZWIQ8xKcxR2cfSDcX3qGzRUUaEbZdmkGxWaqjHmxm/x+27O/9crzPEN+ncgazoclWtcCJBiMZ0ZrcDNI+fY7jCtFCLI2wsqfstUNpHCfKqk1Vn5RY1rCFPephgqfH1kidOfD2i+ZF5M/I6gZo83ZOptq+WfdL4pM9cILNCWH7Ozhbr2vdu2dXK7sidSzYJevnqdPC6lkq0PoY8VPDnawBhVd95sEUskkZdD+GjJK+J9BMV0iYfOdc7F6D+Uk4OCtF2NSP/j8ke3mk6GdU9HD8cCuF+YCnXQvSMT8OmeXMrQxzCJ+/vPuZMZ3Vsy+TKSh6LKlhqcdVcalWDe48svjOjQVqTZgnzsAF+mSO/je+wikSmo2DQGU+5mrb0M0Yeiv9Fapfqw/NNP6Ex33YAc1tab528kV4PMGrver81xawbdl7pE0WaZImOSpciqvbEu7vMDzbq0Fv/VANaqUfADqqv/vaumyV5+KIjJUuJCy8E00lmpXde9yGM4VbeaXe9+bZPM09RFGzmIYMpD99I9YYvTCfsXFUErw++WvKuh5amh3xm3wCRo5A2/hHzotL4pBCIPeATPFVA1rnAGpv2FOy263GtCncZmCXGM+8bF8i1/69c1x0tIxqAtf/GjUf+ASLMU1J+bTfwHwP3XhxEtd9SNpfE+jRwpxOEtNsy4ChmLyL9+2gNXhtoQlFvkOYQoDLooDYt4de6oDkApfx2zbH6qsXhjsqX4BzPq5EGJxXWWlgsnX5Nz7aO1KQyz/1pZsXV51ebd8rRUXiaphCam8nXtiVzpdZgz8QYNa6yMJsIxLSDJT96ux473CNFs+eWnhzn0z3Wh+Q16bq/HL4g0mpDcZKX1zuf0ucox0bUkpCFQmmtEZulxhPAlZo+mONtJZFxNvE/OA/MIwcwrIpmfG4wDMLF2XclfuxoFtmkqh5Pl3ZSqzZvm9R knjh75oc IzEXDfbAuxTPk8kuW/AfAKjnMhpZA5+Yrgd/zSKdy2zlGmS9w8tGID6RrWtbV+RWAB3ctQ3iEhKTWWWTNKxKYtHqeA96Nh80FPyY6oaqSqGH3CehJ64IV4otFtojip8vIPkFY/685ezDKXUf1+yU76L3P49/J5LqzTKA8vSI/gFZUVDcGFHyurRGDiYodDF2Ld/jEVe9W7fmaWQvX4fU0fg1TCM+yXJPjWGF3iNqtxM95HHN3InA/saCKaElSHa70Wf5mZdBWu0tBXP+5YZ28CdGdcw7F4lIj1Ov0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: mpenttil@redhat.com writes: > From: Mika Penttil=C3=A4 > > Migrating file pages and swapcache pages into device memory is not suppor= ted. > The decision is done based on page_mapping(). For now, swapcache pages ar= e not migrated. > > Things can however be improved, for swapcache pages. Try to get rid of th= e swap cache, > and if successful, go ahead as with other anonymous pages. > > Cc: Alistair Popple > Cc: John Hubbard > Cc: Ralph Campbell > Cc: Huang Ying > Signed-off-by: Mika Penttil=C3=A4 > --- > > v2: > - use folio_test_anon() (Huang, Ying) > >=20=20 > mm/migrate_device.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index d30c9de60b0d..829bbc526758 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -747,13 +747,25 @@ static void __migrate_device_pages(unsigned long *s= rc_pfns, >=20=20 > if (is_device_private_page(newpage) || > is_device_coherent_page(newpage)) { > - /* > - * For now only support anonymous memory migrating to > - * device private or coherent memory. > - */ > + > if (mapping) { > - src_pfns[i] &=3D ~MIGRATE_PFN_MIGRATE; > - continue; > + struct folio *folio; > + > + folio =3D page_folio(page); > + > + /* > + * For now only support anonymous memory migrating to > + * device private or coherent memory. > + * > + * Try to get rid of swap cache if possible. I think we can delete the following 2 lines of comments. They add nothing except what code says already. Otherwise looks good to me. Reviewed-by: "Huang, Ying" > + * page is here file or swapcache page, could be shmem also > + * folio_test_anon() filters out file and shmem > + * > + */ > + if (!folio_test_anon(folio) || !folio_free_swap(folio)) { > + src_pfns[i] &=3D ~MIGRATE_PFN_MIGRATE; > + continue; > + } > } > } else if (is_zone_device_page(newpage)) { > /*