From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0818FEB64DC for ; Wed, 28 Jun 2023 01:09:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E9848D0002; Tue, 27 Jun 2023 21:09:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 499648D0001; Tue, 27 Jun 2023 21:09:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3894E8D0002; Tue, 27 Jun 2023 21:09:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2C4378D0001 for ; Tue, 27 Jun 2023 21:09:45 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F102A1A0A1F for ; Wed, 28 Jun 2023 01:09:44 +0000 (UTC) X-FDA: 80950374288.16.E190039 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf30.hostedemail.com (Postfix) with ESMTP id 53AF48000F for ; Wed, 28 Jun 2023 01:09:43 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=qDYbBwy0; spf=pass (imf30.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687914583; a=rsa-sha256; cv=none; b=DX+AV6u9I4HoI4khvfesFW/RKBvJCLzZAEIU4AZeuKagWSQEsY3zCGmHPa2oLQc/luEZD+ pWnyZRvU+Edq6VTgHIDHw2QlE8zZ2Ipma8i5+S7cHeFKo1XjArZzCIs0AYwpjKs1IW2sIE 32LRL5jE1pVgPqRjb1IPe61DrKTk3QM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=qDYbBwy0; spf=pass (imf30.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687914583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to:references:dkim-signature; bh=HW7JQ71sbb4a92jnmvwt7wlFbdVggC9/cbLPydvRNIQ=; b=RErr9iLC/9dDh+KY8EGefNr2JFY84MZqyeVKXN3UJGxSDEkFPuFSObl0Zo7lmK/YjLw8mv ySRudWy9QW52Lpurd9+hCwvvPnSbc4ky2QvStbDy9Rqoiy9PPmXFaZ1p7qFzqHacFkW01k GD24ScYqBegBuHRlx2/2s9+Cc15lz/8= Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6b74e2d8c98so2368671a34.2 for ; Tue, 27 Jun 2023 18:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687914582; x=1690506582; h=in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=HW7JQ71sbb4a92jnmvwt7wlFbdVggC9/cbLPydvRNIQ=; b=qDYbBwy0bqF4ACWJIkeR+LMgEM9XDHsWbUTFPkx99XcTcQzhemPO7x79dfE0F++p5r 4KrZZnA2ltLyKxMG3HC9C6/w6ABjsdHLmLz9SUouRsSz6YUMQSD2O+v3Tf45urXIY6AN jDPSf16D86p4KcquPoY6O6I2QXzuF757ANFb3y/4qq1H7zGKvQM1ir3Vy5pohXuQxfIK zwv2lhbENECC9D42Ky0rHGwvY2OMHaWfLBtQL8If/hjiSbzF8HqsEyRep8EwpYaKAv8J mxiZGEDcD1usiE7Ccrym7T0MSzDPH3ub3/VIkziMkacUiHCZ+nrAxOpgsNs4IsVpnbba 4fuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687914582; x=1690506582; h=in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HW7JQ71sbb4a92jnmvwt7wlFbdVggC9/cbLPydvRNIQ=; b=U6829nVkfOqBJSj4trl7jfTqE4P7CkdYWwpTyN34Uxk64LsHVadrJ3Qk2Yz7ZrwEmZ MMBLi6As07de8oLqQqRnFQs46u3TkbT5JHRV42VBb1iM43rqgJsLdwoqlsj2a4xok4BJ qX4eBRkh/RUMTTyldJFhOtX6O3UC6P8HN2zdxqE0Jtm4SQTQMY1eibPhbQV0yQufYmeC 3lZy77No6XIQuV50ygFlL1+CpPcY/Du7xu7wVGEtna3Z//VYQCaL1bS5aB05/RqaYN1b avOK4aBaelnMkkAv+i3ipt66tiGOO5BCeDP5gVvCctFBXZdCwQQ2yN2yOXdLgazXWFBD BbSw== X-Gm-Message-State: AC+VfDzkLqrEXI+tsfQagFh/J/PQ6hFrfiDgPhxS1BG24XxqbUhu/JRG D8QseGqBz8DwrVN4JbJD0pE= X-Google-Smtp-Source: ACHHUZ5JII6/UO5PrtGdL6Wo8WDeps9s3NRIovdwZCw+zmQQJErkrtuoJhL2Y/gJCcR8ycGuB8B4dg== X-Received: by 2002:aca:1c19:0:b0:3a2:f93e:d4ed with SMTP id c25-20020aca1c19000000b003a2f93ed4edmr2941640oic.33.1687914582286; Tue, 27 Jun 2023 18:09:42 -0700 (PDT) Received: from dw-tp ([49.207.220.159]) by smtp.gmail.com with ESMTPSA id i20-20020aa787d4000000b00679325476dfsm3511018pfo.91.2023.06.27.18.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 18:09:41 -0700 (PDT) Date: Wed, 28 Jun 2023 06:39:30 +0530 Message-Id: <87wmzoo0j9.fsf@doe.com> From: Ritesh Harjani (IBM) To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Mike Kravetz , Dan Williams , Joao Martins , Catalin Marinas , Muchun Song , Will Deacon , "Aneesh Kumar K.V" Subject: Re: [PATCH v2 12/16] mm/vmemmap optimization: Split hugetlb and devdax vmemmap optimization In-Reply-To: <20230616110826.344417-13-aneesh.kumar@linux.ibm.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 53AF48000F X-Stat-Signature: 1f33xnie1u4jxkapqy8dc5zjjpqans3f X-Rspam-User: X-HE-Tag: 1687914583-684151 X-HE-Meta: U2FsdGVkX1+sEVLWqyhgd4XoTCJxUMxPLC9yOxLSjX8aUvsFuY31J3FCsAc0oG+DpRkeEPWnpPIOSsXKtmVlO46/VCZMXxagYB8b8Z731nt1pwvczeLvUpB+hf/+RnGsmqz5BHtGrGxNKDIS59v+bQysWMi/WxlnwqDwhTD9/NckHfWECyHxobllurkYJ0+zKuWnrUK3IczRU8TywDemxC5FLn7I5kkgwgejUL098MDW6gJbKRW5htEHYoz7k88XmQ/6Xg0dc1uq3BEyOnoS551djWzWHk/Jx0q2LftsfDgVbLx15mTNboINwV/CC3/MDgWkH85Hwb5WVE8po2i2fUZzrEPYU//Xh4fTKKjKsh04iO1mmRnIcmax7W4YDSMzY1/VlSIBQ59RtDwCjreiKcZars8fmhQzoANsfVTFzk3/3uK0VJEGmonSvd+hGeERZ0l5z55Q3+Fsc62oHPXDjQlvDrBpRoDHuJrZ6G1GLpiAedtLPUyQDEvsCutStKYLLwXu5AdB3x2gfs8wtffhICl2Kl1iijSYq3gKsJc7sr5sZgUPZoNfzjzGe5GM9eUfdO22Y4xIpskE9/BES0QqUgOBkyAvsCJ5ApFxvA+RNAYscprpY4ELdMFL08U9tEyPhurVIYb13xmPZj1uiqJiU09STmkOYn77x6o4fwcglnvd4g7IYA0V0MfCwD8ZdH+KCNPTg79KI2zTxR6VBqZHLGe9RDd+rqzkoUZ5a/TirX436CsNmqu6N/0pYvPDUO0CzxRE9cXpbAKChQsIeMoRPiKsR3oB4B5LCWqZOxL9fzTdUc73HNt58S23z9Fi6hlq4oEmpcYh0eA+WB6LBONB89dtO9IpE+N9wXZj311knJ08A8OT+E5z/JR4GplN5wb6x7gDt3FMyBXjOOQtmJiSIkV9FxAumMVBTqQfsbnTZjR+W3H9vYraPM1ERU76ipvUeCQd3SO+ZeoyXrm70hj yUh+Rbl8 FQDwERHdeqe5DVRzNg1C/1gt1irPt87i0w96TecyC1s8eOijtTN0DT0lD/ZTwC3ZmMMQZWFIGgLw/MLui+bSCFvbF3z34niwS4EB35BQZS8UvsZRDUKVqoOAO5ZDG+x3edanuo2L3fOTGVE6k4Wxfar54HmBQSIMF8vHxVvVTzxP9yw6cPDoo+SzqSmLaucyfUN1RaXVH8okqxDwfZA5yam+oQNEr7lbKrummo1AurzLzfmiySC02musG0ltrD5W1GIysAUZzuimgZHuK39V4tJkV8Joxo7Z6MMkNKj2rFPnVZRDJX5FHSIN+IVuf6oclsHWQJ3d5hl5ISjFvy9hJ13NnhwaInCznFKgGDqFhduCHn1HCv3YUPhfvCn4snL5fzW/e6MI3Hgr3NRc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Aneesh Kumar K.V" writes: > Arm disabled hugetlb vmemmap optimization [1] because hugetlb vmemmap > optimization includes an update of both the permissions (writeable to > read-only) and the output address (pfn) of the vmemmap ptes. That is not > supported without unmapping of pte(marking it invalid) by some > architectures. > > With DAX vmemmap optimization we don't require such pte updates and > architectures can enable DAX vmemmap optimization while having hugetlb > vmemmap optimization disabled. Hence split DAX optimization support into a > different config. > > loongarch and riscv don't have devdax support. So the DAX config is not > enabled for them. With this change, arm64 should be able to select DAX > optimization > > [1] commit 060a2c92d1b6 ("arm64: mm: hugetlb: Disable HUGETLB_PAGE_OPTIMIZE_VMEMMAP") > > Signed-off-by: Aneesh Kumar K.V > --- > arch/loongarch/Kconfig | 2 +- > arch/riscv/Kconfig | 2 +- > arch/x86/Kconfig | 3 ++- > fs/Kconfig | 2 +- > include/linux/mm.h | 2 +- > mm/Kconfig | 5 ++++- > 6 files changed, 10 insertions(+), 6 deletions(-) what about s390? git grep "ARCH_WANT_OPTIMIZE_VMEMMAP" . arch/s390/Kconfig: select ARCH_WANT_OPTIMIZE_VMEMMAP > diff --git a/mm/Kconfig b/mm/Kconfig > index 7672a22647b4..7b388c10baab 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -461,7 +461,10 @@ config SPARSEMEM_VMEMMAP > # Select this config option from the architecture Kconfig, if it is preferred > # to enable the feature of HugeTLB/dev_dax vmemmap optimization. > # > -config ARCH_WANT_OPTIMIZE_VMEMMAP > +config ARCH_WANT_OPTIMIZE_DAX_VMEMMAP > + bool > + > +config ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP > bool > > config HAVE_MEMBLOCK_PHYS_MAP > -- > 2.40.1 -ritesh