From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9816C54FB9 for ; Tue, 21 Nov 2023 06:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371CF6B03E4; Tue, 21 Nov 2023 01:32:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FB8D6B03E6; Tue, 21 Nov 2023 01:32:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 128DB6B03ED; Tue, 21 Nov 2023 01:32:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F04FB6B03E4 for ; Tue, 21 Nov 2023 01:32:02 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BBBE914098D for ; Tue, 21 Nov 2023 06:32:02 +0000 (UTC) X-FDA: 81480991284.21.0F2B4CD Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf17.hostedemail.com (Postfix) with ESMTP id 6DEF240003 for ; Tue, 21 Nov 2023 06:31:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=3rT2NFd3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZE1QqlSt; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf17.hostedemail.com: domain of ankur.a.arora@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=ankur.a.arora@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700548319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MPn6gjGfv+yMotBd5DRHP1oTJsLH0WLsdby8RrS9Mq0=; b=XYMPzh22rUOg0Av7B44F5W7xm69pSeUn7bwUBabc2uy815syN4pu0frJibHxBsRcFLgA54 mGXiK/PG3xBYB9YfaRajXRmDbaIDAhqhv03dFu+meea1N9Wa859bc6brUo1TSujPY42uQZ rfefb2Pa/Syfe8I/w1yoIVAjfCBw0z0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1700548319; a=rsa-sha256; cv=pass; b=7y7UUE07D0ph+pUzDfY7QEd4g9TiICQ08X0ZwmQLSgt7d0sDBXM6ZmssDCJjBra8O4FxUd t4O1DCQEdbzIdBFWBcmrrD/1n16m2JGSawQgL/GNl4DyrFRIf6rKOOBGK00JkAlG/iYfSB 5Gt9+6k9vx2+E9aYgjicGdLh7KPGlZM= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=3rT2NFd3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZE1QqlSt; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf17.hostedemail.com: domain of ankur.a.arora@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=ankur.a.arora@oracle.com; dmarc=pass (policy=none) header.from=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AL43go7015015; Tue, 21 Nov 2023 06:31:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=MPn6gjGfv+yMotBd5DRHP1oTJsLH0WLsdby8RrS9Mq0=; b=3rT2NFd3dqKPRyP1sWh7EeSVI22/tvOJhAydOKWQoCbi15MAb8q39bzOsTBCHtMBgNuZ pNJDOfzxkWNHOqYyeNRmiTgLc1j0ebTcftJehvz9lSqIPiDUMzh5qwq/JMBa2WnIX5hL q6m4KuzrQgLdU1fsvMX/rRRGe6sWQ3O7NHrVb8M1QWz5L0BA56OnzkreGuUrMIBRbsZ+ ZsNTmpvuqxi1Go1vu2DIsvoeN/z6CmnY5RZ2ECCrYylz7Ya+l+3USML3UIIs2aE4fLUc Kbqjs39O5AWGwsD1WthVATQJNApDIlub0fl3IeFAr/8DX0L7G77p/V3ixOm9fnXT5jjo tg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uem24vb4m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2023 06:31:34 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3AL58C01002366; Tue, 21 Nov 2023 06:31:33 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uekq6fjux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2023 06:31:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZzu0ayJitiIbC1P4mbZoSpM7SvsByP+b/jIWhJzzjBKhHU2qniXAv5dw2L0utZ1sg8RRiH1O9yhVLSo7EP4qf1zP+y7tNqrRfMlxcJL9BS+m429V7JqIl3QHRB/ZuHWz5A04NVYtwK8d/fPHwl3iwDctZtHWOYQa+xX36tpMIpVHfyFIcMP7PkFZfIf0i2jr404hAjyoSRSfOP7jdo5hDixmWv0a02AYVZx+38R9ufj/hjVMYSzrTLbvJGjq1w0zn4NaFiXXRSrqpeZ71+KefQ2/uF+toHg2Dvr21MK/hU+9YOYK+akzYQtbr3APp1mOWRKIjfMagzvk30beSNozw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MPn6gjGfv+yMotBd5DRHP1oTJsLH0WLsdby8RrS9Mq0=; b=NjwsW0xelCPnSmql7sO28pEVokDyqxGZTKl3P9w2b+SJAaegEeZ76ENeiZ8xNdiRUzXcS7iPhRFUx8U1F5h1OeGINLU5ZbDz5J27E+VlZGym1/0hkwWvFwPfCit0fBuG3WRrVF+QlHU4/5X7F2CFYwXoGFHQQs4/9954WljdJa68rd0LWRqo4LAiE0wiHkXIBUEZjoWTLJMB571eA0FMxXiNMU3dsZcBtBXqZIlNaAbAgFZ9dWxjhngvObzTAj7/s1dOX+akHhwqQGObttv6gyeFl86mT/rz7v2amHXerhCvruC41X1lDftzJHMj4cE+5D67df1yM8k2F216wyEQWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MPn6gjGfv+yMotBd5DRHP1oTJsLH0WLsdby8RrS9Mq0=; b=ZE1QqlSt3erNXkOgbQ/Xj4jIbSW5FBdRAsebWWBotoLBnQlYKCW8JQMlXeN567+4zpG3r5VtBd2QliPge93RzGEoMYgAiiYTcSrMFXK97kVxVjtMhjWbSt5+CXqm91ZJVwO+IcKHYfz+3SGIhYw8xDlQ4OXDeiyuuLzKXRuxtUQ= Received: from CO6PR10MB5409.namprd10.prod.outlook.com (2603:10b6:5:357::14) by IA1PR10MB6733.namprd10.prod.outlook.com (2603:10b6:208:42f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Tue, 21 Nov 2023 06:31:30 +0000 Received: from CO6PR10MB5409.namprd10.prod.outlook.com ([fe80::10fc:975b:65bf:1d76]) by CO6PR10MB5409.namprd10.prod.outlook.com ([fe80::10fc:975b:65bf:1d76%4]) with mapi id 15.20.7002.028; Tue, 21 Nov 2023 06:31:30 +0000 References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-42-ankur.a.arora@oracle.com> <20231108093645.GL8262@noisy.programming.kicks-ass.net> <87fs1gk0bm.fsf@oracle.com> User-agent: mu4e 1.4.10; emacs 27.2 From: Ankur Arora To: Ankur Arora Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 41/86] sched: handle resched policy in resched_curr() In-reply-to: <87fs1gk0bm.fsf@oracle.com> Date: Mon, 20 Nov 2023 22:31:27 -0800 Message-ID: <87wmuby5vk.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: MW4PR04CA0235.namprd04.prod.outlook.com (2603:10b6:303:87::30) To CO6PR10MB5409.namprd10.prod.outlook.com (2603:10b6:5:357::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO6PR10MB5409:EE_|IA1PR10MB6733:EE_ X-MS-Office365-Filtering-Correlation-Id: d09d981b-74c8-4491-c26b-08dbea5b7f34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HO6TBduAKHc6HoNG2m9bLgb78wl08mFGbfb1xJblQsCVC/fCd463NOeE9mlA6vzz789uNhliMDh+2LT4Psym32B/ES9ejtFWj8h0VSvSD0oaMxtrNVdD8Yy8CSTUeEeC+3HBzwIBkbz1L2nvBs1vP4RJDbjaKsFy7rTHR1jNBAJtNCMnzbfD0HX1EUbdJaSKYYNps9eAMelMqjGJs+xhQQpprd3S8LGVdihRwCOE+irvZ1iKQazlDntn8jO6XLqkS0XU3A68NfMWKPdt2wviapTlGXoX3SaPTqWI8jWtagvavL9CjvaKOZ4afz0AV7Oa/sMvZax2oX9e/5sz/xte+75hESxqV6x3yBNJkO/45SLfutEdujpyCjM1uR3ha9sFBSWE4Vst5jXF2AKF3WOQawWXmiZwcrRXvQ52lZ8yJgnKl+tabxGInu5SD+3U1lpxy/Zh+y02n1IeK/z/+SVY1TwmZPavtjnhjVrFd2xizsrqbJ9zvkQyoCw128n8rKLFE2b3n6Zn+TDxs9I3Zlx6sEWV9BSoAh7vLS+xNWK0BTKEFSYVqskCylYJxj0hXsve X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR10MB5409.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(136003)(376002)(396003)(39860400002)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(5660300002)(6200100001)(7416002)(7406005)(4326008)(6862004)(8676002)(41300700001)(8936002)(2906002)(316002)(37006003)(66946007)(66556008)(66476007)(86362001)(26005)(6486002)(478600001)(36756003)(6512007)(6666004)(2616005)(6506007)(83380400001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ptfskRLv1WBRDprd56L5YXzRtlxceFNB7HpgySpL0NoTsGtVvyVRTbkUg9hu?= =?us-ascii?Q?ojcK/Y5UIToAQLOmFp9iZslSkRxwwMZ7A+y6aKTJfCmz+kPadSV3JK/zHYZu?= =?us-ascii?Q?Vr5mpcoiw93d3kUZFMXY/i72FS68TVoIH1nvg7HczmsXctjDYfxmtcJI6481?= =?us-ascii?Q?NZl+CsuAF2G+ygUkWTy5Aykxh57yIlieD7khguYG5EM1o9d9qSqwJtwzwH8k?= =?us-ascii?Q?yBPono7NrNfuCiWRJ724LvsXrdr0oNRctr+RV2e3xN5bcPGm0XU4K9LzpOvL?= =?us-ascii?Q?PCkCFYG2/D8FuUnW8Hh9E4ZxDkKnlgfx0sx8KLL8AgPfH0EF/g5ltQoDhAV+?= =?us-ascii?Q?w3zS7xwmwNa+I+Jnbr8nH+5/3RfddYmaE9gXFhwPbdCgyikbejfS3Ygn6gTL?= =?us-ascii?Q?db8hbe855f9//k4HGlwlXZVwprwhJkY1XdNrFTPrm3vNhfWEcRdQu+Bh7i4N?= =?us-ascii?Q?zz8CHQ/CPiJA8bImfVUUX6f6ZTPrSbIFAtitn1WRTPoJ0cxr5bL89NLWxLR4?= =?us-ascii?Q?9XMw/ca6e3Foq9Uc+3vpTrWhNCHUrFhqWmVByLknPBdlscRdBdVWHshZm8et?= =?us-ascii?Q?+jd9Tmj76K2CeYLZGA6muIqjkQ3OaOn4LQ1lKFliRRgBUoINMJ6LsAJeBZyT?= =?us-ascii?Q?t4X934xMcDTxapd7RxK53q40gkuccQZcrc8X62sSNPCRNfnfgVACpCKwq5R0?= =?us-ascii?Q?qMwc3x493TAiIkKCrXovUBfkUTHZiqErzpSiQsVIOw0cUwmPP4PV3JKmW8uA?= =?us-ascii?Q?X/+FIf9LXgCg0Kle7Ppn/3e+0SaQOmuYiqW+MBS0T1cbNBYs3DVdYsWtKWYN?= =?us-ascii?Q?eWAhOcc+C5I2MnnqW5B7iNL6HE9NQhPnetlgiDc5UQaXRo3LKsa7sa1lqOqK?= =?us-ascii?Q?wCijcns3iUnYYeEYTlrmtWYgaRBSpDIinBnYb3CVLcvBECh7wV0CrOo6GFqk?= =?us-ascii?Q?t0JYvaprpzknq0HHdYOjZZ54JyMp8hqYVyvdgKCUVByCYHZGzMEjeYc9fHpJ?= =?us-ascii?Q?drJjTgWcrRR2ysHMlnQrtNVazPEXl4DRSSqECSt9fWp98sfw2DLgKcZPek7+?= =?us-ascii?Q?gkNnDlZIpYUzP3K/Cya38kVBK8oIqFImE5epp3sqdvJblNOaJAK/vOayYrIs?= =?us-ascii?Q?9K20pFG5AisNPNSB/PDq4/mcASvlxiJoIOx+zx6KVdlBh2vsurRhhM3Vd8kB?= =?us-ascii?Q?0o3d+xKQdksMBJAcaxZ8Y6cKrD2hkH5HvunsNC4EFZKyzf0tZr3Paiaz/hZ4?= =?us-ascii?Q?ORm4cwFe234unrJYLPNBn2Bdta/PySYV7jPUsv6Eyu9zCMkV99Cc9g6TvEEP?= =?us-ascii?Q?cBb1m/otPgoXINnLTawFQgNUj6RfIBpQPP34kUyeoshgm1B20ARl0PftCOBt?= =?us-ascii?Q?er3TrjEu2fJPZCNpHGYBRTHokA+zrj0ZCr5SkY0+Lavfrzj/rySUS2wwWa6z?= =?us-ascii?Q?IVNm1W6I5y84atHX+Q38+6t/NRXBSy2CvSccn+DAub+MyoyCpu66dB7XovJU?= =?us-ascii?Q?Yp7ct7WKqBJW3RUAafWNuk6pyCfYlfmWeiqvonWEjk2JnLVf/OVjs5bASxHm?= =?us-ascii?Q?hlEEkhVfW0zthQIlVorQ+NTyjNGVfp8bGPwfAAGJRJZ1RS/CVd0phSJ4RNl1?= =?us-ascii?Q?RQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?unZPiBf3b5p4+srdW2YqXMTSvufgJKoVN3oimT66Ghg3Tl6MPm8zSC1RwL5Y?= =?us-ascii?Q?fIDmFwfd5fnGvqT1O5u0/4qShmSvhTRTzjV8KZNVZXbvqAM+I6X2UNCEp7ZE?= =?us-ascii?Q?YRlUjFK7RqrrsA6XMrxTcCEYGVoj7TjreHmlBdok0Jz+zN8owlSVbcpYj6wp?= =?us-ascii?Q?qTOudA2Dgo32H7jVeI9YFXZ04on+vQS5txhKbxg8lOrQ7I+dhtejWGmbz42A?= =?us-ascii?Q?fqeRNAkrstvsMqSCkBFlJRY87aYgMlJp8wft8hAo7Z37D0P6afSdNQ/u+kUR?= =?us-ascii?Q?DMnp+BCFEj4T0DZqAl0TWQZv2ymoiYpUKHt4qVte6j71g+hdLf/UB29Vi9L8?= =?us-ascii?Q?w+TXIyD+qtNQncywBU7YzJMYOgADdTb7l+yPQvxRa37q6aqvUfV0FvwNrA6I?= =?us-ascii?Q?2KFR946FQ9n/4ya+T9K4iPU4wRRqOTrRxT6drFJlqyoI5aMYkD7V2wczmIfe?= =?us-ascii?Q?UMKpJg8B8ie/eU8ZKjun4wWS7uDBg3B0jsAcNR34PtIUSF7SBAwL6H6GfZcS?= =?us-ascii?Q?jHmU/25JpRGVyU3kred550X8ffBpZmzl2zlZ0ePZXVU/6PcYobeMbs5nYuYv?= =?us-ascii?Q?cJyc1oXFyFFPhuJ4gFbYMnt9DKRqOasRukVqDJbE7uKhdY6S9zjqHSv2sHvV?= =?us-ascii?Q?xmY5DnToiYmJQXqwlNeMHmBd0uF12Ln4sl0t2UN/67+uy4q/UrGwPP9t75cj?= =?us-ascii?Q?LiRFQRxbKdinB6Vfvy2c/z72S1hSjTE/zKLjXxkuXTmXNCj6lu84CxVG7aPA?= =?us-ascii?Q?EyT7x+UhkpQifK2LjHpuU5M8eiLieTgZx2NsYcb6G2KlrML5ZxCa7zgRK185?= =?us-ascii?Q?IuGKJQH8yzImyCQw5ajBukQUHa8kyTIRnMkxcO98VchYzpLWyhPmjvtI38Pz?= =?us-ascii?Q?e5vJGbFNheFH3UQbtowdyQdUN/tf4YzpIaZA0h7ZpKQSCBCOcVz5lNojqLV2?= =?us-ascii?Q?zgCbrswJjGxbykmtTe8P1Bfzj+OG7jQReY5TB+roU01CGz+T0sPLoP37Eau1?= =?us-ascii?Q?pE+EyHzRBNJRwPgr921LgepZAYjHurKiQrm2y7R7iHApf18uof+R/3BWp99V?= =?us-ascii?Q?LD3msSqR5oi6hbva64fWsY3+BZeURGS75d9ZJs3xzjmUybJhotPeERDvc+Yk?= =?us-ascii?Q?ilGI4qsXoCnyzH3IhNTf9OvZ5lMKk8q+9sS5LjONXXelXs9EytNKfgtLRmq3?= =?us-ascii?Q?jeOdWz5oG7RQSIfYhSHHfItcMiV5X58gSkLbAyVVA++fqmK4igTfg/IMKI0O?= =?us-ascii?Q?lL3YbZcEBiXwM7a6o53cJv+Ez59Mk/DpLM17UgFCNe59K61O26e7etzuJ8K7?= =?us-ascii?Q?lo//s1DeREJbeYYIT8mXmGAWOv4fPY+k+aWfNJ8ArmR+9tHe448/3rVW12+g?= =?us-ascii?Q?SdWUOMADL5f3CQAR047v6wF+9ebbrURa0RaPskEPDwKi3loogXy38PDg04BB?= =?us-ascii?Q?rIbBLg70uUxGDVHUyQs+2YryiTBSS7Tvf3Pkl2kIH/nUswf4IyR+RhNJSoeB?= =?us-ascii?Q?KjX+Ent4LK5KbM3NjrnDmzhCgKm13o/PhKyvA0TDBAOlcJAeavFEhdC3gQ?= =?us-ascii?Q?=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d09d981b-74c8-4491-c26b-08dbea5b7f34 X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 06:31:30.1981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qEErQQObK6ogDONA9rgH1dX8591aZYVWoSbdoTyBkbS6g0NWj3EiDOc6q/rwnVoqn8utg5xpaYh/aVFrSdn5zUirWRaWWJlw6yNgl7XvaIA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6733 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_03,2023-11-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210049 X-Proofpoint-GUID: -peT4AevBI0UX2xUPi-VduhMyyHHELeN X-Proofpoint-ORIG-GUID: -peT4AevBI0UX2xUPi-VduhMyyHHELeN X-Stat-Signature: fnm4peqib1u8uwqipq8un7juswewbgft X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6DEF240003 X-Rspam-User: X-HE-Tag: 1700548319-999139 X-HE-Meta: U2FsdGVkX1/OiQohWZ3Fi2uMXEnY1FrhWZHFUR3Z+7kbOIDwHuUVKdFkc6Lh57aYK75NBv3QZOVnVo1KPHefZiant969+LJfkpV6O/24fIqW9UJ2AWjPO+w1nXMy0Ru/VOpzQxbbWUiCg9sRFwapKlC9dQIXLTE6S1kDf1fez7OjiuGQizXAzTVKrlMAV90f2BwPNxEyCfLVpjFdisT+I045bUfGmqZbH1jgXm2JUThJo//EzIN76+HYeANfN/GKRk6fK77zc/YZwMUMAfeme5pxBlJ6PY24a6J+dHzw+d/e7Z6j3q9j+QZnAyMCTcpr6Y1QXfXatEYWsF8qhFiHgjn9gFIRhoFCg7LxNxEw7FrWeO/nHpn8lrlFoMBGq+tv76KFjcvRVRa2AOEYdwVlBTYZyGfdSFRUfy0qKhlXa3+8Mz8G5Bp7fz0bH2ofuXLi04B1DBItvoIG0ZlvWcr8S2XijuiWGKOoTq8KmY6tYnGHZPE9RofyqotiZiKYUGOOSm1nUkDhCrZ5Cps6JMovwIFrNA32GpeGM9/Hyzm/q8NC3Z8kZlAJsyPu21CfUFxd32ZXnOAys6AA6fZfFDz9PRxNV2pUvHj+1BaLaXLv0lh4H2+Rl1TZEa+KdzKDrF+ELJMRav+qEdS62T3ZjgNBZZedoMRNaWk0xlVx52oSyB/IxBiw/UKd6QXKPWJFvSRojEWz99ea5Mss/qIUQBp992U5E0L4XxN330Mm3R/9jwsYYbWG3vMo0NJVmGmiccHhG3lQ9YzUFeo+VDf96mD9GRRYr4B7j4xIthqDJq10mPT3EQR98DWHpXNT1fX0FfihvZ0+s25rv+2yl1ByheV9qqzqY9ngsOvpZIz3ved5JmWQct5IYRdFM2OPYj1488/31brYjNiQC6LCLYEfDNy2roe46ibFu7tLmEp9CW+qd6qVeqJCbIK+L+L+if7uN2z8YKKh3p4LGLwhDiFl/ze 7S1UQrCq Jp42Uwl8UXBifIRqW6Gl1jxvNyyGjdPX2XA+L2sIMeiEfWqof5DW387keg2qj542TvTqwArtvb3DEJ2oUCKz3DwqNSSbFHOasVXETRB9zvFFlpOS0+A03hKWaHpdZBTb7GqLIpq+x4ZI7+f/dr+sgmM6t/q+uVwHMLyeZ0wrEI9+Kl5QrmZY4I3Jvv6Ju6pDlPxqihIsw6jltr+Bn2WQA/MLgIebpnMC3axAgr9OYDyonfllxqcR810bRkj0H7B1+RhsFJUMTUEIW1tEw2ocxHDUYRsh+j5x7zgomSftHsY6cuPMjt2TUT+/2wXKYslHUvlFXj6fW99/rF46NaUGgLmI3cL+T55K5Bmh8WqSw/xZhjK9OPRKtIn0rlrABGPBHcy2UAkNd+EUP1CX25zggng3YWURtc8rA0svSeF4I1TKz6BKRyk1slPW1RZIZw2+fG6MQ5fwyH/8cuFf55jkaQYPMllzrayM1reR1Hkx4C4s3wZ43F1EAlExFLRNldH1jZAio X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Ankur Arora writes: > Peter Zijlstra writes: > >> On Tue, Nov 07, 2023 at 01:57:27PM -0800, Ankur Arora wrote: >> >>> + * We might race with the target CPU while checking its ct_state: >>> + * >>> + * 1. The task might have just entered the kernel, but has not yet >>> + * called user_exit(). We will see stale state (CONTEXT_USER) and >>> + * send an unnecessary resched-IPI. >>> + * >>> + * 2. The user task is through with exit_to_user_mode_loop() but has >>> + * not yet called user_enter(). >>> + * >>> + * We'll see the thread's state as CONTEXT_KERNEL and will try to >>> + * schedule it lazily. There's obviously nothing that will handle >>> + * this need-resched bit until the thread enters the kernel next. >>> + * >>> + * The scheduler will still do tick accounting, but a potentially >>> + * higher priority task waited to be scheduled for a user tick, >>> + * instead of execution time in the kernel. >>> + */ >>> + context = ct_state_cpu(cpu_of(rq)); >>> + if ((context == CONTEXT_USER) || >>> + (context == CONTEXT_GUEST)) { >>> + >>> + rs = RESCHED_eager; >>> + goto resched; >>> + } >> >> Like said, this simply cannot be. You must not rely on the remote CPU >> being in some state or not. Also, it's racy, you could observe USER and >> then it enters KERNEL. > > Or worse. We might observe KERNEL and it enters USER. > > I think we would be fine if we observe USER: it would be upgrade > to RESCHED_eager and send an unnecessary IPI. > > But if we observe KERNEL and it enters USER, then we will have > set the need-resched-lazy bit which the thread might not see > (it might have left exit_to_user_mode_loop()) until the next > entry to the kernel. > > But, yes I would like to avoid the ct_state as well. But > need-resched-lazy only makes sense when the task on the runqueue > is executing in the kernel... So, I discussed this with Thomas offlist, and he pointed out that I'm overengineering this. If we decide to wake up a remote rq lazily with (!sched_feat(TTWU_QUEUE)), and if the target is running in user space, then the resched would happen when the process enters kernel mode. That's somewhat similar to how in this preemption model we let a task run for upto one extra tick while in kernel mode. So I'll drop this and allow the same behaviour in userspace instead of solving it in unnecessarily complicated ways. -- ankur