From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF398C48BC4 for ; Tue, 20 Feb 2024 05:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54DD98D0005; Tue, 20 Feb 2024 00:32:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D7628D0001; Tue, 20 Feb 2024 00:32:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39DF58D0005; Tue, 20 Feb 2024 00:32:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 27C6C8D0001 for ; Tue, 20 Feb 2024 00:32:00 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EE3F91A0360 for ; Tue, 20 Feb 2024 05:31:59 +0000 (UTC) X-FDA: 81811060758.04.490640F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf02.hostedemail.com (Postfix) with ESMTP id 1581F80005 for ; Tue, 20 Feb 2024 05:31:55 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lsKR9G6N; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708407117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J37CQU00IcoKpWs2RaqxLX9XlHAq8fPKYlLqwOBv7tU=; b=inEpH/jdewsAk8YhrdhtsPq1XSfyhWdyAHxEbryvQE8tFBCX1f2Dmx3qhrJ4Us5FdWiOvB l7yjwW5fP2ETBLYMcrk5WjmlRUVshS0B/GAdnN+BYvpSvr6JJdUotJTRdQWPvRWeqbeUDA jvEGPtW1122YFdN6I/VcQz3dw39XmR0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lsKR9G6N; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708407117; a=rsa-sha256; cv=none; b=O6ra8BQUSO7vj+CuDTeLynMRzz6AS4hPNPMmh3Y9rMeoS0ZKTEcZ40RQoq7VerbylY9Ag5 8XdL+Gj0qV5RzpkXplikHJges/KRqJqysK8oMtfY3oGa1+QTwXFH4uUdA34gzIK6XUijbL 25yoDl57FiwYsLoIVZGtnHs9QnWNl/A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708407117; x=1739943117; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=SqVTf6G26lQVP2Kos51dRn5WI0uPk9WrsIkm1pz1Gow=; b=lsKR9G6NFq568QIAHdCBkFkwmp5zdnUEbXBNfRY8v5jWvDqUueKCl2Sf RzJT6BSttSxqE1E9wNxdOydQvMPZ+yp9Fd/8Ctvo2wkWyZMUfW25OejuU qVwZPp77t92tg1YJstXGtiWHizrRyx0L6G4cxf+7NbKQsCz5K5fD+VI19 TG9Ak/5/Wakjsm9DEfRhcZ16xasK0upUBUDfvf2NH7KwOqqAZn3B4+TzF +OX0tjidtnMFAbEWLwAyHnDohQ2JCrGN23P4T8z8EVe3FoOrrdq55x9FE ya+LJI1bC0YJ8XgpJJpus3QmeGtm32Ttv0zvByR5XH6mm7b4UKrR1iOwq w==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2636758" X-IronPort-AV: E=Sophos;i="6.06,171,1705392000"; d="scan'208";a="2636758" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 21:31:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,171,1705392000"; d="scan'208";a="4964130" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 21:31:52 -0800 From: "Huang, Ying" To: Byungchul Park Cc: , , , , , , , Subject: Re: [PATCH] mm/vmscan: Fix a bug calling wakeup_kswapd() with a wrong zone index In-Reply-To: <20240220040306.GI65758@system.software.com> (Byungchul Park's message of "Tue, 20 Feb 2024 13:03:06 +0900") References: <20240216111502.79759-1-byungchul@sk.com> <871q97rec8.fsf@yhuang6-desk2.ccr.corp.intel.com> <20240220040306.GI65758@system.software.com> Date: Tue, 20 Feb 2024 13:29:56 +0800 Message-ID: <87wmqzpusr.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 1581F80005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: unqpubnqm1au55em96zd61iqi4coa17u X-HE-Tag: 1708407115-948378 X-HE-Meta: U2FsdGVkX19/LySibSBonAItNQLiPu/+GxiegBd2POV63d0jTLyHXMIm54U0cNAEmib+lZx2X72JPGo+eHvIYiS/xTGswNP8DrUECQGVMVSDS87pTD9GBiwqzixC+VqQ6aibT9Vu+XhOXL2IghYsYzgoz7cGFZJ4juNp9M46WDddZjisGtLgJvxeuKIF8Zj91HLI+6LVgkC5bmFL0xQ26U5URupGybApNriAkEhyjdZF0rnjHG1ZgICH+ZU0NDRfch7YtaZAQO+lUMtTAYFW8ZuANpS5mnJWOmOrKAOD7REb9wydJ1ofYKLF6Bf0X71G+qtV34NVMt0sXyGUt5HQr1ve/bSrlhkw+XhnHBC54NLv72IqENlsOdGiRa+SdYNqRg2Z1FhI1G+HvyhYrPvgib+QXYsnORN/7/w8IuHBBQ+5xdDjjBBPyOTwHj2LVEeZB4fNyRmqgFsb6W2xJ7dKDIHcxaBoubdZUaffXCVAOCFvYRAmHdwbFF5UaP4kx5MaBtM6rVmLTHEt57zoOEvbOaqeJAXCuewjK7seSzdb8U+gjJy5zTO6Lv5hpeI1oxuNSI+5xA+g7FGRyXq1NY31jBBKx321uKRAcmHXBSvSY/xKjMB8Xf9W58iZLtNtSaY5Ss7OJliXs4lcwDpn0iBAGt0JE3Siz4tLqaVxK7bEz0PM9qPPpPplzxTNH2JCr+p2ZJCSjAwb9nTJfbLwwUUwUToG6va7FD8QSUtSDBeP8F9xLowtoeTvNLvo5L65oUomdd2w9q3ab385IqZQpUszkuY2E6UIenvidH910fugXfuw7AjiyLdazc+80HHORvsLZ/jeKFPab9g6nJdEC6++kw/UhVa8XFvvIQ9oe/JEjKoUAgAXj1cR9TbaWL8m2WUWZV6doKkcRniJxnQbf7nYufEGG2Co4GendlAGkpDvV1GbY5rF/7H8O2KXcmuZmFGPc5Yy/7hUOZqYPyexyHG PuebfeT5 UXh5wuMDkTkAbv2rqY5wZJrXsHL+uFPnacytCH6tN2FD6hpdn7O2FHeb2QtuEhLpBaGViAOgnKbyWLcHPlZCPd5GncjbQ61xMxRC8Apwzg9agWt/Il+ojuRMNKbFK9oVMEVIJJBDPWD04dg079WojxhuwvJ/MSt4Qy39eujtsrLgzCE2VZJLy0UpK0Y9eh6M6mEkaXWyQeXX05FTEgdgfD5S824a0IyU09uK51Ltxhi4vVAq/xU+SRM+p/dvgzaDo1XIF79rz9YpQu8PhVT53oZ3DrjuSoYaxp7RkirJiaViXfAl94HPzPi4cWi1Kd9d17JalCE6i1qHl/3NxGndHPt7wAMbNzxlKa4e5xZ/ekKPQBAD0lKsEovCLdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Byungchul Park writes: > On Tue, Feb 20, 2024 at 11:42:31AM +0800, Huang, Ying wrote: >> Byungchul Park writes: >> >> > With numa balancing on, when a numa system is running where a numa node >> > doesn't have its local memory so it has no managed zones, the following >> > oops has been observed. It's because wakeup_kswapd() is called with a >> > wrong zone index, -1. Fixed it by checking the index before calling >> > wakeup_kswapd(). >> > >> >> BUG: unable to handle page fault for address: 00000000000033f3 >> >> #PF: supervisor read access in kernel mode >> >> #PF: error_code(0x0000) - not-present page >> >> PGD 0 P4D 0 >> >> Oops: 0000 [#1] PREEMPT SMP NOPTI >> >> CPU: 2 PID: 895 Comm: masim Not tainted 6.6.0-dirty #255 >> >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS >> >> rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 >> >> RIP: 0010:wakeup_kswapd (./linux/mm/vmscan.c:7812) >> >> Code: (omitted) >> >> RSP: 0000:ffffc90004257d58 EFLAGS: 00010286 >> >> RAX: ffffffffffffffff RBX: ffff88883fff0480 RCX: 0000000000000003 >> >> RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88883fff0480 >> >> RBP: ffffffffffffffff R08: ff0003ffffffffff R09: ffffffffffffffff >> >> R10: ffff888106c95540 R11: 0000000055555554 R12: 0000000000000003 >> >> R13: 0000000000000000 R14: 0000000000000000 R15: ffff88883fff0940 >> >> FS: 00007fc4b8124740(0000) GS:ffff888827c00000(0000) knlGS:0000000000000000 >> >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> >> CR2: 00000000000033f3 CR3: 000000026cc08004 CR4: 0000000000770ee0 >> >> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> >> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >> >> PKRU: 55555554 >> >> Call Trace: >> >> >> >> ? __die >> >> ? page_fault_oops >> >> ? __pte_offset_map_lock >> >> ? exc_page_fault >> >> ? asm_exc_page_fault >> >> ? wakeup_kswapd >> >> migrate_misplaced_page >> >> __handle_mm_fault >> >> handle_mm_fault >> >> do_user_addr_fault >> >> exc_page_fault >> >> asm_exc_page_fault >> >> RIP: 0033:0x55b897ba0808 >> >> Code: (omitted) >> >> RSP: 002b:00007ffeefa821a0 EFLAGS: 00010287 >> >> RAX: 000055b89983acd0 RBX: 00007ffeefa823f8 RCX: 000055b89983acd0 >> >> RDX: 00007fc2f8122010 RSI: 0000000000020000 RDI: 000055b89983acd0 >> >> RBP: 00007ffeefa821a0 R08: 0000000000000037 R09: 0000000000000075 >> >> R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000 >> >> R13: 00007ffeefa82410 R14: 000055b897ba5dd8 R15: 00007fc4b8340000 >> >> >> > >> > Signed-off-by: Byungchul Park >> > Reported-by: Hyeongtak Ji >> > Cc: stable@vger.kernel.org >> > Fixes: c574bbe917036 ("NUMA balancing: optimize page placement for memory tiering system") >> > --- >> > mm/migrate.c | 8 ++++++++ >> > 1 file changed, 8 insertions(+) >> > >> > diff --git a/mm/migrate.c b/mm/migrate.c >> > index fbc8586ed735..51ee6865b0f6 100644 >> > --- a/mm/migrate.c >> > +++ b/mm/migrate.c >> > @@ -2825,6 +2825,14 @@ static int numamigrate_isolate_folio(pg_data_t *pgdat, struct folio *folio) >> > if (managed_zone(pgdat->node_zones + z)) >> > break; >> > } >> > + >> > + /* >> > + * If there are no managed zones, it should not proceed >> > + * further. >> > + */ >> > + if (z < 0) >> > + return 0; >> > + >> >> I think that it's better to check pgdat->nr_zones directly earlier in >> the function. That is a little easier to be understood. > > No. No matter what the value of ->nr_zones is, the oops is going to > happen if there are no managed zones by any reason. Yes. You are right. Sorry for noise. -- Best Regards, Huang, Ying > Byungchul > >> > wakeup_kswapd(pgdat->node_zones + z, 0, >> > folio_order(folio), ZONE_MOVABLE); >> > return 0; >> >> -- >> Best Regards, >> Huang, Ying