From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D36C3DA4A for ; Wed, 14 Aug 2024 14:11:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D8316B0082; Wed, 14 Aug 2024 10:11:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 261086B0083; Wed, 14 Aug 2024 10:11:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 129036B0085; Wed, 14 Aug 2024 10:11:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DB4A16B0082 for ; Wed, 14 Aug 2024 10:11:36 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 90631A7E2F for ; Wed, 14 Aug 2024 14:11:36 +0000 (UTC) X-FDA: 82451038992.11.9ED5932 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf17.hostedemail.com (Postfix) with ESMTP id BC83940016 for ; Wed, 14 Aug 2024 14:11:34 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=ODQSY6hO; dkim=pass header.d=linutronix.de header.s=2020e header.b=YMCWSYFl; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf17.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723644636; a=rsa-sha256; cv=none; b=WarnKMP6xgQCviahyjgrT6MiySVpt5x0HOpEt/Bh76XL7VgpcocVkd46YVDjG+Xv83/dJj j/pWFGoeha1iG+mUis3sOvl9VQJbJY8aqC9qD+W4miwY25Rr2He/goNiv7i7ffFhSSJQib vQR0TvAnZEGt8SHdEmThJyT9eywGEYg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=ODQSY6hO; dkim=pass header.d=linutronix.de header.s=2020e header.b=YMCWSYFl; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf17.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723644636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T1AhgiSWd4CHbyJVRcAUEEiIVnvLy5DrEW8lz6MAKjM=; b=Lio0U9Add1/MxUHLYlOIeVUAJDuPhN1bxaOeTLZri+gZcUggrxlfXdCA76D4YoYkJUwSby Cg7kb9Bb9eYlXi7Rnj8maKE8vrx0FyNtQBzibD8XMyXEnvQQsTYbo+j9x38MrB1hWo9K3J qOl54inzGau4XpOEWSOAqN+It4BTr28= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1723644692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T1AhgiSWd4CHbyJVRcAUEEiIVnvLy5DrEW8lz6MAKjM=; b=ODQSY6hObDfscF3DXOwJHOfLU+seGzt1TE/bjezu3XDbLMh5Xi6riBqPqQ6nb0oOK9KDXS f8+1CtrsnTsr68nSLVjVnSmeksFHVxiEwBDFWt6ZeMO9YiZJsOAwX3yvfc46lNxxyqtVUZ 3u3grBa0md7iyoWN+ktmH2bMSEElLXavibBRLs/lx0R4QqoM2dTmtid9WZaZF+yz78Arzj IKf7EylEh33wBF8hfHpS3O12pdSZRTuxshqkFndnQxgBhat6Odd15dxNPmjafhtGzGMfcx uS3Xr4uj5jGgUqZcNmdKzJqM159oQg0keCyUOkREO/eZlVxTWm1xcw9O6oLNYA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1723644692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T1AhgiSWd4CHbyJVRcAUEEiIVnvLy5DrEW8lz6MAKjM=; b=YMCWSYFlVF1Ph7fRO3ylWD2DNyVlLYqTFg573JIEwa5UA1vIRvpCUdxgCfJ7c1IG9g5YYR O9fms278zo7AVaAQ== To: Christoph Hellwig , Alistair Popple Cc: Christoph Hellwig , Max Ramanouski , x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jniethe@nvidia.com, jhubbard@nvidia.com, linux-mm@kvack.org Subject: Re: [PATCH v2] x86/ioremap: Use is_ioremap_addr() in iounmap() In-Reply-To: References: <20240812203538.82548-1-max8rr8@gmail.com> <878qwzpfbi.ffs@tglx> <87le0zmhdp.fsf@nvdebian.thelocal> Date: Wed, 14 Aug 2024 16:11:31 +0200 Message-ID: <87wmkjnqi4.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BC83940016 X-Stat-Signature: bh39i7mapjc6e4869xa9kms4ico3iqjp X-Rspam-User: X-HE-Tag: 1723644694-831184 X-HE-Meta: U2FsdGVkX18g0NK59DbVaNvbO64cY813W3ZNyCbHT1zr9jTfJzaXFZEL0ll+wpgpXjjuEHdRAcparmQVsLfiMFLVVYJi8Q+wFo0zhiU0/HjOERiGU/jD1TE+l5dCr8zZm28Rd7PVSkYASdEqcnLs6RqkX+x958jqlYYHZ4tCnZeDvDt6F2eVv1zVsvRfuJlogJW7k5sYVzH1ShOy0Nmv/qa9H1UgstiE0I7AgamRFFnjGhHCvjgv+3LNxGJQiTtC8AeHD7vLodn9rrz/s6F0PDkACtlpx3KciftIBxP2KXOkP4LK5lL39LKQLWhIV0RWgaPX1cu/GrLhDeOKyQC2QsYW8WpxLWbfh7VJf8L/anSxRwLY2cEqzz5xYbwxfolI0mO9+1k6oVRfQa6um5CwKWoEab7xj8iOFEp5JVjh5E3t+r9zTA/HZdUkTORIw1fBEJQfZGS2B2texNnLhbYnfiZP7b7radNJY14L6EBu+rlPvGxszWKx+uSHY63QNzPzO5T69DPUsGogvEqO1osH03oT5XqshQqO1Iwpm2R56HYXMFgMP3A0ibHpLX4e3H2tCVDKfRjfC1NFQH1YzKSQjaLfMCHDvHg8rVkWxnKcX9gvenDjnUeHRkPGz2pa1aF5qpUzzpvxE1tEFTXee7auPndI8USrig/wjVMLv1h5MZ3MqeldLsHQME9JiPM1ANoxHR755ZiWTNXBbNTNlimYTprhYINanwRWm7JYIH2Wt8qVZUlCoCs7tuNXpy9BJ72oBNKs8w8wizIZCcqVRpaTxY60B2YyCeVuoxECF5yCPFtoNPLJ1iqHPvhWxxVPizLbbNuEvnWbfzzZlaifZKQfIbYSzobK+UEqCOMg9DIgVAZTyNpTXxjSqhnRF4AnTJG34vO4aghMtzdATQ8tiJS/Kxcdb3ys3RPsScKWY4NfXxTGs/rp8rGOqieexi6/hvM5nlpPKNuiMUwCtljXF87 1i2ONHKd 6sYfmBP/ENvReajIQvSEU43+v6yG730HVqLWtKcU8q0Xt+sm7Kxi9mLwri6Z6+hsD8JOXkEnNKjhZkJpRyhqe1trMBVAvgA/1W7NIbS9uum7C2QbG9blPf9Mv5Zjc7mBxF3aBIP3RSDq5iUoWSqYd1HLooxDwTKNc14webjhmYoA7aJ9qdMYrAo4VJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14 2024 at 05:16, Christoph Hellwig wrote: > On Wed, Aug 14, 2024 at 10:08:23PM +1000, Alistair Popple wrote: >> I would tend to agree and had the same thought when we found this. At >> least some kind of message (WARN_ON, WARN_ON_ONCE, printk, etc) would >> have made the issue we were debugging much more obvious. FWIW I have >> tested running with a WARN_ON() there and it never fired except in the >> bug scenario. > > Various architectures had either an early ioremap variant that got > silently ignored here, or magic carveout that don't get remapped at all. > None of this should currently apply to x86, though. So I'm inclined to have: if (WARN_ON_ONCE(is_ioremap_addr(addr))) return; in the x86 variant then. Thanks, tglx