From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D659DCD379F for ; Tue, 3 Sep 2024 16:48:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CEE58D01AE; Tue, 3 Sep 2024 12:48:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67EA08D018A; Tue, 3 Sep 2024 12:48:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51E938D01AE; Tue, 3 Sep 2024 12:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 337C98D018A for ; Tue, 3 Sep 2024 12:48:38 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CF7AD80690 for ; Tue, 3 Sep 2024 16:48:37 +0000 (UTC) X-FDA: 82524010674.09.46A71AA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id 7D649C0007 for ; Tue, 3 Sep 2024 16:48:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="BG+1/z6O"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="8/QRhtk1"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Ee4CIHif; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=DdPV61m2; spf=pass (imf10.hostedemail.com: domain of krisman@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=krisman@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725382040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uUkAGhQlI+yN4lwMNeG2MzsSwkm6SHFc/Agy8/FGBY0=; b=ooHZdKGvPBqcZWvD139KX6rIpPvlhM3wzC+dHs/+G5CbSy3vazjaA6rp70qqyLmfz3sQ5w AZ5VGXlqYmokPKLw0PrGX7WKhPv3e/O7e4/vy5GMGH4dWju2mEiSa9iO13F+HwXt5hDw+X 9jbH1jm5m72wZmEIlH/UfL4wNkOoiaY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="BG+1/z6O"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="8/QRhtk1"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Ee4CIHif; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=DdPV61m2; spf=pass (imf10.hostedemail.com: domain of krisman@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=krisman@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725382040; a=rsa-sha256; cv=none; b=s+GLisDFc8ygXMYhbhzr2IVViqwjQBxEJGKZFeUA0U8lAYukUud9DXNIPkezSWwXz9pqww TcVijm6M+E9bxvxdmmE1bcBXFzdPpAC6b+mZZkrNKJtyl+N6QqnQdBfH/Fdg51wSFRHa2+ 6NP/Kp6t2X3zXQnIJJ5rH7lm6vnd0vQ= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD298219CC; Tue, 3 Sep 2024 16:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725382114; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uUkAGhQlI+yN4lwMNeG2MzsSwkm6SHFc/Agy8/FGBY0=; b=BG+1/z6Oa4xCqXijpfqb0qkQBjTa3ynwZsFzvpvG+fGzfN9MvMZqnmEsMo/W9QgW8lJlrS HucTlRhaI+dBuBCPPiIVqIoNcLptKQObHWGXef4C4uLqq/yzUP7ru4oKux1uutPSFxkNhe 2w5+bDoziaPaKZUlQLPtMRTkwGxrKow= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725382114; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uUkAGhQlI+yN4lwMNeG2MzsSwkm6SHFc/Agy8/FGBY0=; b=8/QRhtk1SwDUgJST482Y1CEEGNq33oYAjAFQDn6a4kK398LpGBGugp3OiAD3c7E2gnojfk yhtl9U6EeyKMZ0Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725382113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uUkAGhQlI+yN4lwMNeG2MzsSwkm6SHFc/Agy8/FGBY0=; b=Ee4CIHifY0caKzGXsIXem59s6we1GUHo4DNd+2KTISAufj7iHtOyusrcEfgB0i/OYVInKW BMlVPfo/TvkddoLNBj91rx9yK4DHG8eX6BSjdvAJqDlrbiOOLVRkX2PNYMI1tX7cubDLpA /C3Pw098Ei86IUtzRICpcgdVpPlYNj0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725382113; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uUkAGhQlI+yN4lwMNeG2MzsSwkm6SHFc/Agy8/FGBY0=; b=DdPV61m2rAocFS6QNwErVt281xUR6BhGj7CkkQpmS0SUhf/Kl+ak2EAd9FXWJbbeybwiAx cF9gmvC2KJjcWuBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8C48213A80; Tue, 3 Sep 2024 16:48:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MuVOHOE912arCAAAD6G6ig (envelope-from ); Tue, 03 Sep 2024 16:48:33 +0000 From: Gabriel Krisman Bertazi To: =?utf-8?Q?Andr=C3=A9?= Almeida Cc: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig Subject: Re: [PATCH v2 1/8] unicode: Fix utf8_load() error path In-Reply-To: <20240902225511.757831-2-andrealmeid@igalia.com> (=?utf-8?Q?=22Andr=C3=A9?= Almeida"'s message of "Mon, 2 Sep 2024 19:55:03 -0300") References: <20240902225511.757831-1-andrealmeid@igalia.com> <20240902225511.757831-2-andrealmeid@igalia.com> Date: Tue, 03 Sep 2024 12:48:28 -0400 Message-ID: <87wmjsfztv.fsf@mailhost.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Action: no action X-Stat-Signature: o59tjh1rnj5gu4qbsxtrwp94djez9ipt X-Rspam-User: X-Rspamd-Queue-Id: 7D649C0007 X-Rspamd-Server: rspam02 X-HE-Tag: 1725382115-229587 X-HE-Meta: U2FsdGVkX1/D8ERvWhNgZIWjxfT+uKNjGPRRBI7RkrfPPbZQG6NBx98WaUMQyC7qPOv+Lf4PLjdFttZ8i01f2525n2PPoCtx5Rw0VoVWpt4TQtASFdUatI/dxHEeap1mevz6UihqBFWgbO3CNBWJ4DAMj0wauQkL+YKuRbO4gdStAb6hMrjEg5BWRDpHTLMSXLMzWbT71lQk+jZAa52C0ixF123r/R1s+vHftM5J3KtVbewIvVk45a2cs1Tp6CLEX0Zq36scJDmMw8PlQ8SN+yhvAfY/EUdQnMMa1GEf/XGX3wnXoMvyWvQkgTZhgp6IbQcF7nMDLDrAbhkknoWDjEdvoGe4ht1+fgGF+W0LQM8qWuEgN8nqqcy5QdZHwWEQSruS0xhYi4SULCwPUDkzHfpGuLwl+5RmRanM94zMDxpPVpXiOGg1BukKPxe/EBjX/mh5nSbWU9imas3oXSREXQIl7lzsgCWHzHAttd9/NXVg/+zcE5WdXzLl+7cIG16bX5OyFQEeJEc95eig8gO3w07k+CEWiPHCVenpC8tzuND5MCCMlBQO+uMBZEHosa++Iw2BZ1pR18U6XEMjs7jymvsTLxSHtAwuRiTD5QY8pSHQ9ZwJQa///C6QKTxHUrosHazmct/lNi9oppTRzdCIeh4XuMmgwMW/z6VXP0GzKGKeXN2dag0Crw3IbYsXckRwCTV4D4gTi5+aTPKq9KHGrleNV9W9H+w2mfAltPTfExAW8WI61wz3l2rAtOgQTKj52cmEBT3fNguDKBi2mv7TFzaBt9Z/L9TymAr8qQfhx7yklkEEBi1BC7Ql+GruImobklTNpe1Y3BlP71up/iQhuVu9j/zStsFhd3kTvtO/UEIekVc5K1o3qGCztU5T5YyLAncbV8Z3ymb71bbZ0hCIl7LT64gXQ3eEPt+HAUjCQH/lCboRmAFUXIUgYnxwqChdWnXkrVrN//vKRnkSVy2 HjI9O/lO zoamvdOtpGKTZs6/IojLlH/pGwvhRkeLIxywIYOZB0J7DZKSIikT5hcfo2IoDJk9tFTuSxiU/rjVhUhSOfUfmR8ALiazLZ2+thN9PPY+NTJtd8MnIL7kSHvwl5hDnrSX6/Nl32F+acA/9EnyaPiIiM3hlm54Ixs1513kFwz3Af9mhcWl6ng6yoK1jaZY4DlbNPi6W+UARTAAeREyOx7aJ//IHM95ftzk1vG8AUMSM9dLcBy5zBJZJyOdHh8RthtayOmYnciBTBPRRHv7I3yGhpHi4L+V7wqSq/OBnDDshNuEOnv7DylPdbSjIAwN8UW29V4yEEfiqQE0S4WPwsJEtp0UM+OMB+jcOYKDU5sOj6TyqkKM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andr=C3=A9 Almeida writes: > utf8_load() requests the symbol "utf8_data_table" and then checks if the > requested UTF-8 version is supported. If it's unsupported, it tries to > put the data table using symbol_put(). If an unsupported version is > requested, symbol_put() fails like this: > > kernel BUG at kernel/module/main.c:786! > RIP: 0010:__symbol_put+0x93/0xb0 > Call Trace: > > ? __die_body.cold+0x19/0x27 > ? die+0x2e/0x50 > ? do_trap+0xca/0x110 > ? do_error_trap+0x65/0x80 > ? __symbol_put+0x93/0xb0 > ? exc_invalid_op+0x51/0x70 > ? __symbol_put+0x93/0xb0 > ? asm_exc_invalid_op+0x1a/0x20 > ? __pfx_cmp_name+0x10/0x10 > ? __symbol_put+0x93/0xb0 > ? __symbol_put+0x62/0xb0 > utf8_load+0xf8/0x150 > > That happens because symbol_put() expects the unique string that > identify the symbol, instead of a pointer to the loaded symbol. Fix that > by using such string. > Thanks! I picked only this one via the for-next branch of the unicode tree. No nee= d to resubmit this one with the rest of the series. --=20 Gabriel Krisman Bertazi