From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A1BECE564 for ; Tue, 10 Sep 2024 05:46:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B74938D0019; Tue, 10 Sep 2024 01:46:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFC3E8D0002; Tue, 10 Sep 2024 01:46:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99D208D0019; Tue, 10 Sep 2024 01:46:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 78A8F8D0002 for ; Tue, 10 Sep 2024 01:46:10 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 807391408BC for ; Tue, 10 Sep 2024 05:46:09 +0000 (UTC) X-FDA: 82547742858.11.27B1127 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf19.hostedemail.com (Postfix) with ESMTP id 2DFBC1A0015 for ; Tue, 10 Sep 2024 05:46:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ekoJj6vN; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725947064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4sW+O8uamqYDhKjlucw78ShcyQLJh365cdVxxOXfH3g=; b=WFlvVWdMIPIVnlgJuRrgWlfxCOfsos6yNGugavVXhfbW+npw5Sh2wohHajxmg+JE8Iyca+ BNHgTvA5uHFP3JRFKHkyEfoUs42hmnPu4Me9KvsBkBmugjaXJtHlgS/OPvkbEIHmC2WgqJ lcLZjgJZWzW2gm426fhtkHfxQdk5+2E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725947064; a=rsa-sha256; cv=none; b=yha/BHtriWdMuoXwjTBpCmwjYRjJI342yxcRqt+I0VP0Gb2MlgBQy5stRHqN6Z6YnpGLNg /qcISMyTmIzSEw1vEqmygnypxxiV3lQYSAdg7cQJfO3uWL5sECi0WU49HORdPrJCfKbUXD Aaghve5rUbwgeTEgHDn+QI1qr0OLSn0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ekoJj6vN; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725947167; x=1757483167; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=NuRq0ODXWCIDuyUDFNqAGvTuDp/q2SC0qEs7keqG7B4=; b=ekoJj6vNVTNlDJaRpHhT7h430t5uP7RJv/7ELJjr2pKjuq1oaSpU6iP0 sW9MeuDviuaBqtZ7le4fmnEfHNsgcuo6m9ZNW6JSZ1zCaZUhmqE6KnmFu S0J7tX22ITNqUKHeiZAPDB2kxz7nWVOjm8WI8FbkmUrN/w2g/KPf5u4LM zoKpyiq1eUoteASt5syummCdqGHGVLNmYdH5mn6VEf9m1zVE513wjm2cS 19SUv3OXizjm6fNIZRspx+olGSZ/X0jjXCrTh40lGJyg9bUwao2X9idyL L0yEF+hdgcWzxfoTqrWVTo6yAirwPklE/qjrHRhh9DZ2DhZcIgAw0WS0t w==; X-CSE-ConnectionGUID: 3ZoWIhQAR+Ge3RX+PsH3Tw== X-CSE-MsgGUID: mMBd53eXR6ShTezZu5USiQ== X-IronPort-AV: E=McAfee;i="6700,10204,11190"; a="28453586" X-IronPort-AV: E=Sophos;i="6.10,216,1719903600"; d="scan'208";a="28453586" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2024 22:46:05 -0700 X-CSE-ConnectionGUID: f00Ey9gqRfCHfys9LuYGng== X-CSE-MsgGUID: W0f2nt+wQbuhe4QmCTfbcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,216,1719903600"; d="scan'208";a="66537903" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2024 22:46:03 -0700 From: "Huang, Ying" To: Andrew Morton Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Thomas Gleixner Subject: Re: [linux-next:master 10352/10516] include/linux/mm.h:101:35: error: 'MAX_PHYSMEM_BITS' undeclared In-Reply-To: <20240909204555.ab57c729531c83a0685cfa8e@linux-foundation.org> (Andrew Morton's message of "Mon, 9 Sep 2024 20:45:55 -0700") References: <202409100913.RxkfrKU6-lkp@intel.com> <20240909204555.ab57c729531c83a0685cfa8e@linux-foundation.org> Date: Tue, 10 Sep 2024 13:42:30 +0800 Message-ID: <87wmjkyshl.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: 9kbw4z6dr5tw9ohmion7oibijec8j4xs X-Rspamd-Queue-Id: 2DFBC1A0015 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725947165-809217 X-HE-Meta: U2FsdGVkX1+5F1Sk/h0GsmMkPPo/ANIHXGtXFO5srSOKbGc5xp17ONMWwnNaQ4ZZKkxCR6SRiKg4LnZ3aQ8/SdfNLfTlSQIfggBH3FXIQMExL+nDYuJbgNUS7HPnRXkbeeYQSBBLPVO8XUJKRg0Mn5Mrumo+eCS5YsMmoU/j7i47nMEVG8YqGA+W+4Asmp8OPf6aKUYKi28+ydB7sdUlkqAB3vFeWlZmL+lx36iepg/SOG3R/J73PPmyMnff5f3LW6RBaJpihiTBlSBQydnndwWJh3+r5UI+FDZdvQ9PfaJpMYW+XncmeztzddtUGwFQjhkA70K7mBIdQp+B0K9Yg+ncGK8q2Drf58krRqVzvigQwTwRdFMHUP5QyXEutcAqdkG80zDnSh/rVpJbTylKRKb9wxE4qq9NNC1OtEwRzXVXq98BoQHmZRhNuEPFsIOS4HJBMaaFweLrJdRwriVYrxOmZ7Or/oS6U+EoY82jBz9EoWHkeqnVrNgUFxuXHJqO0LdWZbj5od+fx6h8Acj9TK6/1vpH0oRsmxldAf3PctB+evD3eSM27T8mPChV6ZH+zHVB7GkJ0ls2nRzuDR606xEQWngiX7cqiVHw3dKCA6DjCUc9VZBLGbErHrJLyyfpv9Y5Ln/I+XqO4pws1Foaet4LAJIK4AUbPMq1ytC/EeaMLsk34s7T7/hAZHqsF6OLq+mA/3z1yHAqDVrkeZnasC3BkJo6sJyVygpiNHdNoSKZrzlWAq51g55A3I6KApH/yNpRr2bmpvOy1wvpHWo5L7wnIDIYfZ0shBa+VDxyWkgjApIJIZi8niV0lmasUt0G1vNe3bVEzXHOuswEixaYOgmfBCbLQXCj2S3G2LIrdUyzDMzK7aPe74Oq3zL5UACB3Eun8mZ5YTmvPDc3Cnipz8ZCJfqX+vARMzXACMGKcXMPje/tCPETywO2Qb4F/2sL3OcRBkLsUlh9WUovTU0 zg6K/QRF bx4DMD/UNzzFF4b+zK3W/HDQPYTP8syOO9YFdPwGLYrvH/ILl1jFH1gg6ZL/0w5JWyavVozTrXii0Ayk4EabCilUUK6CF97H0tFAeungV7WVqUTChpcs/D2nNdebWEBR1TgTrbHc8KZ3kW9eYlEo9tnksi3Hhe3uxvW+7xgzTXLtySnDIZyWnbjxdCxLRjGkfk9fI0eI5ho7pB6diR9h38MS6u6DEmbYtUwJ0Z9+pB4Wh1SRhKlcsq+FJpj1DePptDXBOp//3EphLfiVu69UfK6AabKn6ZjJs8nVWvVSGD4qoZDzZdgBA9ugkiJoonqXd3UDu56pcGhuoj+NtVua+zSpprV2Znz529XfbBHSci3ct9Q43KWAHyd51jw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andrew Morton writes: > On Tue, 10 Sep 2024 09:33:48 +0800 kernel test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> head: 100cc857359b5d731407d1038f7e76cd0e871d94 >> commit: 5f445800cbdfc4b4185d496a43dfd78df63d2265 [10352/10516] Merge branch 'mm-everything' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm >> config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240910/202409100913.RxkfrKU6-lkp@intel.com/config) >> compiler: m68k-linux-gcc (GCC) 14.1.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240910/202409100913.RxkfrKU6-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-kbuild-all/202409100913.RxkfrKU6-lkp@intel.com/ >> >> All errors (new ones prefixed by >>): >> >> In file included from include/linux/ioport.h:15, >> from kernel/resource.c:15: >> kernel/resource.c: In function 'gfr_start': >> >> include/linux/mm.h:101:35: error: 'MAX_PHYSMEM_BITS' undeclared (first use in this function) >> 101 | # define PHYSMEM_END ((1ULL << MAX_PHYSMEM_BITS) - 1) >> | ^~~~~~~~~~~~~~~~ >> include/linux/minmax.h:93:38: note: in definition of macro '__cmp_once_unique' >> 93 | ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) >> | ^ > > Thanks. "resource, kunit: add test case for region_intersects" is the culprit. Yes. Although the definition in include/linux/mm.h introduced in commit ea72ce5da228 ("x86/kaslr: Expose and use the end of the physical memory address space") doesn't compile on m68k. There are no users of PHYSMEM_END before patch "resource, kunit: add test case for region_intersects". This can be fixed via the following patch. ---------------------------------8<-------------------------------------- >From 00d176e0cd07e3df1ea37a5e56ca576c819b585a Mon Sep 17 00:00:00 2001 From: Huang Ying Date: Tue, 10 Sep 2024 13:20:40 +0800 Subject: [PATCH] mm: fix PHYSMEM_END build error on m68k 0Day build system reported build error on m68k architecture for missing the definition of MAX_PHYSMEM_BITS when defining PHYSMEM_END. Fixed it via making PHYSMEM_END definition depends on MAX_PHYSMEM_BITS definition conditionally. Signed-off-by: "Huang, Ying" Cc: Thomas Gleixner Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202409100913.RxkfrKU6-lkp@intel.com/ --- include/linux/mm.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 147073601716..62bb7e7e0a17 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -98,7 +98,11 @@ extern int mmap_rnd_compat_bits __read_mostly; #endif #ifndef PHYSMEM_END -# define PHYSMEM_END ((1ULL << MAX_PHYSMEM_BITS) - 1) +# ifdef MAX_PHYSMEM_BITS +# define PHYSMEM_END ((1ULL << MAX_PHYSMEM_BITS) - 1) +# else +# define PHYSMEM_END (-1ULL) +# endif #endif #include -- 2.39.2