From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C28CEFC5D for ; Wed, 9 Oct 2024 09:53:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A54596B00BC; Wed, 9 Oct 2024 05:53:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DAF46B00CC; Wed, 9 Oct 2024 05:53:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 855CF6B00D3; Wed, 9 Oct 2024 05:53:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6085C6B00BC for ; Wed, 9 Oct 2024 05:53:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8C1891A115E for ; Wed, 9 Oct 2024 09:53:49 +0000 (UTC) X-FDA: 82653602346.01.058DD99 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 3E44340008 for ; Wed, 9 Oct 2024 09:53:50 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=wTv2PEY2; dkim=pass header.d=linutronix.de header.s=2020e header.b=xfV2vvxK; spf=pass (imf17.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728467495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V6wmZgNbeW2JvNpgS3a2aAd/BziZrZJXCOv9QKhyUbc=; b=FjjTTX21rSUqnFFGBMTYKEWwV+MRa9Y5pvldgiH7upfKY7Vdyke5K5dsxTisJN4eK4T/2U vMj/GhDJHNBVbCyBseLXe9UMpr/+nKcQ68Yr9GD2lSDdjJSbJm6mjIWBlnoszC8AWtHih/ px/lnLrLCSGFzaldboSo9LfPnKZei0g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728467495; a=rsa-sha256; cv=none; b=CkXoZ0ydQX+GVYwPNgy3ujiuVeolhU1W+kMD/WiAQtuGNTnbCFF4ZkuRwo7+KGwPyifk6K rCdmiz90QOGh7Lz3eGuzOEeiGsJAcOg1GfVH/yowM/V9UpR8FRD46HEF4wYOWm8shdTw5l gW+JJ19xOTxAZ+O76gX92c2QC+Qki+U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=wTv2PEY2; dkim=pass header.d=linutronix.de header.s=2020e header.b=xfV2vvxK; spf=pass (imf17.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1728467628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V6wmZgNbeW2JvNpgS3a2aAd/BziZrZJXCOv9QKhyUbc=; b=wTv2PEY2kWMLaAJKXKiBpf9A5u9zDq+2sj7mN3+o5DZzQXNoig2aWKyM9WUX6vo1MMwo4m JZVwAc5nAGBXC43dXPfUj1ciKSZPvpAvpH5eFOxpRy1cxdUAh1qHX1nPeMiWtaPYqB0l5m BOAd7tAFfY48yqstgeQZv1zSU8BiVaRhefAneA/3rfdFXKGqY7MzNNRdBwdsP4nq/Ktlks uhQzW0aOiPFdgdQg3+k5eu/cRsXQWsX/IfxyiqxViDThlm01uFvyGlT2OAqJtFQnoCq1es voVbesIDlGVMNXv/Sdlq0R/s4AE3Kg2hQ2Az8a9wSOJJKY+U++mUynZVc7gzpw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1728467628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V6wmZgNbeW2JvNpgS3a2aAd/BziZrZJXCOv9QKhyUbc=; b=xfV2vvxKqwHS3e2NZf+o4Ycj3Rylk+sm6QJKNHUG69+ZDGMo9G6Yy6aQV4AKWWDur5Dmz7 4uVMoCJvvWoSNSDw== To: Vincenzo Frascino , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Vincenzo Frascino , Andy Lutomirski , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h In-Reply-To: <20241003152910.3287259-3-vincenzo.frascino@arm.com> References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> Date: Wed, 09 Oct 2024 11:53:47 +0200 Message-ID: <87wmihr49g.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3E44340008 X-Stat-Signature: qofy961imujf9758teoes6knzmgrte8g X-HE-Tag: 1728467630-738615 X-HE-Meta: U2FsdGVkX1+q6Fl7pSZWwfSly7Tng0thueCgbejLvVYOIDRHF4GzDPjgz2srcEO1Jxeu45tzUGGQlq3ymp7Za95y3Zy+OgmQrMzT6gmxwtgnG0XAKljQ5ppDQjnMx93/knyku4Noo6LkDwUoVc+T9bEuFMLBS42OCIp7KUTVwOHDEXjZbD9B/qT/SnVhxVhaSfNXMEdrAHeHDhLeOC6SoZJeyphSMl76ClXV3G8mMPzcHDeySHEyf4W+oLZNgAouQRt6i7Q5LQExhvZwAg2Mv48g76KF6OalFiwRzQn8zzTLYdbcapXbv48EPxp16yAhQvJ6dYNSB7dq6K2y5CAZKqA+UvkFCddezoySmtUNJV/9AVnc1vmzoIyjzUlfqJDvi3gnb6qSegtEDxbLWeNr0BpNF+EAaXrqGRhG0tQ8GfVnuf3XkJAbS3fAIrp9OkLDpbZ2tbtXejcnHr8IfcEQOQKuGJ3XsZBYajB0bMZ9a+eZjK2w9xvQ5ZIyEyu+Rvr9Ze3BYzedRtIjokOu0rKIpNJwtRv98NgGhFsMhH1IuenosVbWJ7H/zdIajqxMVBo/UhxP0Z7QozsUn8EuUIXp07G8xlDe/MMi9E1BRoT58gdGWnFaQsUEN68CQon64MCQULi/koc7n93PxLUPCVLjOvo5RiRdFlg8+jN7a82tU2bW2/Yxf37/rTyOKlaMOsgOBMXCae+0A5PY0QUcK0XiOuVOFfiYkBFGIbxF9P144H1w/H9g7MKyeZKPA4JDsnBwwOwq0Eaij7a6+qmo01dQ+rsjy+QnU/pRNbTYLSaxu/L+Jdd0uAsmGNOjipaWtEnWOGkGvPnO34vTp05WJotVoYqj5bA6f1fWoLX6rPf7z8cE6LigK4Ghnvm5HU0pMCSc7OZReEukjdLBEHZf5/Dji47UHCWq74Y2st82n/kv2CkujkMTaWNEMd3LR+Fw4pN5mniy18VDeDtaA3KMaXf aKIpbMSY /vVchfRxzlqZtpyRmtjS6EpYfEe7a8aZZNf8+Tic7+srq4BzmWdcqUuoTeSK1txsuKIh8dD93yNXp47DxVH9RdKeTgy8M/ZQhSctp6I+SDknp5NiuFcHWef6MhqFZkFCQ9TeRu9V9HAdnYRPjQB9frzlQBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote: > The VDSO implementation includes headers from outside of the > vdso/ namespace. > > Introduce vdso/page.h to make sure that the generic library > uses only the allowed namespace. > > Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when > it supports 64-bit phys_addr_t we might end up in situation in which > the We end up with nothing. > top 32 bit are cleared. To prevent this issue this patch provides > separate macros for PAGE_MASK. 'this patch' is redundant information. git grep 'This patch' Documentation/process/ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef __VDSO_PAGE_H > +#define __VDSO_PAGE_H > + > +#include > + > +/* > + * PAGE_SHIFT determines the page size. > + * > + * Note: This definition is required because PAGE_SHIFT is used > + * in several places throuout the codebase. > + */ > +#define PAGE_SHIFT CONFIG_PAGE_SHIFT > + > +#define PAGE_SIZE (_AC(1,UL) << CONFIG_PAGE_SHIFT) > + > +#if defined(CONFIG_PHYS_ADDR_T_64BIT) > +#define PAGE_MASK (~((1 << CONFIG_PAGE_SHIFT) - 1)) > +#else > +#define PAGE_MASK (~(PAGE_SIZE-1)) #define PAGE_MASK (~(PAGE_SIZE - 1)) please. Thanks, tglx