From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD5B1D1D89A for ; Tue, 15 Oct 2024 18:35:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 657296B0089; Tue, 15 Oct 2024 14:35:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6061C6B008C; Tue, 15 Oct 2024 14:35:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A71F6B0092; Tue, 15 Oct 2024 14:35:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2B51F6B0089 for ; Tue, 15 Oct 2024 14:35:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BECA51C71D7 for ; Tue, 15 Oct 2024 18:35:15 +0000 (UTC) X-FDA: 82676689200.21.8D707C6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id F17A0140015 for ; Tue, 15 Oct 2024 18:35:17 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OYks4C3z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=d2oXo14o; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OYks4C3z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=d2oXo14o; spf=pass (imf26.hostedemail.com: domain of krisman@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=krisman@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729017133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ZstxhVk9QOrcNizGJVVQwN2mCzQEZY3vaa7cVcnk/k=; b=1qo+Ag+1d9LVpObnwz9SUP2VBDSXe8W+OYW20EMgjPlYdeSTuZF77KD5U61VS3/5OTEN6B ASt+3EYtB91ErdWqsJhjJMUgCqfMfz5gSoxS+OIrxJJ/aczp6NWgzM8AFHMbR1fbmYa7FR r1EdAXFfufLfmZ03IJ7t3KNqS9hyLqE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OYks4C3z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=d2oXo14o; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OYks4C3z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=d2oXo14o; spf=pass (imf26.hostedemail.com: domain of krisman@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=krisman@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729017133; a=rsa-sha256; cv=none; b=49PxQ6w5HvQGdUzoGDzBw0qEfr7TKL9+YHxl8lJwgpqdz2SY5htItk/kLlDtNfvTs9Cvxn 5qEtx8kJf0S+mLwauam1+tEdSyvQ9csKOtqrCp3P23kQ4/VHkIqUSOOvbda/Aw+pnAt9/e 7siC2ua51WwOorOXJzsbM5It2+jR4Ig= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1CC5721B9B; Tue, 15 Oct 2024 18:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729017322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ZstxhVk9QOrcNizGJVVQwN2mCzQEZY3vaa7cVcnk/k=; b=OYks4C3zNQfaTB0uJRa597TOaL1xPd5XsUl+zquiDOI2keIPIA9VPl6RcMRUE5tqXmdLD8 hKx+QhgkSbGqJoce02xRLEUwICxqRlq7xUN7uHRPrvCKgbE0u1gKCCOcqe+WWu9HRyaxVr yxat4EWnlUyYQBgKmc2ik2G8QsDcADI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729017322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ZstxhVk9QOrcNizGJVVQwN2mCzQEZY3vaa7cVcnk/k=; b=d2oXo14ovteimlXL6Ac5e5DJ+Di4YEbS/EkR5bQgMaxxV7+/gVFD4ffVwwISEs26y+Qz/b ryOd5Kyr966hXdDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1729017322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ZstxhVk9QOrcNizGJVVQwN2mCzQEZY3vaa7cVcnk/k=; b=OYks4C3zNQfaTB0uJRa597TOaL1xPd5XsUl+zquiDOI2keIPIA9VPl6RcMRUE5tqXmdLD8 hKx+QhgkSbGqJoce02xRLEUwICxqRlq7xUN7uHRPrvCKgbE0u1gKCCOcqe+WWu9HRyaxVr yxat4EWnlUyYQBgKmc2ik2G8QsDcADI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1729017322; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ZstxhVk9QOrcNizGJVVQwN2mCzQEZY3vaa7cVcnk/k=; b=d2oXo14ovteimlXL6Ac5e5DJ+Di4YEbS/EkR5bQgMaxxV7+/gVFD4ffVwwISEs26y+Qz/b ryOd5Kyr966hXdDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BFF8D13A53; Tue, 15 Oct 2024 18:35:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id T6M/J+m1DmeoTQAAD6G6ig (envelope-from ); Tue, 15 Oct 2024 18:35:21 +0000 From: Gabriel Krisman Bertazi To: =?utf-8?Q?Andr=C3=A9?= Almeida Cc: Gabriel Krisman Bertazi , Alexander Viro , Christian Brauner , Jan Kara , Theodore Ts'o , Andreas Dilger , Hugh Dickins , Andrew Morton , Jonathan Corbet , smcv@collabora.com, kernel-dev@igalia.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 07/10] tmpfs: Add casefold lookup support In-Reply-To: <20241010-tonyk-tmpfs-v6-7-79f0ae02e4c8@igalia.com> (=?utf-8?Q?=22Andr=C3=A9?= Almeida"'s message of "Thu, 10 Oct 2024 16:39:42 -0300") References: <20241010-tonyk-tmpfs-v6-0-79f0ae02e4c8@igalia.com> <20241010-tonyk-tmpfs-v6-7-79f0ae02e4c8@igalia.com> Date: Tue, 15 Oct 2024 14:35:20 -0400 Message-ID: <87wmi9qknr.fsf@mailhost.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F17A0140015 X-Stat-Signature: f9gfidzxx141uy1uy3jnzab94h6xoe9q X-Rspam-User: X-HE-Tag: 1729017317-630952 X-HE-Meta: U2FsdGVkX1//oyv8z0m0SRAYUYf27OMxCH4AJ+/VAyAOsX/4ZsqdMy6wKmgjJl/Xr4/dATeUPPoTuYeA8RWStt5XKJhGuCL9VdjI1YlBIBkh+nhwPGl9vZC1vbBfhOiHJwgYefmN6RjaB7GZgwh871bzCv/Zo1TIUeQcZ+Ivag0hU7Pri9Q4o8z4r854xMSVq16vrXzZ7faxMEpHrof7DB6DbG5+NgPa3iw9Uf8qprlVeolz+FlEtYr3UDRW94vrsyqFNW86YUrtg+IF+Acx9zkfCt1N38CRwliQk0bpyB34Jmfvpdp6ZAI+Cp/1m+ucWpEPmZJX8C3wTsw8YwfwQ6H5iO/emYX1tgkNsWtPIyjKdRgxwBvibYWM3WmwwOdQeoX4TOu20SzRhSrwBeuniaA53lWw0ggrTYXbq83yLj2ZYiiVL91H4mQp+m43JLJwIImLKlAziyYK/rlKReMKGNTpHvtdmZcRTxbIBsD/QpiXSeE79nqx1aLTwJIJJf1D5dyoCf1ozH0D/YzdjGThYWSbRFoRrHsRUXoXrF5wOQ1Lk4Z6QB49YOEzHQa35q8HjT0/D9JH3nCHpxPen2byvPtZ0pvwUzOWrb/U9qXJMWcMbvkhIYvNuLEVrvTmTGkS2iNbLWs0aIhah1fCDtefM/FrktSMRnHLXPXtWHg90d+s+OxUVLpYAMm0o+LdVmIG3NIqwO4hKSJAO32hpVncNn69m2F7887s+Gx4XStVY136Bcf9ho1Txex76KdIz0Co2geOuwzHiUZo0aJ2pWKZsQf1SHktr4JeXpKOz4J9KCLggzCl5SKlHuRN5IfJDfN3FQ6g8M5sLpRU6t3lUv78+7dtKfGxJP2a5KkpYptaNh3K6l+vjvyy0MBUhoEcjDP5kyvIvf0mGGlhkJw8qw8z23nSWQ6VHMrb0bzREL6flhileK1krXONZUi/lVxA65Xhps/1uZhHrua7+2goI2k CLtt/bDw dLuUqokzRXgDERd9asTAQa9YnpjHnjQa7cbK9RhSrkwuds1eeHfzNKLf7SO3SZIbS6p+cUlGNbfZVzvnTBL08K2cvBQ1gLpB1luGXx0U2qt8Mo7HDRYt7D/sim9O0LPI8+m/CyRJVpTSQaZE5Za8+/WSXiaMtDkPeQ3D8JlTZtUXvQKU6pM4zugOT9i+YvAYW5NHRRkNQODDDMtyx/1PIEMXtCrkgOkiArqvdJNm2+7hYxRpcA+cVTS9VZ1hp5gvxFKie4huhujxa9RNr1+Qmok1OH1y4qer/djio6PYpZA0mgmqozvRsvnFbcWDGDaA8TWKZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andr=C3=A9 Almeida writes: > @@ -4663,10 +4756,24 @@ static int shmem_fill_super(struct super_block *s= b, struct fs_context *fc) > sb->s_export_op =3D &shmem_export_ops; > sb->s_flags |=3D SB_NOSEC | SB_I_VERSION; >=20=20 > - sb->s_d_op =3D &simple_dentry_operations; > + if (!ctx->encoding && ctx->strict_encoding) { > + pr_err("tmpfs: strict_encoding option without encoding is forbidden\n"= ); > + error =3D -EINVAL; > + goto failed; > + } > + > +#if IS_ENABLED(CONFIG_UNICODE) > + if (ctx->encoding) { > + sb->s_encoding =3D ctx->encoding; > + sb->s_d_op =3D &shmem_ci_dentry_ops; > + if (ctx->strict_encoding) > + sb->s_encoding_flags =3D SB_ENC_STRICT_MODE_FL; > + } > +#endif Actually... The previous patch moved the dentry ops configuration for the !casefolded c= ase to this place, only for thsi patch to remove it. Drop patch 6, instead? > + > #else > sb->s_flags |=3D SB_NOUSER; > -#endif > +#endif /* CONFIG_TMPFS */ > sbinfo->max_blocks =3D ctx->blocks; > sbinfo->max_inodes =3D ctx->inodes; > sbinfo->free_ispace =3D sbinfo->max_inodes * BOGO_INODE_SIZE; > @@ -4940,6 +5047,8 @@ int shmem_init_fs_context(struct fs_context *fc) > ctx->uid =3D current_fsuid(); > ctx->gid =3D current_fsgid(); >=20=20 > + ctx->encoding =3D NULL; > + > fc->fs_private =3D ctx; > fc->ops =3D &shmem_fs_context_ops; > return 0; --=20 Gabriel Krisman Bertazi