From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198]) by kanga.kvack.org (Postfix) with ESMTP id 211296B000C for ; Fri, 23 Feb 2018 19:52:35 -0500 (EST) Received: by mail-pf0-f198.google.com with SMTP id u65so5003472pfd.7 for ; Fri, 23 Feb 2018 16:52:35 -0800 (PST) Received: from mga18.intel.com (mga18.intel.com. [134.134.136.126]) by mx.google.com with ESMTPS id 3-v6si2602715plx.463.2018.02.23.16.52.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2018 16:52:34 -0800 (PST) From: "Huang\, Ying" Subject: Re: [PATCH][mm-next] mm, swap: make bool enable_vma_readahead and function swap_vma_readahead static References: <20180223164852.5159-1-colin.king@canonical.com> Date: Sat, 24 Feb 2018 08:52:32 +0800 In-Reply-To: <20180223164852.5159-1-colin.king@canonical.com> (Colin King's message of "Fri, 23 Feb 2018 16:48:52 +0000") Message-ID: <87vaen2oq7.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Sender: owner-linux-mm@kvack.org List-ID: To: Colin King Cc: Andrew Morton , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin King writes: > From: Colin Ian King > > The bool enable_vma_readahead and function swap_vma_readahead are local > to the source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > mm/swap_state.c:41:6: warning: symbol 'enable_vma_readahead' was not > declared. Should it be static? > mm/swap_state.c:742:13: warning: symbol 'swap_vma_readahead' was not > declared. Should it be static? > > Signed-off-by: Colin Ian King Acked-by: "Huang, Ying" > --- > mm/swap_state.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/swap_state.c b/mm/swap_state.c > index 8dde719e973c..f3952138f01d 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -38,7 +38,7 @@ static const struct address_space_operations swap_aops = { > > struct address_space *swapper_spaces[MAX_SWAPFILES] __read_mostly; > static unsigned int nr_swapper_spaces[MAX_SWAPFILES] __read_mostly; > -bool enable_vma_readahead __read_mostly = true; > +static bool enable_vma_readahead __read_mostly = true; > > #define SWAP_RA_WIN_SHIFT (PAGE_SHIFT / 2) > #define SWAP_RA_HITS_MASK ((1UL << SWAP_RA_WIN_SHIFT) - 1) > @@ -739,8 +739,8 @@ static void swap_ra_info(struct vm_fault *vmf, > pte_unmap(orig_pte); > } > > -struct page *swap_vma_readahead(swp_entry_t fentry, gfp_t gfp_mask, > - struct vm_fault *vmf) > +static struct page *swap_vma_readahead(swp_entry_t fentry, gfp_t gfp_mask, > + struct vm_fault *vmf) > { > struct blk_plug plug; > struct vm_area_struct *vma = vmf->vma; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org