From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A0D5C4361B for ; Thu, 17 Dec 2020 16:58:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F46A233A0 for ; Thu, 17 Dec 2020 16:58:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F46A233A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 709EC6B006C; Thu, 17 Dec 2020 11:58:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BB4B6B0070; Thu, 17 Dec 2020 11:58:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D1286B0071; Thu, 17 Dec 2020 11:58:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 476946B006C for ; Thu, 17 Dec 2020 11:58:32 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E90DA8249980 for ; Thu, 17 Dec 2020 16:58:31 +0000 (UTC) X-FDA: 77603382822.19.dog33_4a1162827436 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id B3A631AD1AD for ; Thu, 17 Dec 2020 16:58:31 +0000 (UTC) X-HE-Tag: dog33_4a1162827436 X-Filterd-Recvd-Size: 3234 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Dec 2020 16:58:31 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1608224308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BfeG9stxOsSpjRYXj7Js+sXxnOSrg6f7PFi1tBPvTk4=; b=gBt8MjRwIBoZoOeRr2iv95diwya5Pn0IUF0cU39dmJIhU7C9g+sbPkGpiPSqGHzNVwKtDS Xebun5owJ8k+ANh+8c0GWB+05QGhsw5KAcBBaS6D+JrDVzMI/TKSy6DG+w/+ZCUJmtTY5D +i8C5pHMQYcdLgBTjcVfO3mGh8TlhZc8gB9nhauvVIBqeUXg5M+/0ysikjITOcokAeDkJd L+YVwS6Fdxdeuz2l35ol/TuD+YD5rlv/Pv0DupbkIoORNb84qEnTPe1nB+J9E3JjQtUabc usFUtM5tTrGUzWYXB2IJZs/PvBxPNuAIYQ0XIdXEbKQ/LoKy3j0BoiipJxmPQA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1608224308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BfeG9stxOsSpjRYXj7Js+sXxnOSrg6f7PFi1tBPvTk4=; b=dn3W9hQ1peESFmJ2swDmnwnBERH9a1KMBLetWpglvwv9bYVzv/pp+RbTDpNLyrNb0+nCvp vsP9GutiQJM3cYDg== To: ira.weiny@intel.com, Ingo Molnar , Borislav Petkov , Andy Lutomirski , Peter Zijlstra , Dave Hansen Cc: Ira Weiny , x86@kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Fenghua Yu , linux-doc@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Dan Williams , Greg KH Subject: Re: [PATCH V3.1] entry: Pass irqentry_state_t by reference In-Reply-To: <20201124060956.1405768-1-ira.weiny@intel.com> References: <20201106232908.364581-6-ira.weiny@intel.com> <20201124060956.1405768-1-ira.weiny@intel.com> Date: Thu, 17 Dec 2020 17:58:28 +0100 Message-ID: <87v9d0qsi3.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 23 2020 at 22:09, ira weiny wrote: > From: Ira Weiny > > Currently struct irqentry_state_t only contains a single bool value > which makes passing it by value is reasonable. However, future patches > add information to this struct. This includes the PKRS thread state, > included in this series, as well as information to store kmap reference > tracking and PKS global state outside this series. In total, we > anticipate 2 new 32 bit fields and an integer field to be added to the > struct beyond the existing bool value. Well yes, but why can't you provide at least in the comment section below the '---' a pointer to the latest version of this reference muck and PKS global state if you can't explain at least the concept of the two things here? It's one thing that you anticipate something but a different thing whether it's the right thing to do. Thanks, tglx