From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DD4EB64DD for ; Tue, 25 Jul 2023 00:24:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B1B76B0071; Mon, 24 Jul 2023 20:24:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 361986B0074; Mon, 24 Jul 2023 20:24:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DBAE6B0075; Mon, 24 Jul 2023 20:24:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0FE1C6B0071 for ; Mon, 24 Jul 2023 20:24:02 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CCF2480BEB for ; Tue, 25 Jul 2023 00:24:01 +0000 (UTC) X-FDA: 81048236682.29.44ADE12 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2060.outbound.protection.outlook.com [40.107.220.60]) by imf25.hostedemail.com (Postfix) with ESMTP id D2A9DA0003 for ; Tue, 25 Jul 2023 00:23:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=mdsDlMRO; spf=pass (imf25.hostedemail.com: domain of apopple@nvidia.com designates 40.107.220.60 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1690244638; a=rsa-sha256; cv=pass; b=rn+/9TycsQAoKL/9idvZO4TlFYFu1NQLfEcgaqDGf8MUKt/Kzgk8V7i+yOUMA1L8THJF5Z JlQa55B4Rn2pFuUqmpq/clLe9okp5OkVbwcGdxEyR9bPo1zM/pcOlsIS/6XRVhUjRM11NE bH7ChHYPschHB+LIW4VlqTYFAnloK0I= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=mdsDlMRO; spf=pass (imf25.hostedemail.com: domain of apopple@nvidia.com designates 40.107.220.60 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690244638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ku6MUz4MWhYaOMPRiAjUDVhN6Zt5HLCAWnUljt2NgLo=; b=ktO/FZuoagnJBXyXlG+H3GzuI9UXHWya3USKSmIPSlpBLNZxMmfegTYh6QJ2+cbyTQ5pkq tfBzFVjkAkOsdZVNKjwnPUEhV1qymHo/RX9DdATS5wTvscbHxyhbkSRcG0SLTmbaK+1XWP MRB2F3V5p7yEdMTWWOCrbukvqGRMcjw= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQshaVJo+Imw5FT/PvX0SjTY1S/D5JTwn+kMFtJBELz5ci1VIEATPDbjWlA3X+dA7fTNk4byOnlnUfMzEHUyYXnaxNHe3VLDDGu/7TiHxfSVIQmQAdljcibGiQ6+PwCQopPpXemQq2r94D0nIpoeXsTkLY1w44Nx/UzbtwtEOv2npAR0nPKO6OW+qwSPNehOO4NvmjyzGXEdgn8KfxMoAag6PiKSu1PVNkkyBZb3CDn3x2gW09zNUXC5TtuLGPl7ky1I+K/AV6OwGlI1a00wb3THQ2DFq4hFeo456OXovbVtPJ/7Di6hd4+870Y8u2wg7/3tRjtXjw1e1dXR0fm6bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ku6MUz4MWhYaOMPRiAjUDVhN6Zt5HLCAWnUljt2NgLo=; b=JQ25lgqCSeh5MPALkOkA9kQ0tNXkhLmMn7HgUpgZK4hrrWV0i1b0kgPGYyZb0Z2EwWcsTBjKh+tAxcCULGXKA04b7KCw4Z33UBJ2Mk2nb6FguIqF3OaUpuihgYFPWt0zgmZFcuC9rVUlm01wf0cc89AxS7Xjmty3/aK9BmMwryPUpcL7trPAnGrz1EfJ7GjCOg9OFQH9TzYHsi0Lgg/CV8XPJWQOqNW+DACdDseULXI2BDkJL0vZ9fqFMYKSXivPmJISRJzlqlrEJArb8uR/AXqCmW2MNPB5S85F3OTA0K3eXaToY+duCvA8RTZ6geTwzEb0hEDauRtifyFY3uQg0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ku6MUz4MWhYaOMPRiAjUDVhN6Zt5HLCAWnUljt2NgLo=; b=mdsDlMRO0DBL2q0erXUI795RiQl6DMQUds39J3UEyLbK23zeMbizJDRR0f//NbcQsDUd6EQT9gc71FmrWEq4tayoEuJCrBXIClK6yGe7/50QzWOauI779HblHYX8YsExnIfxSgQb1TjbHGzbjmQ/13eoFXUNL9Nb8/roFp3wCTu2ZoJH1XsgbJkLc5l24RwVDsnZr0WbRVykDNQps2Qin8itswWkBx90aYierPwu88n07Zu2904e5PsWiA8xeB1WLr4faD84USCBMZZwIomszGKrK0cSKSNVMh51sP7hkjZKU17wvlVyWSYzy+JrQntOe2IIpSjRgmaQ7pbCYxLBFg== Received: from DM6PR12MB3179.namprd12.prod.outlook.com (2603:10b6:5:183::18) by SJ0PR12MB5405.namprd12.prod.outlook.com (2603:10b6:a03:3af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Tue, 25 Jul 2023 00:23:55 +0000 Received: from DM6PR12MB3179.namprd12.prod.outlook.com ([fe80::3eb6:cda8:4a56:25fe]) by DM6PR12MB3179.namprd12.prod.outlook.com ([fe80::3eb6:cda8:4a56:25fe%7]) with mapi id 15.20.6609.031; Tue, 25 Jul 2023 00:23:54 +0000 References: <8f293bb51a423afa71ddc3ba46e9f323ee9ffbc7.1689768831.git-series.apopple@nvidia.com> <20230719225105.1934-1-sj@kernel.org> <877cqvl7vr.fsf@nvdebian.thelocal> User-agent: mu4e 1.8.13; emacs 28.2 From: Alistair Popple To: Luis Chamberlain Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, Pankaj Raghav , SeongJae Park , kevin.tian@intel.com, x86@kernel.org, ajd@linux.ibm.com, kvm@vger.kernel.org, linux-mm@kvack.org, catalin.marinas@arm.com, seanjc@google.com, will@kernel.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, zhi.wang.linux@gmail.com, jgg@ziepe.ca, iommu@lists.linux.dev, nicolinc@nvidia.com, jhubbard@nvidia.com, fbarrat@linux.ibm.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com Subject: Re: [PATCH v2 3/5] mmu_notifiers: Call invalidate_range() when invalidating TLBs Date: Tue, 25 Jul 2023 10:20:52 +1000 In-reply-to: Message-ID: <87v8e8zvmz.fsf@nvdebian.thelocal> Content-Type: text/plain X-ClientProxiedBy: SY6PR01CA0124.ausprd01.prod.outlook.com (2603:10c6:10:1b8::17) To DM6PR12MB3179.namprd12.prod.outlook.com (2603:10b6:5:183::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB3179:EE_|SJ0PR12MB5405:EE_ X-MS-Office365-Filtering-Correlation-Id: f49de129-5bb2-4bb7-a2a6-08db8ca56d99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S4kV4QoyxWeJb12KnNIxvGW2EgcWAB4DcWd8MnqcX5Ow77pu+WNj0mqYhoDaSOvEx688pjOalI0g3D69B1b5S3pJDpucMVbLIM5xDSW3DDbPkitABTHFRmmxEBPbbchrPEuEp29VBu5gX+Fji3Kd9pyybSWspIE2b59MqtI8K/eA0AUCnuDtpXew2ZYCXqN+LtR5ZS6iOr4+XIdXHWGo2pWvOzYuL3yv4RcqZiyc6Mu/4iT6+zWkTBaNOiMyM9p9w4vwJjSQ6S6auhGwvkoNOJI4azOMdTOKNk0erjctx47pxsJDEnYRUHc6pec0cnhTFWx2miMAr7FFXk1hmeIj/qSotl5Ct9yuEl78Jkxt4nI+AEOG3QzaU21kWHFF3UyoXy54iLeUXQzT7zDtA1ACbihsJX6EHZuSDZqEaBVc8n1nJI06XZvconfz40/SD6XcOrb8A8c1n1zNUBcfkgdjK4Pi+rSeqfmkMT0anCle7Hw2ef64r3/YGYHlqbLryv8BZPxOEqcREM9bjx6PILY76VgcS7WdrXHoUncswyis3epNqj00f7WEm4TKreeJw1wcfRA0WaXaVNxRh9wwgasvr5t9vYaGF8vH+C6v8orLTrU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3179.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(346002)(396003)(136003)(376002)(451199021)(5660300002)(83380400001)(2906002)(7416002)(8676002)(8936002)(38100700002)(54906003)(966005)(6486002)(6506007)(478600001)(26005)(186003)(41300700001)(6512007)(86362001)(66556008)(9686003)(66476007)(6916009)(4326008)(316002)(66946007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZyENK2BIcQ5IWgp+X9tHTNXPyEU2ibIZKb/CxXI7KPjGUXl2e1C2NjDvWLEy?= =?us-ascii?Q?FCE7ql9oHYZnGFD7yPmqjKzdjlGs5nxc0B/2+1/78nTSY+PXPzsmedG1U2tY?= =?us-ascii?Q?DvUsvPk90g7GOec06g20huyXnTlkyFZvqKG7wynGda5SpiSsVNy//xbKKmFZ?= =?us-ascii?Q?4fVZkz195vhwdNJfyTeMiroNal2tPv7oyk+dypUhWTBO+nmm/Faf3afCyGle?= =?us-ascii?Q?OaiDn9FjxPf7A/27VlZnDJjQjyO/fexi3lCnVV8U/pKbm7hvPGY/BllJmM8G?= =?us-ascii?Q?2eOBjFGGuQ1EMorDmCL7tfIr+ub2FOYH49AOsGznIeT72IXfNLGVhvmprD0+?= =?us-ascii?Q?fFE7sEfz7tVuivNsGnJGsIfT92Ty6uKfBXwZ9z/UQUZPET9RSvxunw0XwMtx?= =?us-ascii?Q?QGQfUpC4EptsRoglaoOSIYmlUmRcNcEYGrgDwb7d88tkEtkiWYO8atgzsPzQ?= =?us-ascii?Q?XQLG/fCAxX7nc+J2TNWud49o1zbXaaiWco/bBQn0AEspmz3iS+Z6cdBrPViB?= =?us-ascii?Q?zR9zQGdjqGBFp4h7K7oZl78p0tgoUlGn7nKuJzEqsDUlo+crpHXEoo7YRFYo?= =?us-ascii?Q?V7pI73iJpwdKBDo+Vv9ryW/xjGu6fYKKvTEUSpwOr5Hd21gBFpb9lY/jjOxP?= =?us-ascii?Q?aPUoiEH3y5Bi/hiPSf4MdeEN9kf+G7MtUTZg+7f9u4/WylIrqMqWudmaOsvR?= =?us-ascii?Q?e002RKAENuJk9uJ7rG3ZkSRLGzNbtcRI/Y9IM3eJvpiRkHwqfpK+YMp3Ubdk?= =?us-ascii?Q?2r55Bv+ixReWr0L2So9UjZZVYmHiRBpZmxXfHYO5RwlHo8EEMVZvs4d7+HZs?= =?us-ascii?Q?Rz3UnkBnwXmmI89M7T6XhHnJYvU9crECnHqPA5QYuQj6uh6JOdbqOGJdFJce?= =?us-ascii?Q?BUoQEw0dgszYgqG+u11LJ4TKPxdFdszj49y55tEKwVwugjvfc4s6JVGoLfdA?= =?us-ascii?Q?x6JbPFmMjOq4xBLt5k//MKiyQX+sHUH0e53UC5JApyJmhbUhFd232DrdvfM9?= =?us-ascii?Q?V2rskMU4Njjco3qKO5Gx85ybYeCc+9qyneJIzalvi0fd+Fl1RX9UcZQVrCmH?= =?us-ascii?Q?76hN2qLIhVud1cwyqJeqJlV34hMTJ2CTBA3+aNfM2yWFDIXvBZDG84GZ1+HK?= =?us-ascii?Q?VbhEgahty7wb+WNBZXeKBBhaRiqOeBH58cytgiU8ZUxZNeiyk/tC6orRSMZs?= =?us-ascii?Q?SKjZAMAsIlxC1nJMqK5GOmlQbO8FmIiUAKzb/yLvGzARhMu7AAn2SENY7TQl?= =?us-ascii?Q?WhGpF2oAsO/Whxg9cRrwB6cRPa7hAmTX86LiIc/hvKCx+FeKgjjAYM6TQHJG?= =?us-ascii?Q?2RJRl/n1sVXTTvIGrLnW9KSSU6hcOrKNWVPBP6B4f1pnxEDmwvAEejfPhZ5W?= =?us-ascii?Q?ynTzvyvS3nwiUKeNhTSwX21JZigGHyyh/6vR+sQHrHEo29GL38/ABjO21srJ?= =?us-ascii?Q?zyod2d5ILmLm1CI7qxzq1zmCSgEGL1jfUlbgrdSdIlDO1Qn6xKiXar475e0q?= =?us-ascii?Q?luHlPvAulu15qyucFAim1QDreiIygQX+AE+Q9Ek8f6da/gEG3gSSgR0vzoHK?= =?us-ascii?Q?EKywRnJG3sP18fYRfnm2tUygPXqLy7J6vmVK60ZE?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f49de129-5bb2-4bb7-a2a6-08db8ca56d99 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3179.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 00:23:54.1641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ReXHcJFhI812pCDjT2afAZrcaKRkKrRr85XtzIEtPfHZTzrKl/Dd8y2PkKPUY8EW4JYPcWveeNVV7H4KOl+Bwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5405 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D2A9DA0003 X-Stat-Signature: i1a7w5mjnsny6a66dyfrw4zbjdksdknn X-Rspam-User: X-HE-Tag: 1690244637-699043 X-HE-Meta: U2FsdGVkX186Vqj8XoAX8QH+i27ZhsghycWHBjyf476f6QcE5VbWFG0Pgw7tMUPuA1TyfYSTEIbIH/O6XLT/IdCnvbU+3pE5CyDtxwad7J9rSypSCkWMVbKvQWwHjTUduvyWBzGKtf/CLcUoZAAeGet19qkA2XsefEPQ/uyZzRu32MkQIw7wb3JgNxwjtQUCcmHePONSos/BtoGyKkZjxtNmme/FFDIy+v4Ex2XhoqNGpYEr/NDfwMLK0i2UZO5c5mybPGc2TgjoqU8CT3KSgT5+iL21+M3nxn121keiQfyPavH59PZWfyc5Io5+XtccoRs2y2Ivtvznq5WWOxVoUTkq6DLNW0KWyrDFSdsAB6J5g3lbKq6D/dqvQhECHxQoLMsxRqvjpFKEpLaC3wIDwbl0DKOe3xygzxQNq23Z2GiQwAlLSRnx5ORZdK7JbDO5j8ZrxpjJ/tJI4ZlTvvpDNEyAF0rKP9t9/RkNs5zLCqQ95qgV002//K2vP69ssuBm6927PYTkQgHkEmwQ6P+xgznADTkU8HHZF3tBNbNkhCvu1v9O2e/1TZjwVuZhNQV7j9kYbj1CjJmDulbOnYmvdB00MJRDEKLv6kseO6XbhMwxlqUkFSfYqCIyZmWNJI3/PGikcckWxpKaNA/ywHcet0XLStuTmqkzh0mgErBCHFVF23ApXAG2uIdSSpupbBxSo45yvNbsgO6nAcYFIlfFktqf+emc+Oap0f2pcv/aHl6/YnFq6I5gtDt0WYc6hRu+vaoHSYS1Dzo3dBhuyUBwZBkN0hMMJBHK7EaoBRMPB9ZoAWdtTzYVvTInM9qHSqS1fh0ldyPTZzsoKiJlxP5ftEYXNgWzZAxBNIqzgZmvM1fl4rNuRpxaVTRaNPqiXXpgpg+6ODdT3AbIaQMlVXNpEeJEjdhTxQIi2OW7s0EjUllT8rhMOGRlASz7CPP7fPtrle4djlDtf1I+pKMYBRZ kHCGdCKQ Q6VGG2WZ5w7qf8EHqAi1OzeGYcK/1fp+LhBw0dNvCBw6JMjVOjX5v7AgKta9Hcdrdo4F9iMsOgwStf7dqG+T6AuVQZeSHVyWwQGcetyrwTgeHOJEm1QtlJpR39u2dKFi891ZVNIRZIZ3w4kGbW21J8i5iF81zGH+1r4lRr8XeRIQD9/h8qnLky1ZARoihb78xxGFiNvwjUocN/eJ/Dwkjq759O3huiF9IydcBVduSXYhHdDVMyZhIkJytBL0VJuEGUmnbtzZpgLYKrr1TxWo9177QadL2XKCw7A2LI0V/mcFUTtZUX3HjAbRiL63zcwecmbXH11f+P9sL6RZZcBbfWl5P2iA8MfUCX4QE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Luis Chamberlain writes: >> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h >> index 837e4a50281a..79c46da919b9 100644 >> --- a/arch/x86/include/asm/tlbflush.h >> +++ b/arch/x86/include/asm/tlbflush.h >> @@ -4,6 +4,7 @@ >> >> #include >> #include >> +#include >> >> #include >> #include >> @@ -282,6 +283,7 @@ static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *b >> { >> inc_mm_tlb_gen(mm); >> cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm)); >> + mmu_notifier_arch_invalidate_secondary_tlbs(mm, 0, -1UL); >> } >> >> static inline void arch_flush_tlb_batched_pending(struct mm_struct *mm) >> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c >> index 0b990fb56b66..2d253919b3e8 100644 >> --- a/arch/x86/mm/tlb.c >> +++ b/arch/x86/mm/tlb.c >> @@ -1265,7 +1265,6 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) >> >> put_flush_tlb_info(); >> put_cpu(); >> - mmu_notifier_arch_invalidate_secondary_tlbs(current->mm, 0, -1UL); >> } >> >> /* > > This patch also fixes a regression introduced on linux-next, the same > crash on arch_tlbbatch_flush() is reproducible with fstests generic/176 > on XFS. This patch fixes that regression [0]. This should also close out > the syzbot crash too [1] > > [0] https://gist.github.com/mcgrof/b37fc8cf7e6e1b3935242681de1a83e2 > [1] https://lore.kernel.org/all/0000000000003afcb4060135a664@google.com/ > > Tested-by: Luis Chamberlain Thanks Luis. The above fix/respin is already in yesterdays linux-next (next-20230724) so hopefully you are no longer seeing issues. > Luis