From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB8FBC001DC for ; Mon, 31 Jul 2023 17:16:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80AFA28008A; Mon, 31 Jul 2023 13:16:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BB2D28007A; Mon, 31 Jul 2023 13:16:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6837F28008A; Mon, 31 Jul 2023 13:16:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 594F728007A for ; Mon, 31 Jul 2023 13:16:34 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2F2F9402A2 for ; Mon, 31 Jul 2023 17:16:34 +0000 (UTC) X-FDA: 81072561108.10.011C1EE Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf29.hostedemail.com (Postfix) with ESMTP id 3694E120006 for ; Mon, 31 Jul 2023 17:16:31 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=4Hjb5UWS; dkim=pass header.d=linutronix.de header.s=2020e header.b=AbsubkRP; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf29.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690823792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GfWIocfTZiQHj6G3Mhtqo2RpmiVraR74yBaysrJkTOs=; b=Q+3iySTrC98Z2dx/fLCo7noiOTNhRcVOTI4V9DdDJH0WkAXGkKF5MF/cgN3cEwoebtl1t4 E6uxPXVYgcZ1SOHXGApoSv1dDKnukSxj6iDCV2xneXcf6Pka+yiRTSl7QmOFL/0FUCmY3D XCagP8NSpdO3bMIZK/Wv39uPiU+reQ0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=4Hjb5UWS; dkim=pass header.d=linutronix.de header.s=2020e header.b=AbsubkRP; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf29.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690823792; a=rsa-sha256; cv=none; b=e5YmU2jAH3vT/wo5BhVbiuhiQZSLcEuysoNRpRrPXrQYiqDjLjCSK9m0dUqsk8b19EFE2e EigEKWIbxbTKG4Jg8Fz+H7M9//cMcXJyNCi91yjk0cpmNat12sd48+UvOo6gKuE90oHfY/ 7EBrprP4cAZTtS9DSsHE08PMtl+Gib4= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690823790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GfWIocfTZiQHj6G3Mhtqo2RpmiVraR74yBaysrJkTOs=; b=4Hjb5UWSWPhvFnRfqwvguW8HYeyWkLb7/CcmdubaY+th+qcieNv/eekrVnssRfjQPfbopO MCG5+XcndAu+g5VCLp4VLcX7m4Pg6yY19/v3DWNMhBTvGXrJ/fjlmZthAoABcgYZf9ul7P YBDOPDek7DGarO2sm+ZT/XG472+hRojiXr5OYeJDKi7vKgyMtwUQIE9h5CqTrIduTtpEBt dgepI2gk+xGg1zDaob6+ScqygSC1YkRAEL7IhSAKe0NvkAmdDsVltkgAyXkhHrKDpAgkPR xl5LmhbdUA7aU902SGN3jg32VOixRxLSNCrKzptn8aMblO3LKm+bmXyjPDqzRw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690823790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GfWIocfTZiQHj6G3Mhtqo2RpmiVraR74yBaysrJkTOs=; b=AbsubkRPktsSbvKN5/0NyM/XHjXjQpjPByPzQkNSecLckXI9QGcekkY2CpduxxaB/oL8V3 SF5GOLvUwdqXhvAw== To: Peter Zijlstra , axboe@kernel.dk Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [PATCH v1 02/14] futex: Extend the FUTEX2 flags In-Reply-To: <87edkonjrk.ffs@tglx> References: <20230721102237.268073801@infradead.org> <20230721105743.819362688@infradead.org> <87edkonjrk.ffs@tglx> Date: Mon, 31 Jul 2023 19:16:29 +0200 Message-ID: <87v8e0m26q.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 3694E120006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tdfcpj463rdamu8zeh7f9k3ic18195rm X-HE-Tag: 1690823791-447997 X-HE-Meta: U2FsdGVkX1+OvYH3Wm3t77ZKVUMzHUYPL8FwnfzXzYsvw2PpZo9MCKLRp8J/AyyPhxmcNg7HydGWk47rxdfz8wv5/V3qnYlZt7VZYryG25eGcM24MLm30VLwSCQKs4oZXLjme3j+tFQNbbDSyqsRnN7q1S68+xE5D6E0lCoSZ+Js+l0xj9G+obG55ZDwa9Jw0KhnQoTD084KUqDDUO++2WspqW9T26uBjzO55G+ainzNza5XtA0UUKHrDWy4Rojzt8aV+qY8hH7Es7seOyOV/ceS580iC0WIsFa3pUFuzEng4rJ2Wq7U3pscymGldk1pnbEgIJJt380LhVqxhB5HD1G8l0jOgVsySMRHRkkL2/1ffmB75LdXZb8Aqy5d4+H6ZBGaIqYFr6uUPYGH7mkEzwaml/rMauBxxP8JZfwaoKhESrzjsoXogQDLp67nSxdOQ38MBQELbppRRW8McOPr+Z0PhVb5AHlo3o/CQ9PFZVD3ibvG7ZATJpbFXNAPp8Vq8Jlp3sAoj9mvInLsE8b+aX7LXuro4RmCoJgaCMld+fGDwByXroOqLibD2GeYCJI0qwolVlykKC7RSn1mBSVBcdSqMRWD2NseePBk5zpp2HYDHcjWmQO8ZZkGB/sAyLIlk6fo+VMP7YLuyGW6wGlChzWcjz/KIWrQc/mD6/XgE+hxA1kSnogsjl3rankaklDIsJ9TWbQrE3arUQ6DoHYtMuKO7IEmHtIBaGRy0+dAydbocTAeX8fw15yPwAe0255npUktQv4fbDKzZobA33PW0cmUL07SatZEDJ8Q7DzJHWd/+qUO0d+b4VXKUgNTyOdE/+PNK9IPEjgJeKQ7ChhShz7pMZPsCnlhJcvPJI+KKywTJn5gwomFP7eFH3AZbIrjeBAH09mz/LzmTlW2GUVFLkk1jKyCZvnsP4hN/rkPZk0H0HgXugstiM3gmc1zV8L/pZLxcLRqGC4xZ7qidhR 4ghOGr+A cfttSvZXAVSItu560T0bXDf+pjFQfe2qpI/D+aYKnFhUFxf4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31 2023 at 18:11, Thomas Gleixner wrote: > On Fri, Jul 21 2023 at 12:22, Peter Zijlstra wrote: >> -#define FUTEX2_MASK (FUTEX2_32 | FUTEX2_PRIVATE) >> +#define FUTEX2_MASK (FUTEX2_64 | FUTEX2_PRIVATE) >> >> /** >> * futex_parse_waitv - Parse a waitv array from userspace >> @@ -207,7 +207,12 @@ static int futex_parse_waitv(struct fute >> if ((aux.flags & ~FUTEX2_MASK) || aux.__reserved) >> return -EINVAL; > > With the above aux.flags with FUTEX2_32 set will result in -EINVAL. I > don't think that's intentional. Also if you allow 64bit wide futexes, how is that supposed to work with the existing code, which clearly expects a 32bit uval throughout the place? Thanks, tglx