From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A141C0015E for ; Wed, 9 Aug 2023 15:18:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D02346B0075; Wed, 9 Aug 2023 11:18:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB2956B0078; Wed, 9 Aug 2023 11:18:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2C4E6B007B; Wed, 9 Aug 2023 11:18:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A3D606B0075 for ; Wed, 9 Aug 2023 11:18:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6B7B9140EA7 for ; Wed, 9 Aug 2023 15:18:07 +0000 (UTC) X-FDA: 81104921814.12.953A578 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) by imf17.hostedemail.com (Postfix) with ESMTP id 971C740014 for ; Wed, 9 Aug 2023 15:18:03 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691594284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sRQCEDMCeocP5LvsTIIrU6gav2mEfed7GKR/ETVoDA4=; b=vWWM0BHySzeppqy77soFWto3QrhBdPuXKLf6zoRJQt9DrZmOPlRFB4I0dVJ51ko47Lwtw4 juZhq3uzSES5k2FylXp7oRnLiOtbNP4L0jlAGaQqyHn/VToU/fs6cxU59gBE/Y1XwOa4yR +0Px7fpwmZNJPLJeoSTx59CC/kTb2qI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691594284; a=rsa-sha256; cv=none; b=nAajJ8BpQEYUjrSDbXT8wou5oEOUr5V+pUFjWOtYPjdXOlEFpNlsxl5N+mvvfXMLdJftEH yMVLHm3p9T18aqIqhUdBwUdgyd5KwObEZSEk+Cv0R083e5dRe2zHUTLszUoO1wywWbzN3m aACTSVm2fP4tKBLH4w+SloXKkU9oRhg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of hirofumi@parknet.co.jp designates 210.171.160.6 as permitted sender) smtp.mailfrom=hirofumi@parknet.co.jp; dmarc=none Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id E5C652055FA4; Thu, 10 Aug 2023 00:18:01 +0900 (JST) Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 379FI0T9218787 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 00:18:01 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.17.2/8.17.2/Debian-1) with ESMTPS id 379FI0wR202859 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 00:18:00 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.17.2/8.17.2/Submit) id 379FHvZ4202846; Thu, 10 Aug 2023 00:17:57 +0900 From: OGAWA Hirofumi To: Jan Kara Cc: Jeff Layton , Alexander Viro , Christian Brauner , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp In-Reply-To: <20230809150041.452w7gucjmvjnvbg@quack3> (Jan Kara's message of "Wed, 9 Aug 2023 17:00:41 +0200") References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230807-mgctime-v7-5-d1dec143a704@kernel.org> <87msz08vc7.fsf@mail.parknet.co.jp> <52bead1d6a33fec89944b96e2ec20d1ea8747a9a.camel@kernel.org> <878rak8hia.fsf@mail.parknet.co.jp> <20230809150041.452w7gucjmvjnvbg@quack3> Date: Thu, 10 Aug 2023 00:17:57 +0900 Message-ID: <87v8do6y8q.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 971C740014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: hpbamxqcbka69s9ni8cjf83x3jm5ftki X-HE-Tag: 1691594283-710660 X-HE-Meta: U2FsdGVkX1+iqJbUTlwUiD7KVIJ8Xhtl2TPfH3rPh6eEWtW6cgV9P/wizHFCrro1LhtNxANdCTvu5i1imZ2Ikw1vwbznMDYYye6VhK7T93RddW36exMUmBTtLRwuY6oIeS2I1wATBfEEmkdnftPb8jnIpV7OfM7SgPQt2t4q+1+qPa0CHtKXD8+EH+6+GA3HLFhutJtC0IYZ/HyfRWjgLKm4ZVASThWrDFalmeSHQjqHCqfZMx8EQ3iDcrlnTP/Jll1ILQxNpAfsEJasFecSc1PbF6AUOrIqUGFeFw4+Q5h8zUnXDPHeGhS/7eaBzd4JrnlovrE0HPQm5HC4Sj7/PfSAq1USQGnqM1WIdRJmoQRQJpD8xkuy/pfddbgr9brZz7bHIPUREfF33/5jT/pvTPcA5MxHgJiJrlWIeyfsP1c4iT2E88P7SRYBnv7MFbG/VQ32ypbimvXmcDBWJ1kB92zM+cDES7YmknULkb4WY22B6kPVf/nmeDaAwxypVwdA/yg2+B2S6BJ8p2r49yG4+xIi/8xV9wK7xOYIgSRlQYzneZJOkj6kuhz3jEjePqDmQaqNBhY9HDQDO20KzhDayPxwWzDp/yVZ8n0e1oya7bPD6nnbUkqFs4ogA6owUnVnnGZKMA/+HP6iT6Ig2OxQW+zuCVP9aPB7zb76gfYNztWKYnrhJKGqT03uJwXlb7L5EH2A3zWhKDqjUii2b2pLC2uDWlNRamdi6sy0M7CHL3jqoojiCGg606cPYcPAawzwbppIMZzviOgCXs0vm8HbvlxMxcmhU4O92WsgKw8bhFR4/S6HvRL8qeTwMoMkQE0AlrjKFJ3iQdE+8IctsWbbLBK4YkRYQVs77M3dZ/NRHKlX+qLRFjDxeR/anxFJB7z1SlVanZkdctRxdLG0FSDRKVAADMfmxQRaJ6LJe5fipLZqlRjoB6hIAA3Q3Sck5Q+X72mj0K3wWPHERYS7eQ/ o0mFbrwi C7CY4/QgVF28K4PsdG3uzxqyutco1lqDBqnBchVk2CC5ZbiyV0PgLgBZyOxMkRfvMhWD6YolzzotHH1rd+BozDTmwGQDWgTPbjZJRDzf8nrrX6g8op7n9Rv+CVbD/tORiURrY3b27zPpYk27J6eUbEnWN0SISYH4Ev58AMDVrpXtWtCrV8iauxzsH7HOMS3QFL1/uOCgVI0YL7jxbNdoX98EQm9gBM7bbAdUIFO/t8Pk9a8c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jan Kara writes: > Since you are talking past one another with Jeff let me chime in here :). I > think you are worried about this hunk: Right. > - if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) > + if ((flags & (S_VERSION|S_CTIME|S_MTIME)) && inode_maybe_inc_iversion(inode, false)) > dirty_flags |= I_DIRTY_SYNC; > > which makes the 'flags' test pass even if we just modified ctime or mtime. > But do note the second part of the if - inode_maybe_inc_iversion() - so we > are going to mark the inode dirty with I_DIRTY_SYNC only if someone queried > iversion since the last time we have incremented it. > > So this hunk is not really changing how inode is marked dirty, it only > changes how often we check whether iversion needs increment and that should > be fine (and desirable). Hence lazytime isn't really broken by this in any > way. OK. However, then it doesn't explain what I asked. This is not same with generic_update_time(), only FAT does. If thinks it is right thing, why generic_update_time() doesn't? I said first reply, this was from generic_update_time(). (Or I'm misreading updated generic_update_time()?) Thanks. -- OGAWA Hirofumi