From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65833C4332F for ; Thu, 2 Nov 2023 05:45:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5BEB8D0079; Thu, 2 Nov 2023 01:45:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0BE08D0026; Thu, 2 Nov 2023 01:45:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD31F8D0079; Thu, 2 Nov 2023 01:45:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AD18D8D0026 for ; Thu, 2 Nov 2023 01:45:12 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 87DCE80791 for ; Thu, 2 Nov 2023 05:45:12 +0000 (UTC) X-FDA: 81411926064.26.7D9E557 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf11.hostedemail.com (Postfix) with ESMTP id 74C5340026 for ; Thu, 2 Nov 2023 05:45:09 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=itNioZ9z; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698903910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tn29dpE1ZyUUKrht0Sdr0ZP7MKBeORRBoLYGZNR+G+0=; b=56/GuiKH3ZKdR8SyiegEnRFRxlKo34Pi8wrjUQx3aKhtEL2y2leHU0aUaUQG27+gGiIJMU A/hTdq5rLn/xxXK+X2+dgmJ5wFWg2+myLMAVUXZ/N2+hyenhw/N5Htq6LDt4sXJ4rn9yc0 B+lOhCY/iPy0iXJIf2seaubmUeycJmM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=itNioZ9z; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698903910; a=rsa-sha256; cv=none; b=t49Ec8SsxZk6ALgZitXHVcLjfBDazVqOxz1tdlxFYIzxes4fULtispRPdVu3fvkD1y8Uz/ PNQAlmBOyzNO99krpOxYGYYiqc27eEAJ95/u6iq7SN2DQOHn12bvhVWiozrmAxFzw0RMeH hQ5JXW4p7b0gC8I4OQTMkXRWDCRnrQg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698903909; x=1730439909; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=99wMrpgWTHZf83CxBo4N4kk+aclJmIhd2EI55OOETrU=; b=itNioZ9zDluE7GY3ao7SW1pxwVPzQJ3NUErHQU0e5p5xtx8ZvCI6GneF HCJpZrZDG6frvnPuLEb4ddzZ/T2XdXw+65Qa90x7e0EfexyLm9jVQ9eWh 0YVi/ytfsXzW6hfbeaxusZggAcXIR2FRzF97dZj2Uh3YceqY4dvbQAm+j CD/S+UVf9ioPz+y3aNa31rOPWoliTQzsZmXk09dilh9q4b2Zl5OYHqmnK heh4D8Gtqos7ku02anbJpKhUylntpV5USDuQuhrfLBbhDW8/v+oD2tpnz qVGQ5/vVCMMOkzmhdimoVh/rAGiJW/TKUDiMi5MWV27g9JNWTUo1+xxpK w==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="391503969" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="391503969" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 22:45:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="2320333" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 22:45:06 -0700 From: "Huang, Ying" To: Li Zhijian Cc: Andrew Morton , Greg Kroah-Hartman , , , , Subject: Re: [PATCH RFC 2/4] mm/vmstat: Move pgdemote_* to per-node stats In-Reply-To: <20231102025648.1285477-3-lizhijian@fujitsu.com> (Li Zhijian's message of "Thu, 2 Nov 2023 10:56:46 +0800") References: <20231102025648.1285477-1-lizhijian@fujitsu.com> <20231102025648.1285477-3-lizhijian@fujitsu.com> Date: Thu, 02 Nov 2023 13:43:04 +0800 Message-ID: <87v8ak1ziv.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 74C5340026 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: xatxdhftf1nyddah8ajnf99uqwz1whod X-HE-Tag: 1698903909-530452 X-HE-Meta: U2FsdGVkX18ptQ29QVYDnFpNVwBnY2txf2qvs2qd88AllN0kWPt/81oZgqOcZv2f4uAPXRF4SwnxiEnuXwKc2XdmZCcpDTxhDciI6NLyWFq1OCxl4lb9GRL0OktJa2CjJwAluBvWOhcKXcx0ky4quXnhJWFnf1b7VQKCAwsTW1eJGv1YLOkF8BqFLzYZxvvsCBDWhr03TUeR9hYO8Qwyqu0su6LHSXOZurBsoNsTXwADPWVJLQAJrgsCk2Vtw3jWUrTcjjCLIFc9nsHrCJvGsLx6bXGPeaFCUc8tgN2ICfOW+ntve7o1Imd52dbqiSq1BYMXOo9EUJUT49hWl7rxeLjH0TTIUQCh23e3//lnTrom7L9QhSVtMzWUitB91KxGYoP6oQyRWEBctnYR254FCIezioWJVcE4VKK3ALS5haFdtW0rwi75stzZFbdLfHqVc6l4WDO89h4ddol1KlyTh2sYpQzfe2qj9lnJXICI4aHi8wfE+smQznqbxXFAZh6Lj8nqHRyngHVDQfRg08kQVXpumbADsAgHuZh6ZCf4nSplPRvXmaDnWb4LtMI3LCtbwn/DV/uA92kFICUoSYpheA43BnstittaJB5Ywo/xPEuepukqPblKcOP1DUt0VXbbOS4QgPgyGazYZhCwgFVs47X7lduw5yCwplBfmR2y8rBFFhK0Ozv+T9DL2MnphXYilb4vGAEGrmxJD+dx6DNo7rON4xMqacuMxC8VPHLaIQ+uJ0dWqcDPfil7BQgUdWwxwGumOmorICGOIFd4UsWRBmLTjFTqAMeyaq8c2E0KC6XpGze6c9pwoxiIHCXXT278+h1EueDKVX7WAxbuqoZF3dQOFOU0DKDh5MU9W4e7p/NasBUDbNPvlbzmx0pi1GJDx+BsdvVK1xN5+UvYy8N866LdptBoDPTF0ePfEULiIemYJE1S5+2wVLy9RjoTPLxJDuAjM8lyIbwAHR76NB2 hxbGQi2J CZzgWNIClw7fjLADAtcCrQvxhUXlQ+uo8RWiUtJgwYG4N+OKcUUKFBWohHCTA4rqnNenjTCYBESzn0C8ODhhvi0PLbqUGlfMetsxPiUJR976j48DRlNPkNC26ddqRT+7xU7ekFa5CgFWiAHtbLEmm9NAnCt4BN98xrjhbMGLF+aw03TbIfCAmeJtUrRC2iSYrzKODay1LDc0M/TudMvavHHOuMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Li Zhijian writes: > This is a prepare to improve the demotion profiling in the later > patches. > > Per-node demotion stats help users to quickly identify which > node is in hige stree, and take some special operations if needed. > > Signed-off-by: Li Zhijian > --- > include/linux/mmzone.h | 4 ++++ > include/linux/vm_event_item.h | 3 --- > mm/vmscan.c | 3 ++- > mm/vmstat.c | 6 +++--- > 4 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 4106fbc5b4b3..ad0309eea850 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -206,6 +206,10 @@ enum node_stat_item { > #ifdef CONFIG_NUMA_BALANCING > PGPROMOTE_SUCCESS, /* promote successfully */ > PGPROMOTE_CANDIDATE, /* candidate pages to promote */ > + /* PGDEMOTE_*: pages demoted */ > + PGDEMOTE_KSWAPD, > + PGDEMOTE_DIRECT, > + PGDEMOTE_KHUGEPAGED, > #endif > NR_VM_NODE_STAT_ITEMS > }; > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index 8abfa1240040..d1b847502f09 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -41,9 +41,6 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > PGSTEAL_KSWAPD, > PGSTEAL_DIRECT, > PGSTEAL_KHUGEPAGED, > - PGDEMOTE_KSWAPD, > - PGDEMOTE_DIRECT, > - PGDEMOTE_KHUGEPAGED, > PGSCAN_KSWAPD, > PGSCAN_DIRECT, > PGSCAN_KHUGEPAGED, > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 6f13394b112e..2f1fb4ec3235 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1678,7 +1678,8 @@ static unsigned int demote_folio_list(struct list_head *demote_folios, > (unsigned long)&mtc, MIGRATE_ASYNC, MR_DEMOTION, > &nr_succeeded); > > - __count_vm_events(PGDEMOTE_KSWAPD + reclaimer_offset(), nr_succeeded); > + mod_node_page_state(NODE_DATA(target_nid), > + PGDEMOTE_KSWAPD + reclaimer_offset(), nr_succeeded); Think again. It seems that it's better to count demotion event for the source node. Because demotion comes from the memory pressure of the source node. The target node isn't so important. Do you agree? -- Best Regards, Huang, Ying > > return nr_succeeded; > } > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 00e81e99c6ee..f141c48c39e4 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1244,6 +1244,9 @@ const char * const vmstat_text[] = { > #ifdef CONFIG_NUMA_BALANCING > "pgpromote_success", > "pgpromote_candidate", > + "pgdemote_kswapd", > + "pgdemote_direct", > + "pgdemote_khugepaged", > #endif > > /* enum writeback_stat_item counters */ > @@ -1275,9 +1278,6 @@ const char * const vmstat_text[] = { > "pgsteal_kswapd", > "pgsteal_direct", > "pgsteal_khugepaged", > - "pgdemote_kswapd", > - "pgdemote_direct", > - "pgdemote_khugepaged", > "pgscan_kswapd", > "pgscan_direct", > "pgscan_khugepaged",