From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E19CC4332F for ; Mon, 13 Nov 2023 01:33:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1CC16B01A8; Sun, 12 Nov 2023 20:33:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCD426B01A9; Sun, 12 Nov 2023 20:33:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBB786B01AA; Sun, 12 Nov 2023 20:33:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ADA876B01A8 for ; Sun, 12 Nov 2023 20:33:16 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 87AE21A017A for ; Mon, 13 Nov 2023 01:33:16 +0000 (UTC) X-FDA: 81451207992.15.057238A Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf21.hostedemail.com (Postfix) with ESMTP id E698D1C0006 for ; Mon, 13 Nov 2023 01:33:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MTUL0HXG; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699839194; a=rsa-sha256; cv=none; b=WznPEsbZzu2ECveNrqfl8W464tkQHinLaXrF/57lWylWgtKiz1BjN+X1+KJlI1kXuJKXrL 6jRvH+bCxVxVrhXRINmsmzK7+wckzoaSEWCw8GVURaZG7ok0bSbRMVYkBGwfndKrTF964u KJ32QSEMV3fVlVPOeo+OiJgAhXVnyF8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MTUL0HXG; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699839194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nId7GW+4lpQhjjTfKZuy1pa+6GzYvT8ZtHaDkX0bQ6k=; b=HVe3jyJ0mOZNoQbVNHbSxiAMycW3/McTMM/CB1UlT80IuuWTOz45fZNEisHqNB/45B7Rck P4XXhQ3dKG4RcCSzUhIXhRieDA30Eo8Pt9L3XtkqSKJBqN4rb8Y8qs6syhflNtmcAdDiKa 10/wdj2+VnNgIfZuFIv5siWanXbei/8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699839194; x=1731375194; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=6s0Zq5kC1eUCJkylNpmwGs+kVYT+CkdgpvKFUIcNZk0=; b=MTUL0HXGGTf4ttmRHeGnzqBVHQoRy6s8yxk2tUBkj0rbnVvk/1H80L5R wDpCxNbaZ9PVYJQH2i/ERigA16IV27rkh2oORCXPeXZfwo80ku2Qe06yn ODw1RrOEsFQ29HKGRakqRhjiZOzvKiaZ3soI8489lFnhjtnE8u87byCRt Qcn1mDcQSSLfF7UfEHRKcw6HTTQUBadMlw9i/i1o1TrzJ+cd+Ld/P+L7I gAIK8zPFRafVdzAs0kTJ4WBwHgF68iNi0xlBgI8lYgEDJHCzf9DgXqXoC LRWYNaNjLRTHOr8mwl7PqvzcYATpYDOf1qLIxUkZimBpwaQij846qWFbn w==; X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="3451174" X-IronPort-AV: E=Sophos;i="6.03,298,1694761200"; d="scan'208";a="3451174" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2023 17:33:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="854834930" X-IronPort-AV: E=Sophos;i="6.03,298,1694761200"; d="scan'208";a="854834930" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2023 17:33:08 -0800 From: "Huang, Ying" To: Gregory Price Cc: Gregory Price , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v4 0/3] memcg weighted interleave mempolicy control In-Reply-To: (Gregory Price's message of "Fri, 10 Nov 2023 14:54:49 -0500") References: <20231109002517.106829-1-gregory.price@memverge.com> <87zfzmf80q.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Mon, 13 Nov 2023 09:31:07 +0800 Message-ID: <87v8a6fnhg.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E698D1C0006 X-Stat-Signature: 9ton6wqjwprzurrnegs5t9wi5k66hqou X-HE-Tag: 1699839193-14567 X-HE-Meta: U2FsdGVkX1+wX6fr5HgRiFlygbRwJHS6CqizRByTU2fSIUJ+ErVcM5/AEoSWU/HPpq7dlw0G74JiMgQToEG+/83RxNoCa8WXzUglOPaCidHVlXrgq2SCx/BiD0rtqQsqbaLvauRdfTJjzfnkQUqDeuFC3yk8+tIed4Kgp/8Tgx5i5yn5Z1288tS28133/ijbzRfvdAi7imBi2qZYZKTjsg2Sh3IBaaddtXm7XsattL6xbrLWPDbtiAjUHjBoYDC13LObfuPG+2r83aiaesAyVBPVu5Opp6p+Npi1F0FBcF9sk0zh5WPF/dD7Xx8WdNmAsesT1iaIRrarDjuFDdkvsyi+8R2vWcQJD0jtJqJI9e2jENip5qifa8A2N/oUQUq38miBNYxy1IPGQIbdmXs8mKxfE8mq2Vqt8ytpsLsii/zdPjXGkVUkGt7cWis95YtuPjMNn9MJ4a1OLPsrytsghDMn1cokmoRjdu7ECAGjKDOHSTOd7yho3OCqa22av6re1+mYESqmLa3/KF8idnP53vqytc7/7sE5pXjQnAtYQY6k9rf0LOBAaI8K0aOK2zYVgmU6Ok/FqqvVHYuTuYaL9vWu4esKHsbRvOdIjgNa3t23cmmIkzv6OJ7WVw8F939wJB6IvCIHHhhQcTklvs3ZRVVsuqXvOUndH6sXnQX0CnccGzOoGMkfT0P2Wyo3Y4dkR2fwcdQm6P0j7P1qYdnTTZmWSLpeNM1FLAR7A0qhWD2jOGs9CTSOx4HuXFFq3ix3Gal04p1tK4U1YTajyD7rIc2zK72GLzQ5PvQBVIxVxKa5HsBrulWSBVw2az4kCeV7/dUxXklGy04luZXKOjNQnPaOjnPjVaGG7bt4aO7KG6mTAhMP9f/uUJRjY5xbrTzCaRhPBd37QHaYT1XgmP4c+b4E2M5XJSSgEBl3UHw1w9i0jzu29qq494sYkuMvxbVMR3LhTkmzpSnb813cBs6 axxrAcr6 Mjlf8CfsQ2nFmeJKswWloBl3fP0qpYvlmpB9pVzMBcgVb066ZSi/6cQlX5eq23xljmIhu/Uo2N9qSaF6yvAQQD+rU+xCISZ3A3OYt2B4Xsy/+pN73KdWYdEVdPtyK1WO/tnQlLo4Q1c4hvocUwYrK9scYZIohxMM5ooO+MefKAeDh8xCyMlUVO4hqH/YrW+0ZDMZLnHcdzv6RJCK97Dnk5855MiITI/Adah0QzWkpuq9Cqv/Hy3K7PooGMycZ6Q7/UL1CnZ9xwPegg85jE9A/Fx0O4fy0OFVf/DYAnMS5b5kvKMk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Gregory Price writes: > On Fri, Nov 10, 2023 at 02:16:05PM +0800, Huang, Ying wrote: >> Gregory Price writes: >> >> > This patchset implements weighted interleave and adds a new cgroup >> > sysfs entry: cgroup/memory.interleave_weights (excluded from root). >> > >> > The il_weight of a node is used by mempolicy to implement weighted >> > interleave when `numactl --interleave=...` is invoked. By default >> > il_weight for a node is always 1, which preserves the default round >> > robin interleave behavior. >> >> IIUC, this makes it almost impossible to set the default weight of a >> node from the node memory bandwidth information. This will make the >> life of users a little harder. >> >> If so, how about use a new memory policy mode, for example >> MPOL_WEIGHTED_INTERLEAVE, etc. >> > > weights are also inherited from parent cgroups, so if you set them in > parent slices you can automatically set update system settings. > > by default the parent slice weights will always be 1 until set > otherwise. Once they're set, children inherit naturally. > > Maybe there's an argument here for including interleave_weights in the > root cgroup. Even if the interleave_weights is introduced in root cgroup, the initial default weight need to be 1 to be back-compatible with the original MPOL_INTERLEAVE. If we don't reuse MPOL_INTERLEAVE, but use a new memory policy mode (say MPOL_WEIGHTED_INTERLEAVE). The default values of the interleave weight in root cgroup needn't to be 1. So, we can provide a more helpful default interleave weight based on the node memory bandwidth information (e.g., from HMAT, CDAT, etc). That will make users life much easier. Do you agree? -- Best Regards, Huang, Ying