From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154A9C48BF6 for ; Tue, 5 Mar 2024 02:42:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 930366B007B; Mon, 4 Mar 2024 21:42:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DFA76B007E; Mon, 4 Mar 2024 21:42:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A7316B0080; Mon, 4 Mar 2024 21:42:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6B3BF6B007B for ; Mon, 4 Mar 2024 21:42:20 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 091D240DA3 for ; Tue, 5 Mar 2024 02:42:20 +0000 (UTC) X-FDA: 81861436440.11.154A81C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf10.hostedemail.com (Postfix) with ESMTP id 47617C0005 for ; Tue, 5 Mar 2024 02:42:17 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=axAeY9Sy; spf=pass (imf10.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709606538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T4N4ai2fUYeTi17bmaqa5sNo2EZA38HXgMSv68D79fE=; b=WFq3qCe+qH9fwtz9BrOUYZ5RGlCAQ94wucqFUc0lz5KJJaasYabmUuxX0lXRV1nqSKV80B G87r0Ty987/PrK0P9tQEuiGTWhg8uPmA6XXCK1kq6gBS+RZ2tK6PbsI6bza2Nyk8Y8RkII rUIAjeHMy3gaMJMTXJ1zSjWa/aO5+Es= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709606538; a=rsa-sha256; cv=none; b=JJgPkyTQlnJu9f7ujtzGTf4tFrcOYTh/FsupkZWpZ3STrXd3deR62vMvFFnXzNEncpqviY UqfPyU3XnQV/co1FPvCksXbS3xpJv8l0OzAJQiDJDdBExSTUKy5J0fdhwACHpSaxkV5wwq FpWJRwlR/sKi/dAfMXZMHNw7pkqckCk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=axAeY9Sy; spf=pass (imf10.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709606537; x=1741142537; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=U0H7QWtBAWqPBlvTxscDhOVI9EoPYqvERlla0Um5xqs=; b=axAeY9SyAg7jyUMeDJuPDwAd44lldIJoMm/CeXopA9xhXKGEiCHtgqPU tWllHUwsOhWpWEZQwmDkFkNMZsZ9YpV6RL2MzPmqtUUXW/pYeizUbzsht e4zWo3beEVG0ZpdlzE7pwphWb38KqwakkdFID8c/6yy62waRPQLnL56Rj TbGdv3lFY97z6ca872l4GrywwJIP5KMfmGEiT8m+s6zm6MhBb4zfrj830 w8hIPIZd3C+9+RDo8Uk6Smc9pF3c0Ly1mcf4u4qpdYmkwTxF9MDOZfMCf rFv3W+HMq5wVwmadfUInlQWUszhtcvnTm4qWW/+ITHUvPJSnGxCocNWbI w==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="4292106" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="4292106" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 18:42:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="9387868" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 18:42:13 -0800 From: "Huang, Ying" To: Byungchul Park Cc: , , , , , Subject: Re: [PATCH v6] mm, vmscan: retry kswapd's priority loop with cache_trim_mode off on failure In-Reply-To: <20240305023708.GA60719@system.software.com> (Byungchul Park's message of "Tue, 5 Mar 2024 11:37:08 +0900") References: <20240304033611.GD13332@system.software.com> <20240304082118.20499-1-byungchul@sk.com> <87zfvda1f8.fsf@yhuang6-desk2.ccr.corp.intel.com> <20240305023708.GA60719@system.software.com> Date: Tue, 05 Mar 2024 10:40:19 +0800 Message-ID: <87v8619zak.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 47617C0005 X-Rspam-User: X-Stat-Signature: dz69k3mhxp9tu1a5971nbmatdqmocekj X-Rspamd-Server: rspam03 X-HE-Tag: 1709606537-178551 X-HE-Meta: U2FsdGVkX1+NFFz1kQCzD78oLKlJd3hgoNQxayKvkQ6Y7H8u3aN49SviKmxy9IuxhLa0c5WtDZbq9fHviEijUb0savrZ1viiZeTdtzXRTs6731ToIohb3VRD1U3OsCUaU3F24pUYxaTG90cYZVoM6Ps8smD+6BTLXAp+tWfXTqrEfFWyD1nCcqDuF34C9Sd5P8BQxJX7KMHQY3uBu5IwvmG9+BsWTNVbtKbG544ngfAWH01aDBgKHznh/Sca+4ll2BmTjbnxHW8+TFro3CPMjAwWp2IefukDP3IrwJIyDyqoG0piUEuD6VrRDL9bluH8/2Dis89IZuSWCktm/DJzcxZI5EmawgjPnmpAOCyyfRyG1I2PWU5ckb6xPtbDlQ/i1iJqrExSqBg82SR0V4R0R+ovVnvEeRxtSc3cxNh0Qbai+iXMMA79949wwQxrEdDVq99814BRk9wyGT5ovQKFv+X/t3RfAyPmm02Kx8OYgDB6TQW9QHUSScgQmJChGk9qSrYnC6sWFm4FMe/CJ2MpMP5Wz+OAlO5KpYB7cxQviL89hHzKz2utPUS30Maq0bN61DeWQDrKkMrfZmGbiDl/EPYo8IjrlMymFhU+sMp4lidueSgtUNp8ZNxwOYHV446wuWguP/KJ7G2qZOU7CdOdzrzkDCy4NP5WPtQnJqSgyALSnLUk8qM11iozYQs3ZPBd1TS0l0C93rWgfFKs65WXDS0HrISD0Ie/wckYbh+6gkv/lUeicL0pzORueYyOumaDzPba4+Ct0PH9PlAEZMHAK45CqVVel+KdvtQ+MJKMhNcacoetvN5CqpCjgYyqmp9rfGp+hkip4P1xmSt69wx2eb5L8gunLtddOLDqpi6P9Lh+huci8GhKx/jXfLjvR5Ui/zVjZki17VEMvbeGNJR7uF0KkxRw5R5A9WM9ZQW7Shv/XJoROYraq9aqu5G2gh7AwovHCnQvvibFXk8y55Z aTVwhF4h 5msUHIUdyMvdBj61lNE0/bK3v2Efwb4cXg8+kJ3uXLIsxz9n7mKIGG5fnCGVehY9W3qWwRiD6IidBrm0FKApuV0r+ZcIBhrwSu4QOt4ckmIimV7xuIuqJjLhKFUW6HQoJjeYRDzGAhAyU+1rBWN817hlhPQ1cRyKLCyyFaMBRQ1MgbqelsmYB36EJ6z7pPHxz1rI87mxeizjk5ljcNPvoMrhuTSAdC/lBDqO1ZUgMCUiBHj3H6MyPWMnDU31wwEp6rs7bgeDpd/QQjGyAr0APOxprJ0mPrnj/w4HE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Byungchul Park writes: > On Tue, Mar 05, 2024 at 09:54:19AM +0800, Huang, Ying wrote: >> Byungchul Park writes: >> >> > Changes from v5: >> > 1. Make it retry the kswapd's scan priority loop with >> > cache_trim_mode off *only if* the mode didn't work in the >> > previous loop. (feedbacked by Huang Ying) >> > 2. Take into account 'break's from the priority loop when making >> > the decision whether to retry. (feedbacked by Huang Ying) >> > 3. Update the test result in the commit message. >> > >> > Changes from v4: >> > 1. Make other scans start with may_cache_trim_mode = 1. >> > >> > Changes from v3: >> > 1. Update the test result in the commit message with v4. >> > 2. Retry the whole priority loop with cache_trim_mode off again, >> > rather than forcing the mode off at the highest priority, >> > when the mode doesn't work. (feedbacked by Johannes Weiner) >> > >> > Changes from v2: >> > 1. Change the condition to stop cache_trim_mode. >> > >> > From - Stop it if it's at high scan priorities, 0 or 1. >> > To - Stop it if it's at high scan priorities, 0 or 1, and >> > the mode didn't work in the previous turn. >> > >> > (feedbacked by Huang Ying) >> > >> > 2. Change the test result in the commit message after testing >> > with the new logic. >> > >> > Changes from v1: >> > 1. Add a comment describing why this change is necessary in code >> > and rewrite the commit message with how to reproduce and what >> > the result is using vmstat. (feedbacked by Andrew Morton and >> > Yu Zhao) >> > 2. Change the condition to avoid cache_trim_mode from >> > 'sc->priority != 1' to 'sc->priority > 1' to reflect cases >> > where the priority goes to zero all the way. (feedbacked by >> > Yu Zhao) >> > >> > --->8--- >> > From f811ee583158fd53d0e94d32ce5948fac4b17cfe Mon Sep 17 00:00:00 2001 >> > From: Byungchul Park >> > Date: Mon, 4 Mar 2024 15:27:37 +0900 >> > Subject: [PATCH v6] mm, vmscan: retry kswapd's priority loop with cache_trim_mode off on failure >> > >> > With cache_trim_mode on, reclaim logic doesn't bother reclaiming anon >> > pages. However, it should be more careful to use the mode because it's >> > going to prevent anon pages from being reclaimed even if there are a >> > huge number of anon pages that are cold and should be reclaimed. Even >> > worse, that leads kswapd_failures to reach MAX_RECLAIM_RETRIES and >> > stopping kswapd from functioning until direct reclaim eventually works >> > to resume kswapd. >> > >> > So kswapd needs to retry its scan priority loop with cache_trim_mode >> > off again if the mode doesn't work for reclaim. >> > >> > The problematic behavior can be reproduced by: >> > >> > CONFIG_NUMA_BALANCING enabled >> > sysctl_numa_balancing_mode set to NUMA_BALANCING_MEMORY_TIERING >> > numa node0 (8GB local memory, 16 CPUs) >> > numa node1 (8GB slow tier memory, no CPUs) >> > >> > Sequence: >> > >> > 1) echo 3 > /proc/sys/vm/drop_caches >> > 2) To emulate the system with full of cold memory in local DRAM, run >> > the following dummy program and never touch the region: >> > >> > mmap(0, 8 * 1024 * 1024 * 1024, PROT_READ | PROT_WRITE, >> > MAP_ANONYMOUS | MAP_PRIVATE | MAP_POPULATE, -1, 0); >> > >> > 3) Run any memory intensive work e.g. XSBench. >> > 4) Check if numa balancing is working e.i. promotion/demotion. >> > 5) Iterate 1) ~ 4) until numa balancing stops. >> > >> > With this, you could see that promotion/demotion are not working because >> > kswapd has stopped due to ->kswapd_failures >= MAX_RECLAIM_RETRIES. >> > >> > Interesting vmstat delta's differences between before and after are like: >> > >> > +-----------------------+-------------------------------+ >> > | interesting vmstat | before | after | >> > +-----------------------+-------------------------------+ >> > | nr_inactive_anon | 321935 | 1664772 | >> > | nr_active_anon | 1780700 | 437834 | >> > | nr_inactive_file | 30425 | 40882 | >> > | nr_active_file | 14961 | 3012 | >> > | pgpromote_success | 356 | 1293122 | >> > | pgpromote_candidate | 21953245 | 1824148 | >> > | pgactivate | 1844523 | 3311907 | >> > | pgdeactivate | 50634 | 1554069 | >> > | pgfault | 31100294 | 6518806 | >> > | pgdemote_kswapd | 30856 | 2230821 | >> > | pgscan_kswapd | 1861981 | 7667629 | >> > | pgscan_anon | 1822930 | 7610583 | >> > | pgscan_file | 39051 | 57046 | >> > | pgsteal_anon | 386 | 2192033 | >> > | pgsteal_file | 30470 | 38788 | >> > | pageoutrun | 30 | 412 | >> > | numa_hint_faults | 27418279 | 2875955 | >> > | numa_pages_migrated | 356 | 1293122 | >> > +-----------------------+-------------------------------+ >> > >> > Signed-off-by: Byungchul Park >> > --- >> > mm/vmscan.c | 21 ++++++++++++++++++++- >> > 1 file changed, 20 insertions(+), 1 deletion(-) >> > >> > diff --git a/mm/vmscan.c b/mm/vmscan.c >> > index bba207f41b14..6fe45eca7766 100644 >> > --- a/mm/vmscan.c >> > +++ b/mm/vmscan.c >> > @@ -108,6 +108,12 @@ struct scan_control { >> > /* Can folios be swapped as part of reclaim? */ >> > unsigned int may_swap:1; >> > >> > + /* Not allow cache_trim_mode to be turned on as part of reclaim? */ >> > + unsigned int no_cache_trim_mode:1; >> > + >> > + /* Has cache_trim_mode failed at least once? */ >> > + unsigned int cache_trim_mode_failed:1; >> > + >> > /* Proactive reclaim invoked by userspace through memory.reclaim */ >> > unsigned int proactive:1; >> > >> > @@ -2268,7 +2274,8 @@ static void prepare_scan_control(pg_data_t *pgdat, struct scan_control *sc) >> > * anonymous pages. >> > */ >> > file = lruvec_page_state(target_lruvec, NR_INACTIVE_FILE); >> > - if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE)) >> > + if (file >> sc->priority && !(sc->may_deactivate & DEACTIVATE_FILE) && >> > + !sc->no_cache_trim_mode) >> > sc->cache_trim_mode = 1; >> > else >> > sc->cache_trim_mode = 0; >> > @@ -5967,6 +5974,8 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) >> > */ >> > if (reclaimable) >> > pgdat->kswapd_failures = 0; >> > + else if (sc->cache_trim_mode) >> > + sc->cache_trim_mode_failed = 1; >> > } >> > >> > /* >> > @@ -6898,6 +6907,16 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx) >> > sc.priority--; >> > } while (sc.priority >= 1); >> > >> > + /* >> > + * Restart only if it went through the priority loop all the way, >> > + * but cache_trim_mode didn't work. >> > + */ >> > + if (!sc.nr_reclaimed && sc.priority < 1 && >> > + !sc.no_cache_trim_mode && sc.cache_trim_mode_failed) { >> >> Can we just use sc.cache_trim_mode (instead of >> sc.cache_trim_mode_failed) here? That is, if cache_trim_mode is enabled > > As Johannes mentioned, within a priority scan, all the numa nodes are > scanned each with its own value of cache_trim_mode. So we cannot use > cache_trim_mode for that purpose. For direct reclaim, this is true. But, balance_pgdat() works for one node only. -- Best Regards, Huang, Ying > Byungchul > >> for priority == 1 and failed to reclaim, we will restart. If this >> works, we can avoid to add another flag. >> >> > + sc.no_cache_trim_mode = 1; >> > + goto restart; >> > + } >> > + >> > if (!sc.nr_reclaimed) >> > pgdat->kswapd_failures++; >> >> -- >> Best Regards, >> Huang, Ying