From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B0E1CF9C71 for ; Wed, 25 Sep 2024 06:38:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D15B86B007B; Wed, 25 Sep 2024 02:38:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9E2B6B0082; Wed, 25 Sep 2024 02:38:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3ECB6B0088; Wed, 25 Sep 2024 02:38:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 95ACC6B007B for ; Wed, 25 Sep 2024 02:38:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 36876160A22 for ; Wed, 25 Sep 2024 06:38:56 +0000 (UTC) X-FDA: 82602307872.22.C07F3D8 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf05.hostedemail.com (Postfix) with ESMTP id 90362100003 for ; Wed, 25 Sep 2024 06:38:53 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=D5+0nF39; spf=pass (imf05.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727246215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RGs30LQ1A4TM6FV8XP3SSHMAz2RdfiL1+U3eWyFr+pg=; b=I1CKjzjD2SROIDsNhm0iRaaY/HGYa833TbScHD4+LyINo5SPhwUtK5tll0q6qnGoUIv+1Q /x2CG1rq7MgVBfs3FELbjmuKaK4JNOHOGJlra36dTaCg0gKwYXvG5qau8Cd58eQ9yf/KPC 83AILWL+7qhiufD0j9A1g+Ag9tviFOk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727246215; a=rsa-sha256; cv=none; b=F8va2SD0WCWwZ1zhv3bst0xVysKJ77WBwQj2Ugd6JH9EGRKCLNajSidtgBzwzUHfCNEgW1 s85uh7Vkd5u2H2/Ln+8c8/Jmlp7QPrdGHzWJdKxnGWASwCkPR6j0irFITnKZ1vtxT0qNz4 rdqgvFYN1zblLx9FFYHI5CEDH4Wn9Ig= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=D5+0nF39; spf=pass (imf05.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727246334; x=1758782334; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=6wHn1ZNBI3zflu9447QZxVNpa2XP00kGb6kIjvg9OHc=; b=D5+0nF39I2hVDOxTIIDFUuaez8K8p+9Qn5/hnAFiO4UidtHNcPmBKfq+ OW4vmw5qfQyeiRmufb27VWsYIKvE5s38L4xP7NFa/IAZTep8m08AFBJwA 4teDG33l7wM2EJmYSOPx6Ai7JLtiQEahbdD8OFYPFLzNvbWl5ao4tBDbO 9AunQiaajb/0oUJS+chvIHms2eV0QtHnmmQFjiW4pOaqL892y1al9y47T vXKVpWiBZG2Ho09j/7oyjd2e7e92wea1MZQlUwM6SnnpRMGjaeC3qW/Ft BhZ+tFU00DsZBUq8+dg/dtaoF195QFneLWc1cQZqwo9fTlAPazWZ3MTld g==; X-CSE-ConnectionGUID: 5XDtKiWCQ6uH1QcjNcUBsg== X-CSE-MsgGUID: PcnJyedPTzWGweFI9MnOCw== X-IronPort-AV: E=McAfee;i="6700,10204,11205"; a="36940836" X-IronPort-AV: E=Sophos;i="6.10,256,1719903600"; d="scan'208";a="36940836" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2024 23:38:51 -0700 X-CSE-ConnectionGUID: Z0w/Ygh3QESI6yjFVM6kuQ== X-CSE-MsgGUID: iK+2YeupSDaBoFONzkeRjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,256,1719903600"; d="scan'208";a="71543955" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2024 23:38:47 -0700 From: "Huang, Ying" To: Kanchana P Sridhar Cc: , , , , , , , , , <21cnbao@gmail.com>, , , , Subject: Re: [PATCH v7 0/8] mm: ZSWAP swap-out of mTHP folios In-Reply-To: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> (Kanchana P. Sridhar's message of "Mon, 23 Sep 2024 18:17:01 -0700") References: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> Date: Wed, 25 Sep 2024 14:35:14 +0800 Message-ID: <87v7yks0kd.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 90362100003 X-Stat-Signature: mbzckh3kfjx1jybapyo9i5sjm5uymd9a X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727246333-454389 X-HE-Meta: U2FsdGVkX1+8YQUbCbHvmcg38ViE8ZdTt8GGsbqeQWh5at0dq72pNSx0awqtKzxbV5HzJdF9j0hp3DtxXGlBX03JzNZ75nKbS/c9d1Irk5jOpEt4/e59BT6wgJpUrPrajQLIZZ9R9kRrb8LVEm/BcwQi563U3EYaMg0LvYSXJciaDhJT3wuPes9gmwJF+UZNDIgtSS/gVlsVrmdsuDVklRPsTQ0nThO/ekf86jJ3uueYWc/EWJrtlt/hEbplSGK3Xx4Vr/J/lOY1TqBT3xd2viAuGJpJpk5PSrp6UBpzM7vjTMLQjZyk99mxeiat4oqThfuITqrlcce/8Wvtb3+etJ1IfdWUvB10HR8ptwIgLqappWXQT41xeaHOUhbza1og/0oaiZZLpeHqJtD1u+VnFAt6wXwAsBDspl0GHZ39sOgXV444W3FpDakCdjaK+lbuC1jUGfWPEG0ZuXG0i4txkqETUG2nXrdAZM1Io64kO/l0wL3fFyWuuYk+cS2YSSM3tdBr+KLKbN2hcmi27LRTAkeIoBi1F6f0n4mISQsbSfo5ymBLPSmnr8sb8OhM7grFGCeQqIsFYB0dkAax3Qaoh57xymo/3lMbyCKLPGM/DKfAO2Oq1yz9XcGFHtHyYy6Vs5ONnRDUr0/N3QNCijXgZcFwt2YCaCKFdsHHJB2v2anYCeCT9KaBX0XZaCMAMMI26cKfFHg/YK+qDztaiGKJbBymcn22mpFXU325kcZLlcJeoeQimiozJ1GrupDw4QiE85Xcv5D/kN+MzzNB2jbIG6wIbzWNaB179y8MKJxH5qcim6MhK+KjO+Rjvh+FVVScLfAZw4Dcuy/Ev+nVO/mQxsUTDpkDTvmStDpS9hc3ufowSnqcbV7YRQf2k8DV9bQbhIBTq/10681kuU3xzrnH/8FHCJwKqBj2rz/Ly6gzMjz4SFZ0xzJ8Vq0vg5Bjy+tBMn34hUhTIUcTgHJvMja 06sGAJ8Q aAqEnr6fKPivjuBUFj+KEyWp8osguF8eX46YMi3hUW/SLBFRFWGh+yXLPaD3qipn6STY0sASACuK7VYpBMBjK67ei+PVKDdH0KaadeB87GsQpEfKJ0MmbOjfpZgsA9yu9TNt/ZOP7KeJGwq055dn+PZTmqezB9k4eQVOXd7xAdewAFW89hMAbG4SDvH8mZX8FULAm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Kanchana P Sridhar writes: [snip] > > Case 1: Comparing zswap 4K vs. zswap mTHP > ========================================= > > In this scenario, the "before" is CONFIG_THP_SWAP set to off, that results in > 64K/2M (m)THP to be split into 4K folios that get processed by zswap. > > The "after" is CONFIG_THP_SWAP set to on, and this patch-series, that results > in 64K/2M (m)THP to not be split, and processed by zswap. > > 64KB mTHP (cgroup memory.high set to 40G): > ========================================== > > ------------------------------------------------------------------------------- > mm-unstable 9-23-2024 zswap-mTHP Change wrt > CONFIG_THP_SWAP=N CONFIG_THP_SWAP=Y Baseline > Baseline > ------------------------------------------------------------------------------- > ZSWAP compressor zstd deflate- zstd deflate- zstd deflate- > iaa iaa iaa > ------------------------------------------------------------------------------- > Throughput (KB/s) 143,323 125,485 153,550 129,609 7% 3% > elapsed time (sec) 24.97 25.42 23.90 25.19 4% 1% > sys time (sec) 822.72 750.96 757.70 731.13 8% 3% > memcg_high 132,743 169,825 148,075 192,744 > memcg_swap_fail 639,067 841,553 2,204 2,215 > pswpin 0 0 0 0 > pswpout 0 0 0 0 > zswpin 795 873 760 902 > zswpout 10,011,266 13,195,137 10,010,017 13,193,554 > thp_swpout 0 0 0 0 > thp_swpout_ 0 0 0 0 > fallback > 64kB-mthp_ 639,065 841,553 2,204 2,215 > swpout_fallback > pgmajfault 2,861 2,924 3,054 3,259 > ZSWPOUT-64kB n/a n/a 623,451 822,268 > SWPOUT-64kB 0 0 0 0 > ------------------------------------------------------------------------------- > IIUC, the throughput is the sum of throughput of all usemem processes? One possible issue of usemem test case is the "imbalance" issue. That is, some usemem processes may swap-out/swap-in less, so the score is very high; while some other processes may swap-out/swap-in more, so the score is very low. Sometimes, the total score decreases, but the scores of usemem processes are more balanced, so that the performance should be considered better. And, in general, we should make usemem score balanced among processes via say longer test time. Can you check this in your test results? [snip] -- Best Regards, Huang, Ying