From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE4AECFD2EC for ; Fri, 11 Oct 2024 08:55:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 616E26B00A8; Fri, 11 Oct 2024 04:55:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F9C6B00A9; Fri, 11 Oct 2024 04:55:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F1F96B00AA; Fri, 11 Oct 2024 04:55:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1CC9D6B00A8 for ; Fri, 11 Oct 2024 04:55:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BDCA3120AA6 for ; Fri, 11 Oct 2024 08:55:34 +0000 (UTC) X-FDA: 82660713114.04.31EE6C0 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf18.hostedemail.com (Postfix) with ESMTP id BB1451C0003 for ; Fri, 11 Oct 2024 08:55:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=miDBLWzq; spf=pass (imf18.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728636866; a=rsa-sha256; cv=none; b=3qDKkEE5imRzB4E03h0d8+ibt62jMNnjW/pUgpH/B2gYrpX/QVJVBblhsKq7b5eKSIjNTt pU7z44Wi2Hz0ZzpxpqcmM8betQiyQLvZzBjXscvC3Ocl4I8M4XCe99JYGdNFzFEWqjdhtb 1xzwqZEMEP1LFCGPLTyWxVpW/45VZK8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=miDBLWzq; spf=pass (imf18.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.15 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728636866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bWSiUO/ANDbJkCAU4JM5tdtyW4Nmb//r58eA8Xmqayk=; b=3lAqvWFiJ58kL/Iq7u1QOOV25yZsHOplg0t1XGhPOAkeY5b5gxYQFudnLorVUA2h4/+7GF G+dbj+d1inRiVmxTJyul2sW5VKqlMqua2KCl2Y3j0YsfKVRf0Y7ez1c+UKJVB/RIvldvUX MV2KJijTo1p5DrwszV1i2t8q6rCTKF0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728636937; x=1760172937; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=OXxFz4k46WgARgdzHOSZugPchaB1Wk40/hefIIy7htk=; b=miDBLWzq50VdZ0oWaBuPAT44S2e3nUHLSVn4pGaniZhFINCXHEt3KgDs PaHIB3Tz2bxTGdF3Xut5pLVXnBr8panIwreaTs2u3Zfv1vnUkuM/bOYox 3KhZFNjuAjGHBo4dhdbhLMEyinvzyW1CYYTrR0WxYjtRk/wx3qW6aYM0R FrPy5l1xIuWFkhAIdOe2YzYBuzSQVtAxtQkxDnuvgg25qToa2iY9nghVj occkx40h90DJ1D4ygSFLQdanYg2UwrXHmztCuC4jItXY97fdijJNk1EeT e95MKI3QBQjdBh0KyYQ1LNqxhUrOtJP04YsLMtyZj/SymcCN3Mn2s0dzb w==; X-CSE-ConnectionGUID: Ry8fDKLaQ8O06UJDSU9Vxg== X-CSE-MsgGUID: RY9g96wgSBOUhi0WfvsckQ== X-IronPort-AV: E=McAfee;i="6700,10204,11221"; a="31730362" X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="31730362" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 01:55:36 -0700 X-CSE-ConnectionGUID: GKIzN5oeTv2hJyQFiCOPvQ== X-CSE-MsgGUID: ZbYDYBjnRsCB03wIRpltyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="76472740" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 01:55:31 -0700 From: "Huang, Ying" To: David Hildenbrand Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Kirill A . Shutemov" , x86@kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Kai Huang , "H. Peter Anvin" , Andy Lutomirski , Oscar Salvador Subject: Re: [PATCH -V2] tdx, memory hotplug: Check whole hot-adding memory range for TDX In-Reply-To: <71dc3853-45a6-4fa5-b3c6-b165e0ab6a1b@redhat.com> (David Hildenbrand's message of "Fri, 11 Oct 2024 09:53:10 +0200") References: <20241010074726.1397820-1-ying.huang@intel.com> <037801d9-8923-4d49-8423-072fd7c73069@redhat.com> <87o73ra0p7.fsf@yhuang6-desk2.ccr.corp.intel.com> <71dc3853-45a6-4fa5-b3c6-b165e0ab6a1b@redhat.com> Date: Fri, 11 Oct 2024 16:51:59 +0800 Message-ID: <87v7xz81jk.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: oo6riikrdied3papptmo8gpy5t3du611 X-Rspamd-Queue-Id: BB1451C0003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728636935-75346 X-HE-Meta: U2FsdGVkX19q1polPJcp9jm5yeZ2PGDGxDRsqF6d134iZgX1v8vCk7yhB/CZWg8ql3d2JB55MbFt+qMAdKxyv4bC/EQOwJkMnrZtXR42Azwwvd0UtoFG6GTRhq61fTAeHjR1MCutQgLkgV7DXR0WSJc181oDhbrDrdItpyUGhU5gK7ftWhkD3kIB7UYJwJ7Mjn8hXmZ5Hwp6UVO0Q36TQS1E8GTB0Umjwl8uDuh65SNXdwk5GDVLXgNmBFCVH/XtV/UQ7Phw67hEZGQRnetEgu6NFrWxvLmewqfQebMURtv9F0dlEpobEFxXuuS93ZKLoxONkutIcFFUSy+ddtLuuO1MBILqtN8oilSulOW+MK1rw7GvbUXU3NUiGXA9LaTg4FSOaqtRVyAjSrxwmPjGAYrXwmYqq5pyhMtbTvA8RuqZ2x1XLsoDwAyZA3bucny1UDROE2zefwCyx3SoYskaELwYCvL0txL7UoB5+Y9JOzdHpkUwWj+q41YucFTAv8+gi7ukd9XYp3aNGQ0GxGr9VbcHxfi9pMkRjRcDim5mjAx1jQiB0jBJNVTiKjWdq9glccki5lwyri4kXzHBEk191M0rSMDub/dTJ1PwT1loWGc8n1qzu7slpa766qqtDvXlMvsViPGXkcD6iv1QMBYmtoyhGO14xzW+64TYwoTLjJy8TJNyrnCuizZZVHPyEVDM4EaOP82zmy5MPpRnwY8c6vECyjUDMQYmWk8TVw57ILE1Q+snOyOodqWqs8WFsfXN0hlaplUdyhA3VcTeaGJ7ZtSJ6KGnup1QrljI6G3qj3c+oHY1oseZXQ1ubpZ+VopmEYjI9/ovtCX3pYKD1o6Y5Is5UCwJPVoXpV7F3MNg8GlefQ2mmTavhE5S4URgCO6wxcxlI0IR0cQqaivU1XNalnW2ErXDqWpyDFXWqMH1xCvLu+z0SHS6yfDzCk+SaeSMVS3T+xDgJu5Y5NPF6js wZTELs0v 6WBPqMuEqUcmWNrPnE40fBjVjo4aPjBJh5XUOWrJD9At4NQ8Rf8086ll5Bi2xzSO61E47s3aiLcZ7rdYsW6YOq0wS/VP9iPEp0h8QGz4yZNw0NgZUu8EE8QRVGYamiQmzu9yD+D4HxGF/bB+ecmlSJ0MBkE3DsAK0ZyvK3z5jOehP0sU8sYRk+hac+NS1YNM68g2B X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 11.10.24 03:27, Huang, Ying wrote: >> David Hildenbrand writes: >> >>>> extern u64 max_mem_size; >>>> extern int mhp_online_type_from_str(const char *str); >>>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >>>> index 621ae1015106..c4769f24b1e2 100644 >>>> --- a/mm/memory_hotplug.c >>>> +++ b/mm/memory_hotplug.c >>>> @@ -1305,6 +1305,11 @@ int try_online_node(int nid) >>>> return ret; >>>> } >>>> +int __weak arch_check_hotplug_memory_range(u64 start, u64 size) >>>> +{ >>>> + return 0; >>>> +} >>> >>> BTW, I remember that "__weak" doesn't always behave the way it would >>> seem, which is the reason we're usually using >>> >>> #define arch_check_hotplug_memory_range arch_check_hotplug_memory_range >>> >>> #ifndef arch_check_hotplug_memory_range >>> ... >>> #endif >>> >>> >>> Not that I remember the details, just that it can result in rather >>> surprising outcomes (e.g., the wrong function getting called). >> I can replace __weak with #define/#ifndef. >> However, it appears that "__weak" is still widely used now. > > Probably better to avoid new ones. Sure. Will do that in the future versions. > See also > Documentation/dev-tools/checkpatch.rst > > I assume checkpatch.pl should complain as well? Double checked again. It doesn't complain for that. -- Best Regards, Huang, Ying