From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B373E7716C for ; Thu, 5 Dec 2024 05:39:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1D4B6B007B; Thu, 5 Dec 2024 00:39:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA4CB6B0082; Thu, 5 Dec 2024 00:39:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B45C26B0083; Thu, 5 Dec 2024 00:39:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 937566B007B for ; Thu, 5 Dec 2024 00:39:39 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0E743AE77D for ; Thu, 5 Dec 2024 05:39:39 +0000 (UTC) X-FDA: 82859802984.04.BB3C0C4 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by imf11.hostedemail.com (Postfix) with ESMTP id 38FC24000E for ; Thu, 5 Dec 2024 05:39:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=goWqzwGj; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733377170; a=rsa-sha256; cv=none; b=pufUg/UZkVP8Q6KmmOwpmxBWnUSB3ugZUG9eIsJRWjBO+p0dpp0M9rPkMp7o7A8SOjr2Zr poTZYV+MN8JANclLjOBq+ZFzlZZfkzPP8LtmsAcxDrZ8ClWXaavEQQwjMImihaHaw2GamV 69/tF7PaWkI7XQ8xu+zkXyQUvP9IX/Q= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=goWqzwGj; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.99 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733377170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eYNEZCdVidziIIvV5kKqn2NJL7IZHbjwLcQvEW69ZS0=; b=FA7uJ4nOX91aDj8r9Vigz2ibDOfa3bbtzmdomV0FYVIfwdzId9VHh7Q3m6nf3NQNBodLjo X3JLJa2VnKF2WyK3H7UEuVYmd/QykbxjiHo1DFjrQ1EvOlkVg3JiGZnIlBXXrmFSlM92Vc sN4xx4U6GxGcGgRlzENNepqYDQMdwqw= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1733377171; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=eYNEZCdVidziIIvV5kKqn2NJL7IZHbjwLcQvEW69ZS0=; b=goWqzwGjh0Wj10ACj9Zsv2VQYNBcrbO1WvzF1GLKdt91GIEo0RETBiYeAhaxQFJJbnM4FW0BW0BB88DcfDMyW8aWapK4bCzFV9Km9OxiT5LzXEo61BLaVWG/HF4/YSQMn4P0uDWe610fvgdWZNksjafUKIDMYiUzTJrKieBQFHk= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WKs2Vyf_1733377156 cluster:ay36) by smtp.aliyun-inc.com; Thu, 05 Dec 2024 13:39:30 +0800 From: "Huang, Ying" To: Baolin Wang Cc: akpm@linux-foundation.org, 21cnbao@gmail.com, david@redhat.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: migrate: drop redundant anonymous statistics for file folios migration In-Reply-To: (Baolin Wang's message of "Thu, 5 Dec 2024 11:53:48 +0800") References: Date: Thu, 05 Dec 2024 13:39:15 +0800 Message-ID: <87v7vy7kos.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 38FC24000E X-Stat-Signature: e6t1deq9txyyj87wahusjikksjeff676 X-HE-Tag: 1733377159-508866 X-HE-Meta: U2FsdGVkX18EaZ8ZZv1LWqtupT+dG0QF3oiXq7jMvmi9K5uAPUClikgr5snG8po+OrUQpQ8EW+GycymQt2qvcekhfT59gkzyjF66AA4/8+z8Skie8wS8RUyzBOb4IlwdJeRFF2rDm9iwlzm/IDooC2MLuoZkFKFEzEdmooHAMwkVm563y3sOS4VctiaqekY7MF9NEbiQmn3uaGyitxuIgM1PN/sKhD0z0pMwihFXpSF0uht8uOg6biWEXXUlGtMpNOGsWcCki5Eg2+bYwKkq14x5ORl6jF/8BU0lkSSsbGMzEsxqrIuXk9FKX1hy1uK6+ojZXmHWihVDgbbLGHI+ri9Z7U+CwflJiS/J2uMbg5YFw684m8G3JjlgwkTbtw2l1PyumHAzde+dN87l/kL4GbaRdHcEuxK70fCpY23pYJqLKXFbZQzcbffWeMT3OMxTWQ0Bf88U06Cj/Z5VR+cXA4xH4kb92ZSbXMrnMwPCVV2V79nVQB5XMyOXiQApW1W71rnJj0IVqL9FE3dIMjQGJ/Y6vXNeN399Z4HSXjtxAN8HO7OdfSoBYopGFiZukFjm6EeTTOCkVxZf89A3ywzgOk/yqt0ShmgRbfu6x/FvxJxv2OdND70u0vJTzzG4bZUPLO4xSXe8AJjp33aM6l9OcTvOJ6B2OO18tbDw+vPokHA1Upo7e6algj/HxwSLCoYqiB/66rEMl86Y4fJvksfW0qebsM3CgAALY6SsKfE04TDeCCWWaAtBEeItUbgefA/CvUxDLx2SUywKmAHUICb785KrD/dPU4gDl+3q25zK20Ifsx/QPNhKNWluIXx+vIHkRNuwoLLKf/iJIgSIev5O6iBHS3mQFlNzdEFQwelLJlIrZtAZ75kB6Dw8Ec+r5zWutbsLk4KYdULe/uEt7jLH0rQoSd16ezKqG1z7cvn7f9E4t5YhXJ6aGesMrOzcSyK0DLu+rUGRu6iPoNiG+ne 8zWRRuYp 9aVcHb7nYVJd6NTmfF6NE+vBO0Xl42W595lYlRcVAoXleiUKq56rkdQCh/O/UkA+/oHpibmmccL14jZal1MuboO8Yn7JS0mQEiBDTQorGjSvMo6PRx/yBBSRmCueYY978TybUbZs/qOP2GPL/jf37H5nfnJqf+fXlI19Ng+/kr88vQUNZ6UtmBrkRUvRd5RkY+GTph2E6FTitKbb1eey9pcRJdikQB6c9oaI1lzL40gsUNFM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Baolin Wang writes: > Commit 5d65c8d758f2 ("mm: count the number of anonymous THPs per size") adds > a new anonymous counter per THP size, however, when folio_mapping() is not NULL > during folio migration, it means this is not an anonymous folio, so remove the > redundant anonymous statistics in this case. They may be anonymous folios in swap cache? > Signed-off-by: Baolin Wang > --- > mm/migrate.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index e9e00d1d1d19..d7fdfdd23fd0 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -523,8 +523,6 @@ static int __folio_migrate_mapping(struct address_space *mapping, > */ > newfolio->index = folio->index; > newfolio->mapping = folio->mapping; > - if (folio_test_anon(folio) && folio_test_large(folio)) > - mod_mthp_stat(folio_order(folio), MTHP_STAT_NR_ANON, 1); > folio_ref_add(newfolio, nr); /* add cache reference */ > if (folio_test_swapbacked(folio)) { > __folio_set_swapbacked(newfolio); --- Best Regards, Huang, Ying