From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx188.postini.com [74.125.245.188]) by kanga.kvack.org (Postfix) with SMTP id 9D29D6B0062 for ; Sat, 9 Jun 2012 13:04:41 -0400 (EDT) Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 9 Jun 2012 17:52:09 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q59Gv9iL63176714 for ; Sun, 10 Jun 2012 02:57:10 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q59H4WOi026438 for ; Sun, 10 Jun 2012 03:04:33 +1000 From: "Aneesh Kumar K.V" Subject: Re: [PATCH -V8 10/16] hugetlb/cgroup: Add the cgroup pointer to page lru In-Reply-To: <1339232401-14392-11-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1339232401-14392-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1339232401-14392-11-git-send-email-aneesh.kumar@linux.vnet.ibm.com>User-Agent: Notmuch/0.11.1+346~g13d19c3 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 09 Jun 2012 22:34:23 +0530 Message-ID: <87txykfmco.fsf@skywalker.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, rientjes@google.com, mhocko@suse.cz, akpm@linux-foundation.org, hannes@cmpxchg.org Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org "Aneesh Kumar K.V" writes: > From: "Aneesh Kumar K.V" > > Add the hugetlb cgroup pointer to 3rd page lru.next. This limit > the usage to hugetlb cgroup to only hugepages with 3 or more > normal pages. I guess that is an acceptable limitation. > > Signed-off-by: Aneesh Kumar K.V > --- > include/linux/hugetlb_cgroup.h | 31 +++++++++++++++++++++++++++++++ > mm/hugetlb.c | 4 ++++ > 2 files changed, 35 insertions(+) > > diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h > index 5794be4..ceff1d5 100644 > --- a/include/linux/hugetlb_cgroup.h > +++ b/include/linux/hugetlb_cgroup.h > @@ -26,6 +26,26 @@ struct hugetlb_cgroup { > }; > > #ifdef CONFIG_CGROUP_HUGETLB_RES_CTLR > +static inline struct hugetlb_cgroup *hugetlb_cgroup_from_page(struct page *page) > +{ > + if (!PageHuge(page)) > + return NULL; > + if (compound_order(page) < 3) That should be if (compound_order(page) < 2) ? I will send an updated patchset with this fix and other review changes. -aneesh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org