From: Andi Kleen <andi@firstfloor.org>
To: Richard Yao <ryao@gentoo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Zhang Yanfei <zhangyanfei.yes@gmail.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel@gentoo.org, Matthew Thode <mthode@mthode.org>
Subject: Re: [PATCH] mm/vmalloc: Introduce DEBUG_VMALLOCINFO to reduce spinlock contention
Date: Thu, 10 Apr 2014 09:51:57 -0700 [thread overview]
Message-ID: <87txa1i0uq.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <1397148058-8737-1-git-send-email-ryao@gentoo.org> (Richard Yao's message of "Thu, 10 Apr 2014 12:40:58 -0400")
Richard Yao <ryao@gentoo.org> writes:
> Performance analysis of software compilation by Gentoo portage on an
> Intel E5-2620 with 64GB of RAM revealed that a sizeable amount of time,
> anywhere from 5% to 15%, was spent in get_vmalloc_info(), with at least
> 40% of that time spent in the _raw_spin_lock() invoked by it.
I don't think that's the right fix. We want to be able
to debug kernels without having to recompile them.
And switching locking around dynamically like this is very
ugly and hard to maintain.
Besides are you sure the spin lock is not needed elsewhere?
How are writers to the list protected?
-Andi
--
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-10 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 16:40 Richard Yao
2014-04-10 16:51 ` Andi Kleen [this message]
2014-04-10 17:09 ` Richard Yao
2014-04-16 0:28 ` Joonsoo Kim
2014-04-17 23:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txa1i0uq.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=d.hatayama@jp.fujitsu.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mthode@mthode.org \
--cc=ryao@gentoo.org \
--cc=zhangyanfei.yes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox