From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EEE7C432C3 for ; Fri, 22 Nov 2019 08:54:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5E85C20708 for ; Fri, 22 Nov 2019 08:54:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ig/SBx4a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E85C20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 136DD6B04B6; Fri, 22 Nov 2019 03:54:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E6E86B04B7; Fri, 22 Nov 2019 03:54:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F17D56B04B8; Fri, 22 Nov 2019 03:54:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id DB1806B04B6 for ; Fri, 22 Nov 2019 03:54:01 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 497D2181AEF30 for ; Fri, 22 Nov 2019 08:54:01 +0000 (UTC) X-FDA: 76183301082.25.angle55_7a49c4ddb9208 X-HE-Tag: angle55_7a49c4ddb9208 X-Filterd-Recvd-Size: 3533 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 Nov 2019 08:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574412839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F4QqIgWoaE+Xswep+dV48vmDan20VoXRhnYLhtuXiKc=; b=ig/SBx4an9jC50cDNRPiCD0dTMuoM+CJJ6CyWNul1mX0uMsrQcGkGJUV3xpPq6VGZue0vh luF6BlSX4bBn5yY9eyKHOH9hY8pcitI85uo44F3AtUPf/Wu89HAtbIi0Q53n5SPS3Rqjes SpeO1dRNr3OnItp8914KsmEJL6ADIIg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345--hvr_qoHP9aBliNVjr4Nnw-1; Fri, 22 Nov 2019 03:53:56 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA01C1085986; Fri, 22 Nov 2019 08:53:54 +0000 (UTC) Received: from localhost (ovpn-116-217.ams2.redhat.com [10.36.116.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93FDD61F36; Fri, 22 Nov 2019 08:53:53 +0000 (UTC) From: Giuseppe Scrivano To: Mina Almasry Cc: cgroups@vger.kernel.org, Mike Kravetz , Tejun Heo , Li Zefan , Johannes Weiner , linux-mm@kvack.org Subject: Re: [PATCH] mm: hugetlb controller for cgroups v2 References: <20191121211424.263622-1-gscrivan@redhat.com> Date: Fri, 22 Nov 2019 09:53:52 +0100 In-Reply-To: (Mina Almasry's message of "Thu, 21 Nov 2019 14:36:12 -0800") Message-ID: <87tv6wmgv3.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: -hvr_qoHP9aBliNVjr4Nnw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mina, Mina Almasry writes: > On Thu, Nov 21, 2019 at 1:14 PM Giuseppe Scrivano w= rote: >> >> In the effort of supporting cgroups v2 into Kubernetes, I stumped on >> the lack of the hugetlb controller. >> >> When the controller is enabled, it exposes three new files for each >> hugetlb size on non-root cgroups: >> >> - hugetlb..current >> - hugetlb..max >> - hugetlb..stat >> >> The differences with the legacy hierarchy are in the file names and >> using the value "max" instead of "-1" to disable a limit. >> >> The file .limit_in_bytes is renamed to .max. >> >> The file .usage_in_bytes is renamed to .usage. >> > > I could be wrong here but I think the memcg files are not renamed, so > the same file names exist in v1 and v2. Can we follow that example? I've enabled all the controllers, but I don't see files under /sys/fs/cgroup that have the .limit_in_bytes or .usage_in_bytes suffix. To what files are you referring to? Thanks, Giuseppe