From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE84C433DF for ; Wed, 27 May 2020 00:17:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BCA2B206C3 for ; Wed, 27 May 2020 00:17:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="Hsk6C452" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCA2B206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 131A4800B6; Tue, 26 May 2020 20:17:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BC6380010; Tue, 26 May 2020 20:17:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EECAC800B6; Tue, 26 May 2020 20:17:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id D2DCF80010 for ; Tue, 26 May 2020 20:17:06 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8E4A53D05 for ; Wed, 27 May 2020 00:17:06 +0000 (UTC) X-FDA: 76860584052.21.dust70_1d095f826d4d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 78E70180442C2 for ; Wed, 27 May 2020 00:17:06 +0000 (UTC) X-HE-Tag: dust70_1d095f826d4d X-Filterd-Recvd-Size: 2913 Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 00:17:05 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49Wrx71vKpz9sSF; Wed, 27 May 2020 10:16:58 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1590538620; bh=4XXmvXXfgbRN/jQoHPVi4ASoxTVhtQ8D1zRlN09CNaY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Hsk6C4529uGHiB6Qxtg7/t3N2n3844F+cEuC8SeuUCCZKR7ee0Sar9o4zhzuh7JYj NKqNMr0uteOA0OqstxVzUr0bzzstJGvfe6jATVRozDO/Utf/mGj4yBmjvd1vql6G68 v8yTuY6c0dOV6PSfbarX8eUGFhcE4L/CHpVuCJLaM7qmr/EtiMBUmfWzftNw/DQTlt k9qfU1sNhvDq9q2MVI3qXDTnbOiI9KJNkE7Wgi9AEKU71Enz1Zf6O6e3lMcPB6hUzy 4dVFoN1L+SX5BKrAwP7SyR6EMPRB/HKCd7P8rvC/qBv7AhK6fJbGL/7w/gor91XbWz brZ2CiCNtw6/w== From: Michael Ellerman To: Sandipan Das Cc: linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linuxram@us.ibm.com, aneesh.kumar@linux.ibm.com, bauerman@linux.ibm.com, fweimer@redhat.com, ruscur@russell.cc Subject: Re: [PATCH] selftests: powerpc: Add test for execute-disabled pkeys In-Reply-To: <6b73bf3f-0d10-6e8c-acd9-27de53573dec@linux.ibm.com> References: <20200508162332.65316-1-sandipan@linux.ibm.com> <87367mg9h4.fsf@mpe.ellerman.id.au> <6b73bf3f-0d10-6e8c-acd9-27de53573dec@linux.ibm.com> Date: Wed, 27 May 2020 10:17:22 +1000 Message-ID: <87tv02dyel.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 78E70180442C2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sandipan Das writes: > Hi Michael, > > On 26/05/20 6:05 pm, Michael Ellerman wrote: >> [...] >>> + >>> +/* Override definitions as they might be inconsistent */ >>> +#undef PKEY_DISABLE_ACCESS >>> +#define PKEY_DISABLE_ACCESS 0x3 >> >> Why would they be inconsistent? >> > > The definition in sys/mman.h still uses the value specific to > Intel's implementation i.e. 1, when this should have been 3 > for powerpc. I have seen this on Ubuntu 18.04 and 20.04. Hmm OK, that's a bug but oh well nothing we can do about it. >> I think a reasonable solution is to use the absence of SEGV_PKUERR to >> basically turn the whole test into a nop at build time, eg: ... > > Or can I use this from the pkey tests under selftests/vm? > > static inline u32 *siginfo_get_pkey_ptr(siginfo_t *si) > { > #ifdef si_pkey > return &si->si_pkey; > #else > return (u32 *)(((u8 *)si) + si_pkey_offset); > #endif > } > > Where si_pkey_offset is 0x20 for powerpc. Yeah that's fine if it works. Please send a v2 with that change. cheers