From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF980ECAAD2 for ; Mon, 29 Aug 2022 07:28:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F749940008; Mon, 29 Aug 2022 03:28:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A724940007; Mon, 29 Aug 2022 03:28:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02046940008; Mon, 29 Aug 2022 03:28:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DFE5C940007 for ; Mon, 29 Aug 2022 03:28:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A8D178012A for ; Mon, 29 Aug 2022 07:28:09 +0000 (UTC) X-FDA: 79851801498.23.C5FFF11 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2081.outbound.protection.outlook.com [40.107.93.81]) by imf09.hostedemail.com (Postfix) with ESMTP id 3052C14000A for ; Mon, 29 Aug 2022 07:28:09 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zt512D3wwEit8GZIVMOoUj0tI6eQAilOEA1fenWvfiFpI7gWRr2RDEiCmUBsL6n0EboDPZa9Z85xPfa5/z3TQRSWI64q+HUUazt5Ev3XdzVoJJLxhJI6hG/I42DfSlYWqutDzni3aD0N9qd7EFs43LQHlyxbPBc4uAbJiTW3AyFIk1pFop/1gq9PDvRCranua8KalYl7H4gTWCCfH0hJaUwpW6ageg0bjhvgwKEyTUbDl4kJG2o9AOuXt8M/e1ek8K3YLtVYND6sQecq7mzLF7ifDre4E9WzWmbXjKbYW3MaN1umXjTiaUkOmLUd2aQ2K2MGRYutmyX6KvovTQMICQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nlm0Q3pfCGxqn7V25vx6BMGXEpGEq/8V5NraL68wtmE=; b=oS5IcNZZxvRb3diBWRR8MNq7mWaKrXRfJJ+uY3Jk5Ko9p15INFyGT7xW62piMYQGOg0mEDVzbWkkEKYlK5SzUH/0/N0cKmklR2lLzOj+gSiyKOKKWtbIi7lUphPgRX+RTDOUABzospMcvCHxez5Pg/1CB+l2Y3788owONyunWy851ZEnNFRDDJoYA4AxlmAdn4XUD2pNMuyIrdiPpuWevHWFp7dvG+Yk/fCq6w0WSeN/8iOtB6PDSvjJIVen+mfDdgnYVKjDEuQ3CvJG6qgP4+xhsuw5eIWDrO+CmiHXGO/pvoLVzZoa3OJXFilShYGLkFGRp57h49km9faAflYUHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nlm0Q3pfCGxqn7V25vx6BMGXEpGEq/8V5NraL68wtmE=; b=XLnbh5T9LCtvLiQciUS/fGI+nvttJYgTkFak4f3A7smE0fiboGn4NLmfcu7v4TwFL6ozfqjjH9BRCdQ+h+7HrNg7x41l/linSziBdI/IVt1QBgqlAAtwYqt93+jaz6dedOMrmcSSf/R0ytIyVa5ZR5vMhlyxBb9Mp+zNHCaTpnrUzXYSn6eOon1mCzwzPqfiP9ZqvHpErwkHEbria1xVQ0PEXRM73Jc3jyGfpXQQXomMt39uwi9zXyWFvAey2xSrM2dWQt6OYYQcOVhqxDrBCOCme34DkeDueE8u5QtMToZL1FvNgRD5PLzbpzPdffzla6h2jdXKnGzI99WzFHSuwQ== Received: from BYAPR12MB3176.namprd12.prod.outlook.com (2603:10b6:a03:134::26) by CH2PR12MB4807.namprd12.prod.outlook.com (2603:10b6:610:a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 07:28:07 +0000 Received: from BYAPR12MB3176.namprd12.prod.outlook.com ([fe80::7432:2749:aa27:722c]) by BYAPR12MB3176.namprd12.prod.outlook.com ([fe80::7432:2749:aa27:722c%7]) with mapi id 15.20.5566.021; Mon, 29 Aug 2022 07:28:06 +0000 References: <20220825014905.977168-1-apopple@nvidia.com> <877d2v7rhf.fsf@nvdebian.thelocal> User-agent: mu4e 1.6.9; emacs 27.1 From: Alistair Popple To: Peter Xu Cc: David Hildenbrand , linux-mm@kvack.org, Andrew Morton , peterx@redat.com, John Hubbard , Ralph Campbell Subject: Re: [PATCH] mm/migrate_device.c: Fix a misleading and out-dated comment Date: Mon, 29 Aug 2022 17:09:25 +1000 In-reply-to: Message-ID: <87tu5v7blr.fsf@nvdebian.thelocal> Content-Type: text/plain X-ClientProxiedBy: SY6PR01CA0066.ausprd01.prod.outlook.com (2603:10c6:10:ea::17) To BYAPR12MB3176.namprd12.prod.outlook.com (2603:10b6:a03:134::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5bd1ee2e-551c-4be7-4d7c-08da89900451 X-MS-TrafficTypeDiagnostic: CH2PR12MB4807:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KxFqq19PC/GZSPXbnN1R7FDhNszqZVYJT343K7oXMCMBnAWgcyaSh3SjbdN3mgOz+u0zV/qsZHkH4maTMNgCNQBlDTf5T9aGf3hDafulqJeE1ku08npWMLfhB/1L0bMfDVh8WMHVLrP3WEQAT55IQbJjSPpRqAzPvX7gKjFCXjlV5DppHwJvniDQcyORmzuaQGRjbnW752hFJayad95BCTOISEWAcpKRAzjwvyPNotcOUhQJSL4qR1ZpO303EKSCNA8ge2nvyq40fSEZMqlLLtStAvpWpNwxTfdm68oiF4BsbwD3kcczkH2cozlh59rEYkV9W6dmUz/AILhoVDfyhwM1cx3tb7j70ggZkZhqtxSUpgunzeI3lEPzpzWWLNe5TBtGMdK4YIp2piTnlZeN0NPCj4vas6CBo6s9+qd7DpwCF6H2ySzvlrkkMVgB/BBvNOd23BIWuIITejX9h5RWRmgiOIv7I+mM7wdgo3XwsBt/gHiMe10ikTMyyWeKY1miE2a45sgN+J4MX+VVquKtWVHgiowjj9gb9lREKDCbYQ2pop/Q/xiW3nZ5kn4hRgUMdfM60wY9YKeDMTumazjaBCezZeOYxXo/Kiy5yigomj4ZgV3wVXo/Y9syYA4ptexevTOpoEHaeT7mJHqwSy3b2pHKIxzuodUEqs/jFJDeNR0ZpS4DVZvIrP1EPU+zG1xK/LpJnu/H79mDaaJmTGCM6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB3176.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(366004)(346002)(396003)(8936002)(107886003)(5660300002)(4326008)(316002)(2906002)(54906003)(86362001)(66556008)(66476007)(66946007)(41300700001)(186003)(6916009)(8676002)(9686003)(6512007)(6506007)(26005)(38100700002)(478600001)(6486002)(6666004)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZOwPf2bRRhKSjKtDkPoCINADEChUw5Pyn1mWCK/yNxtdVAPRSzF6RSqIYdb2?= =?us-ascii?Q?cKVcCepnImuhNGoTa+XE6dGiZu4uLFc/d/qre/UG/3htaWngUp6FXaPjStPl?= =?us-ascii?Q?h2Tg3tTJbWqT9F/ofxhzkE9x3emz6xmJgTnK+QkHgzllIiEbHPGMnV5xW6lx?= =?us-ascii?Q?gJfYMzII/zSUcHHnwh0yvUQOkRrcXh8P+LStfRP8VVaYXAWs6NT8ThKTdq0G?= =?us-ascii?Q?esNt0wuOpdym4kyc35I/Zjm4tkzulm7XRUM1kF+zU5HiiCOlQqyVy7kMf0a2?= =?us-ascii?Q?bKvg7aUSJoRxmJiZZluhxwbEgSMJBxMy6wpNpnnqqpYkGtpu1UsymCZP7YWd?= =?us-ascii?Q?if60DLRbtL4+qr1iGdYVdckzNIXNqY32rWIXaVHxcbe6TSB4iGmMiw2yo4Vk?= =?us-ascii?Q?dzkfxALSTBZj2Ouv7Wti4TjtnFX7lSzwYwsytAH23CCsyJu8+4AJDM8fRyQh?= =?us-ascii?Q?ss3iCZY+QAWnyfG9ENkpdscDxojQMfiw8iiiGjmfyDt+EoQBVqwxCAuJjqdT?= =?us-ascii?Q?OSbccoj5DUIuOpSW6gzFXahoGAJbudTFdhyqWK+dauQ3Df2ykgPEv7JJbtqF?= =?us-ascii?Q?nLQfSLGZQHBl2qHQnNS+2Kr0WDBed4wGKIpzF8YupiGzxWADKrVInS1nVtyG?= =?us-ascii?Q?WdJfupS+4wr7iSvqkW4/A2l6O2gPu/jT5agE6AewkK+jTbdtYEicpoQWsa4v?= =?us-ascii?Q?5Y7G36AuG0dBXQmxSRccGStwIumLzGb07cz7I9o+bFhVVzM/jSdL0IwgKwp/?= =?us-ascii?Q?Cfk5RfzptcLrEuyJuWoIpOrr3a8T1yB+TPbJ649gVAWpAAAZZuMnNyoB3gz8?= =?us-ascii?Q?5enwLLj6H5Jr7kfM024eUR0RR12efet8T1EXmqzYvbE1Eyyn3s84Tfvo0uCa?= =?us-ascii?Q?VFOQputHIApCMg54Knh5l6aJD/XpxTrHkTj1hyl3xbGBpZiL/kuuMnelbpUV?= =?us-ascii?Q?aTDDAla1D5gEeXXnBc09YFwOWo3ujIM3thJmRPGIY3J7zlXDNqqjXY4kvpuB?= =?us-ascii?Q?Da6T70a4FGgi9D5Cayw+McohR0HSqY4c8UPBbUya1aRNvPc8WCyo+XJ61TeX?= =?us-ascii?Q?kQllamhPyb9KuEBvVfRYaBmaF0B3bILcB41KRaQ4g2LrRiwzGR76TZFUqlNW?= =?us-ascii?Q?47Ky+s2XmQAV4be1IJc6jOBphC8mP5Jq1G2zu94fIxJ1myZKnyNhPSOU26Gc?= =?us-ascii?Q?kMl7qLMUzJEhWjKFnOsVal85XZAjeAQAZpnvh0tAdeOMuwQTifdkwmMSujAd?= =?us-ascii?Q?nHDv1Cd7SsbDIAs4+bvGUdHw/r19NUkc4NGfhCs+hyqrDqdxGiDxRE4CEjh+?= =?us-ascii?Q?0MAeqW5wGhKUnqNmMYWO197zMflJuoo/P0bXkYcU65moHns0tjQhzocal4Po?= =?us-ascii?Q?6y+1GCVHprOaSXpa3coWOBh7GZOoj927vptVLp36Kb4dZXYz1KW1sHj5wsPW?= =?us-ascii?Q?hr+Uzw5xhGrRdfgkcGpP2JNzgSijIJ7gGQhxG2I/FpmJwQ8RPunxKGlFXLgK?= =?us-ascii?Q?tVtAgpA2poTdq2DGJeg6v3WOzMTzgyi7lc0lEBILghLmubJxAsvpjXI6DEoH?= =?us-ascii?Q?4SaCeU3GCY3ZNP+bu0ErqLRs+nR5QiX0h1Z+Ts8h?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bd1ee2e-551c-4be7-4d7c-08da89900451 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 07:28:06.8641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1BGfNfoRUaAZximIkwMm2KHzw94JlkMoY/rm8RvZpBYhsz4n933h6ubkZ3NHHixC4OMNIMPoswDRaRrdaLJJBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4807 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661758089; a=rsa-sha256; cv=pass; b=L/rusoNBWdox1pE4mOhdaSLvqgYbuZScaj9Y3slfezvuJzMmZB5wbGJGbpUv/BDqYi0O6p DV9uIPXh0XQ4ahZEiUYdrX3hziLj6FAORiXCoXQ3L2PNVwrYlBA1IolLw4QdyzCwlevFNE +IOdGuIhRb2r0w5uMf4ElV6xPG8nvT0= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=XLnbh5T9; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf09.hostedemail.com: domain of apopple@nvidia.com designates 40.107.93.81 as permitted sender) smtp.mailfrom=apopple@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661758089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nlm0Q3pfCGxqn7V25vx6BMGXEpGEq/8V5NraL68wtmE=; b=w2hbEtlZYb1Tmfkrn6jkmFetnW++5lkRidti9ovb4oGxcy85Lc1nGv0X490jyivTNtgLa3 85jm0NL8NPcFUrheTrT+cJ+fJ8l/tWZlFWo1Ia6py9f8IGf4UfDmTdlwvPBpId4q1Eez4d GHs7PTa4tfIf/0tKzfC/++nVyL3eCvM= X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=XLnbh5T9; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf09.hostedemail.com: domain of apopple@nvidia.com designates 40.107.93.81 as permitted sender) smtp.mailfrom=apopple@nvidia.com X-Stat-Signature: 4nrjdf58p4sqxts3mettot4o3xurbagq X-Rspamd-Queue-Id: 3052C14000A X-Rspamd-Server: rspam02 X-HE-Tag: 1661758089-37825 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Peter Xu writes: [...] >> >>> Meanwhile it'll be great to also mention about why trylock is needed and no >> >>> further attempt to use lock_page(). The comment in prepare() previously >> >>> was great but unfortunately that code clip was removed. >> >> >> >> Will add. >> >> >> >>> In short, do you think something like this might be clearer? >> >> >> >> I think it's important to mention the optimisation, otherwise the >> >> temptation is to remove the installation of migration entries here and >> >> rely on try_to_migrate() to do it later. I would actually like to be >> >> able to do that because it simplifies the code in many ways but based on >> >> my testing the optimisation turns out to be very worth while. >> >> >> >>> /* >> >>> * We rely on the trylock() to migrate the pte. If this >> >>> * fails, we'll fail the migration of this page. IOW, the >> >>> * migration is very much best-effort, just like we'll also >> >>> * bail out if we found page pinned by other users after >> >>> * page being locked. >> >> >> >> Honestly I think this describes what the code does rather than why and >> >> is likely to become outdated and confusing. IMHO it's quite clear from >> >> the code that the migration will fail here if we can't lock the page. >> > >> > If you see that's what I was struggling to understand previously, so not >> > clear at least to me. :) Since normally a function like page migration >> > should (from the gut feeling) not rely on trylock only. >> >> IIRC, ordinary page migration will also only trylock. See >> isolate_movable_page(). > > Fair enough. > > I think it depends on what we want to do with the migration. I think not > even all users of isolate_movable_page() only depend on trylock, and it can > retry with lock_page later. E.g.: > > - soft_offline_in_use_page > - isolate_page > - isolate_movable_page <----- trylock here > - (if isolate_page fails...) migrate_pages > - unmap_and_move <----- lock_page here after 2 unsuccessful rounds > > And I also agree migration may always fail (e.g. by spurious page refcounts > being taken), so feel free to ignore the "gut feeling" - that's indeed kind > of subjective. So how about the following: /* * We rely on trylock_page() to avoid deadlock between * concurrent migrations where each is waiting on the others * page lock. If we can't immediately lock the page we fail this * migration as it is only best effort anyway. * * If we can lock the page it's safe to set up a migration entry * now. In the common case where the page is mapped once in a * single process setting up the migration entry now is an * optimisation to avoid walking the rmap later with * try_to_migrate(). */ Thanks. - Alistair