From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B5A0C433FE for ; Thu, 29 Sep 2022 22:17:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BD688D0001; Thu, 29 Sep 2022 18:17:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26CAE6B0073; Thu, 29 Sep 2022 18:17:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 136A48D0001; Thu, 29 Sep 2022 18:17:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 02DB56B0072 for ; Thu, 29 Sep 2022 18:17:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CA2AC161370 for ; Thu, 29 Sep 2022 22:17:39 +0000 (UTC) X-FDA: 79966535838.02.598058E Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by imf28.hostedemail.com (Postfix) with ESMTP id 67687C0016 for ; Thu, 29 Sep 2022 22:17:38 +0000 (UTC) Received: from in02.mta.xmission.com ([166.70.13.52]:56266) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oe1qa-002lKm-T6; Thu, 29 Sep 2022 16:17:36 -0600 Received: from ip68-110-29-46.om.om.cox.net ([68.110.29.46]:57822 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oe1qY-000QBy-Up; Thu, 29 Sep 2022 16:17:35 -0600 From: "Eric W. Biederman" To: Lukas Bulwahn Cc: Kees Cook , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220929203903.9475-1-lukas.bulwahn@gmail.com> Date: Thu, 29 Sep 2022 17:17:28 -0500 In-Reply-To: <20220929203903.9475-1-lukas.bulwahn@gmail.com> (Lukas Bulwahn's message of "Thu, 29 Sep 2022 22:39:03 +0200") Message-ID: <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1oe1qY-000QBy-Up;;;mid=<87tu4p3jwn.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.110.29.46;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX19PmXCMvq3dJ4UVR1Zc7W458rz2Nb6AWpM= X-SA-Exim-Connect-IP: 68.110.29.46 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.232 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664489858; a=rsa-sha256; cv=none; b=WttYqIyHb78iVpxDLdG4+wa5/OaYzzimBG6yD2Q8BNLbCjFz1yFbyWYv4FyZu4JtpbsbP1 QrEE0MufKZ55KFsdxfqcfv8s1rxyvOa5AoXBfhNPcH3zvhNLpa1phMUPEmgYF6LlCIVnz1 fTp9TplFu6lGpkD+UcZ7y4pH56yLYQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664489858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=88dmL/KyJbg6kdJCYCLL8YsNx20DokbJJPaGi2mr/to=; b=i+HNeDj8jX9YxUrwwRN9MoABaRZXAuUHtVQFio1i0LqByoTM8OKWZf0ihyMUFeIIKWZYQf JYndjO+xJV2fpOvZvhezm+jT+NjC+nkbx0o+OCPK1FnW00RPvw10/qi2Fi89APqy/nU4d4 jAhcf5cDPfaFi5ZCI71aVaeksaBBG6c= X-Stat-Signature: 86pqzntnhjpzkxjmyrxssy13jiw6turb X-Rspamd-Queue-Id: 67687C0016 Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.232 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664489858-504506 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Lukas Bulwahn writes: > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the > use of the special taso flag for alpha architectures in the linux_binprm > struct is gone. > > Remove the definition of taso in the linux_binprm struct. > > No functional change. Reviewed-by: "Eric W. Biederman" Alphas binfmt_loader is the only use I can find of that variable so let's kill it as well. > Signed-off-by: Lukas Bulwahn > --- > Kees, please pick this patch on top of the commit above. > > include/linux/binfmts.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h > index 3dc20c4f394c..8d51f69f9f5e 100644 > --- a/include/linux/binfmts.h > +++ b/include/linux/binfmts.h > @@ -43,9 +43,6 @@ struct linux_binprm { > * original userspace. > */ > point_of_no_return:1; > -#ifdef __alpha__ > - unsigned int taso:1; > -#endif > struct file *executable; /* Executable to pass to the interpreter */ > struct file *interpreter; > struct file *file;