From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD9CC54EBE for ; Mon, 16 Jan 2023 06:09:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 651CA6B0071; Mon, 16 Jan 2023 01:09:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 602286B0072; Mon, 16 Jan 2023 01:09:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A3726B0073; Mon, 16 Jan 2023 01:09:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3779F6B0071 for ; Mon, 16 Jan 2023 01:09:19 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 071D7A046C for ; Mon, 16 Jan 2023 06:09:19 +0000 (UTC) X-FDA: 80359634838.23.D8B193A Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf16.hostedemail.com (Postfix) with ESMTP id 9D28F18000D for ; Mon, 16 Jan 2023 06:09:16 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MT1EHSr8; spf=pass (imf16.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673849357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TgrCeNc+ZXSjTMK/Rl3cdubwt0S+4uvb8YuoUyQIQc0=; b=cSePBoRyGwGCVyXNlYiC/yWfSkT/bSgJec9UuC/iIdv+jc2sFr8egovaYgEKIy0z1Itc4P tt/vN4D7jd6fSce8QlIrO7EjywcLVMrzEe4n4TIT2GccYfbDX2VTNhr+JVN0Wn33I9uryx kvzxFCwppIvAApcmGzrEq2i6ypPlcB4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MT1EHSr8; spf=pass (imf16.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673849357; a=rsa-sha256; cv=none; b=cy2U8cD6Q0USGQFDhIxd4w6s9+ZYl+9fe2yNzc12lf6WbWCfuaTPhbshaLbjFAaLpXP9yd fyFTmvFp822/JeJevFAZ5O3vVnbp+zuvk+cOf7mIJBsvqJSF15hHuQvQPZE3krSGKZid9D z8Bz8lLQ1pQj//uYsmrnmch7LZog6Mo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673849356; x=1705385356; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=Xsc4GUy7+oLMqhOpp6Kb6Rp92S0nxU9kPRmZIpDv7FY=; b=MT1EHSr8mxwBQkPzFBpaQ/HW86avZJjY6RrJKXA9xKecHEGuYfyKBfYn 25ElzybleSyNL0ZZO4pbvsP3dq6BFMUfuGmRMDgc3J8B4t2JBNINEMjIl gLiiQs95HnOcFf5OYDrktHlKmTw33sVNxizt0A8VxB/5P2Qwef0LtlMrQ rKrUhPBC0qPv37Nx8oxil+0Sv2/zembjH+6UVIJBzxa/vdhtZjS/taPiA jFDTR/YmkLrSDJK7GmNURNBjgVcLmeAROaPJlXfi3+aWojRsDd+tZP7+F tv+9u03VjtieYh3ps0dsu40Tz2aYJrqEWrVL5Ie+MB+FFo69/SssdcF7i A==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="312246865" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="312246865" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 22:09:14 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="652164748" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="652164748" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 22:09:11 -0800 From: "Huang, Ying" To: Matthew Wilcox Cc: Mike Kravetz , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador , Bharata B Rao , Alistair Popple , haoxin Subject: Re: [PATCH -v2 0/9] migrate_pages(): batch TLB flushing References: <20230110075327.590514-1-ying.huang@intel.com> <87a62oy5o9.fsf@yhuang6-desk2.ccr.corp.intel.com> <87ilhcrzkr.fsf@yhuang6-desk2.ccr.corp.intel.com> <87bkn3rw8v.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Mon, 16 Jan 2023 14:05:44 +0800 In-Reply-To: (Matthew Wilcox's message of "Mon, 16 Jan 2023 04:35:31 +0000") Message-ID: <87tu0rqaiv.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9D28F18000D X-Rspam-User: X-Stat-Signature: njq35qeugfzyehc5apy8hwdyum1b57cx X-HE-Tag: 1673849356-490822 X-HE-Meta: U2FsdGVkX19vR13YYbf34p4IfmJao0ZJx+tLmBiQmTkIVh0TZid9dc48rxgNJIpWJYOYWUYYfXA1UVef1JC1sSAa72Cb2EOpHKZF3DJ4j/fDSU4fKXoGzo2NqC0yAyG3RY5cDa0OWq1T2QxFBkAS6uFxqzq2ZVy+i0fUivyLBUaNML8L85MEOBfZAazQyV1WJ3SUHmfcXGhgTkVbGbEjerfMCqmGxosXIhcnEf6E6rdExqg5el2REiV4G7KI4UhcbFAURH2EzU76aS0GjvXLrWiR3enIviBglUMjEX0RMWFos7KrqpcG87XbxmraSJzdYV8rVoAHHTT10nRTzXWMw/Dxd81ysm41FEylMbi+YIGdyaMRbmhJ5GEQ83ZUFyyVxAsITgwBi0CeLkAGNDH88y470Rf7IOFV7B3qeDaJDj8dL0R9YWQvo1q/xTygvnnLnRXWuviWQi1Nd/EyylsQJXDGd5hpabApe2fC39xSV+7QkNCjcS9aMQfSV2Ycw73xbh79ErAwxJBX/z+hPj4qMweJz38ddxqDFn+ILXcRVdLVhDUTdIaiIQ62QA/uTsyLiRpL/N9xQMfOLI51TS57QD6bdnB5acmaLO8itIw+d2OBCOkjcZEGQXNtpct3ePGSljv9nCcpMRsx4yTM8pUlPI00h30v68SqMlgUpXnJXIVNPeHdvBQu4KSVlOeO5WUQcJTw8Hqom4mvq7LUBf9/Blj2V92jG/eZhTlP4MROyI/a/pXD/cIyl0RbtqR6r65ntAqgn5Y2fTly0SbyFNJ4MoBMu4lrODGZ48fmRNqKweM/Xg/iMw0kiqfVMWisHGrgkaHW0LJYab/eZo162Jq04+4P4vuaFUzILNOGIcoz0zdD0VjvNi/hGb8R4tuuHHVEcLBxdjkx/pgRYY6dHiibrTVWwBCnvZx0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: > On Fri, Jan 13, 2023 at 10:42:08AM +0800, Huang, Ying wrote: >> +++ b/mm/migrate.c >> @@ -1187,10 +1187,13 @@ static int __migrate_folio_move(struct folio *src, struct folio *dst, >> int rc; >> int page_was_mapped = 0; >> struct anon_vma *anon_vma = NULL; >> + bool is_lru = !__PageMovable(&src->page); >> >> __migrate_folio_extract(dst, &page_was_mapped, &anon_vma); >> >> rc = move_to_new_folio(dst, src, mode); >> + if (!unlikely(is_lru)) >> + goto out_unlock_both; > > This reads a little awkwardly. Could it be: > > if (likely(!is_lru)) > > ... but honestly, I think the polarity here is wrong. LRU pages tend to > outnumber !LRU pages, so shouldn't this be: > > if (unlikely(!is_lru)) { > > just like it is in migrate_folio_unmap()? Yes. Thank you very much for pointing this out. Will fix it for the next version. Best Regards, Huang, Ying