From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B23D1EB64D7 for ; Wed, 21 Jun 2023 07:47:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38C628D0005; Wed, 21 Jun 2023 03:47:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33CB98D0001; Wed, 21 Jun 2023 03:47:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 203ED8D0005; Wed, 21 Jun 2023 03:47:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0E1D18D0001 for ; Wed, 21 Jun 2023 03:47:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C485A14078C for ; Wed, 21 Jun 2023 07:47:08 +0000 (UTC) X-FDA: 80925974136.30.ECDB3DD Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf25.hostedemail.com (Postfix) with ESMTP id 0B81AA000E for ; Wed, 21 Jun 2023 07:47:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CNR1lbPL; spf=pass (imf25.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687333627; a=rsa-sha256; cv=none; b=Hardgw6cN5GUBHQojqSE2J6w67yepKze0K+yURnTZXRrQ+3yIRVPS2KBKIxjYSWzKWNCdJ oPCSqbf1B4nBEvL2LvCCafUr4zVsjMx8Etz6+Vg1ZgJvadlvV3/mZWkwqycBF7DOQggDOW WeqpW81ZStxf6lZDkPQhEiQpoNyysyQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=CNR1lbPL; spf=pass (imf25.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687333627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Sqjzf2jL2yqon6TvBvzlt7HXul0/3e4mmFYkyszzl4=; b=2BCYdulYFytDVqVbsbrZGU/eTZZasUOtQbdX/4oJx8G3N/AeSOnREy/H3SpCpabFl9rfNJ 98jX8rd29gFp/ezF1yK88wQKa6bllSJ1/vPeRKjQD8eeonBdltr4+SQEtkxYpSV2/2jfmT 5Xhaexdvf1HRPb/yjKGwAHI9BmclUKo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687333626; x=1718869626; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=v2gjwEToFRuJ5IZl6784+ZpMbSbQbMfelLt7/7YIpU8=; b=CNR1lbPLohRaslKQQadq9LjKdzxnz+o01wFCTCJdQ4oCNetge/VGaqPr nN5UfGptluSonS7l5pvkOOlLaOLzouPQP6V8cquo8l130DteKObQ5/yb8 pPu90CYdsY2Jh6mXGdvnEvUeJDojZkg4uDkCTGCGzv+dl5mRcVQsTvwDr Sxp57raE1XGZtXKe+tmUyxWZwIW1rMwoGZr3Gdw26vnVzv1caG8vNxyd+ i17Byr2gM8HZZNsgRObatB8RwpB298rCVdNbvB47IJBwdDtzIttvrtsHC hypc7nmYqANUiXkfU7aAcPrzX3JKFZ2izBWHXQVjMhtm+edcHtG6khn2K Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="357594955" X-IronPort-AV: E=Sophos;i="6.00,259,1681196400"; d="scan'208";a="357594955" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 00:46:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="784385178" X-IronPort-AV: E=Sophos;i="6.00,259,1681196400"; d="scan'208";a="784385178" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 00:46:34 -0700 From: "Huang, Ying" To: liuq Cc: , , Subject: Re: [PATCH v2] mm/min_free_kbytes: modify min_free_kbytes calculation rules References: <20230621073912.21747-1-liuq131@chinatelecom.cn> Date: Wed, 21 Jun 2023 15:45:01 +0800 In-Reply-To: <20230621073912.21747-1-liuq131@chinatelecom.cn> (liuq's message of "Wed, 21 Jun 2023 15:39:12 +0800") Message-ID: <87ttv16yyq.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0B81AA000E X-Stat-Signature: pnpzfq5gnun4b466q3399cxp4jgspezu X-Rspam-User: X-HE-Tag: 1687333625-422462 X-HE-Meta: U2FsdGVkX19V5R/bNvrCPceBBF4c/2CAjcvaaT4V7ggFvHtj4YYnsPUzkN50/PQLnKQBIRNdIQlPPG4AdTlwamOz+9kkCExxCvmESp6JiT7dHo8yvV0yUweA6urBuPDAwZOcomdmou+8+WpeTg1i8Yp8EaD4JUnP4GIw4zFuy+wy+t1IlYiWckrT74YmIEbCa2Nr4iVrGSi9ua39uHXT2lmCBdKSAcmh5/Ou2+5BqnvvmcQ9rE5AWAHF86FfMgdGYTJV6BdtNEZRGYzTOkdCzABuesuWJjm+CPWM8a6JyarPTGNE1SYA3rmuHdhwPYZAZk04Tb5zjXw9hpUp77qkqC0uIVlh+AI23VIyF6TpzMygMnzLDA4X2bbYSuJ2RWo4ohW1orSTDFHIJKVeLVTW+ROJhmaz8f2KleZm8crVhob+MMbP9PwC+irS/KRfm3TyeDKDEhLtah129JCG1j2YuUkd+t8nOsB4l4PYSFh+xdXahwxDg/4Nf01OiYM/ueLIL947d8GEVUgDb6at1MAaZA0oS3FGpimVjKrx2Qw4oi16lXrvjc8qGc6wKLkNlZd6JblNSIZEtmo+Noacz0TuPpTSO0QfGeTzRX/HMYuyoyl5uHhHLPtOl3tyAGkxYxxE1ohQU5lx7TOMoMWUUkKh1RM6TjuKUQUWb+S1kIj+JSqJ/cx5agYQJTHTsIXww3GhZVLYrZrFMl1OBFuhS40ZSYtIAiujqVWNr8Veh8yhWuROVnh4I/oUl4KEi1bhHdaq+LKR2heygN103U4a5enI6zV07e0wxlIb41SYZQzuDcwYxeFhVlSInBblIeId5m+eR6KCU2aUboBOBRlC3J+3LTNFFmDVZRssEq0aSTms9dF2InQo6Dv6UFiukJkxrrjkPmQidqNdefYCCMgY7AKTfv7nIH2O9ot1zl18UsonwSTWI45KVzo49ao/8YPE3RIU2/Y3D5/7on1YiYQX/Zz PCA2sct0 VpwFssHzJDgAVn1+9zd2HX0+tfjtS1RTzzTLN91lH2oHFIycA3twQdUdRYZLzz4ySByMIVfaXCOmcGNCKAVT0HeVVxS/e8uNn/Id/eHFZi2pEp8fPqMmnH3cBB1t3rFtAoNzYiifvG7bSkeKxJYdwECmx6ZpZpQNXmdPh47AGanfITBDpEoRgYuP84Tqey8EGPSdl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Liuq, Thanks for updated patch. liuq writes: > The current calculation of min_free_kbytes only uses ZONE_DMA and > ZONE_NORMAL pages,but the ZONE_MOVABLE zone->_watermark[WMARK_MIN] > will also divide part of min_free_kbytes.This will cause the min > watermark of ZONE_NORMAL to be too small in the presence of ZONE_MOVEABLE. > > __GFP_HIGH and PF_MEMALLOC allocations usually don't need moveable > zone pages, so just like ZONE_HIGHMEM, cap pages_min to a small > value in __setup_per_zone_wmarks. Please list the test result of your patch. That is, WMARK_MIN before and after your patch in a system with large ZONE_MOVABLE. > Signed-off-by: liuq > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 47421bedc12b..608384712a89 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6364,7 +6364,7 @@ static void __setup_per_zone_wmarks(void) > > /* Calculate total number of !ZONE_HIGHMEM pages */ > for_each_zone(zone) { > - if (!is_highmem(zone)) > + if (!is_highmem(zone) || zone_idx(zone) != ZONE_MOVABLE) > lowmem_pages += zone_managed_pages(zone); > } > > @@ -6374,7 +6374,7 @@ static void __setup_per_zone_wmarks(void) > spin_lock_irqsave(&zone->lock, flags); > tmp = (u64)pages_min * zone_managed_pages(zone); > do_div(tmp, lowmem_pages); > - if (is_highmem(zone)) { > + if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) { > /* > * __GFP_HIGH and PF_MEMALLOC allocations usually don't > * need highmem pages, so cap pages_min to a small ~~~~~~~ Change the comments above too? Best Regards, Huang, Ying