From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A29B3EE49A0 for ; Tue, 22 Aug 2023 02:25:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EB1D94001C; Mon, 21 Aug 2023 22:25:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09BEC94000D; Mon, 21 Aug 2023 22:25:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA56594001C; Mon, 21 Aug 2023 22:24:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D7DE194000D for ; Mon, 21 Aug 2023 22:24:59 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AEAD7A0183 for ; Tue, 22 Aug 2023 02:24:59 +0000 (UTC) X-FDA: 81150147918.15.C14501F Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by imf06.hostedemail.com (Postfix) with ESMTP id 269B318001B for ; Tue, 22 Aug 2023 02:24:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JaMlaHQa; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692671097; a=rsa-sha256; cv=none; b=3PYLoP7bWbEC8n0mf6zRiMrEMFNLZBg1wixHjWjjhtAMGOYjZ2sATw/Dn4coW7FLnYfv8j /sdWovc6Mf6ltlEemcuMswC9E4b37mdUBAEHkJs+dLRiW0qazVqRyMl4ZPhn+2PsRmeH1y M059fEIdQNUetFwNVFGqp9bTGXBPncg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JaMlaHQa; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692671097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tsBJtlbAY6hb1d/ZOdKvhtPSzfbSBY+zjqvdYazOTiE=; b=nGHT2fMPIMDpIZoSqztOGi+L4PGfxfuMMzvzBDWyjHfB9FpDrSsPh77ADf/DfPYOBST+pP Mbx3qhEFi1VMjuXbWUB6QHK8aagOk7PRDDB3I0UE4ERodNIqgSnL5V8EJmMa8Si30Pf46o 3+AxQjGYTqPW5A88G6L1zdhWZ3vcGTY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692671097; x=1724207097; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=UfbeD6FiU7aBNKvy5b/Ik04w1hbvhD6JT1uDE9UYhuI=; b=JaMlaHQavFVZOe77RxXFHbmqo8gEk87XnYSqah1MFL4qAi77+fkMCFPc YwsYoYRNHkWyXhVXs5vysshPhciBne4e/IBgygmegtGeNR78Ibe/WWbNz 6au15Jf67azpwXR4wW572wDNLgEp+al6fgPIGpiTp9u+6QO6smiGbRCsa V3/qTvDpUqKREpYx4zF3NSiZq6/jm8A0OaXEDXYYeGull2WwoskFA8+dQ 8tSNkVQXM138HhdPHAck/lJBbyZzrwq+r3vzdGksdUrvj7RKWytvGEink 7AwCigvmK9mNyB6xphu0vHvcvuSfnLYD4oWPUX97tY6iOIdVFxAR2xzCq w==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="354086247" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="354086247" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 19:24:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="859714072" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="859714072" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 19:24:52 -0700 From: "Huang, Ying" To: Kefeng Wang Cc: Andrew Morton , , , , , Zi Yan , Mike Kravetz , Subject: Re: [PATCH v2 2/8] mm: migrate: remove THP mapcount check in numamigrate_isolate_page() References: <20230821115624.158759-1-wangkefeng.wang@huawei.com> <20230821115624.158759-3-wangkefeng.wang@huawei.com> Date: Tue, 22 Aug 2023 10:22:46 +0800 In-Reply-To: <20230821115624.158759-3-wangkefeng.wang@huawei.com> (Kefeng Wang's message of "Mon, 21 Aug 2023 19:56:18 +0800") Message-ID: <87ttsrbytl.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 269B318001B X-Stat-Signature: mbrazfpk7wq1u5ieum1czwg7pnawpwf4 X-HE-Tag: 1692671096-28933 X-HE-Meta: U2FsdGVkX1/PPHn4TuBMz+N6PATPgKzajp4qY73CkOtYir4nUboe79zzAIZDHHeoBqy+0WuTwSX4lCq/R5dGxfDBMcjBPljg6BcplIwzvSXEexnRiMKf28N07PWvujw30WHBA6tgAQO0QgCsZ2JD0+cPBNGcypbAbOlWZD/P28o3Ei35om7bl6tXUbU3NbXsVeqEB/MyLBJyRGizb7zdDQLqxxY7ZPR1Y3khg78M4io//Kvs+E96hbiPJaV64/yGIoa4LhXmsKiEaNs1hNWvoOXjj6rPjicPPZCzvIWIBuo5hOPIyZQ4XizBshaQrMLwRQxLY3Jmqg9oQw8/zylv5boFlF5go2sz0STNi+GAzyWODf68Hs1Ot+DYgDankuvXNJxIdPU6vrulMtUk4Xr0wLeLzpX7HQyjcU4SbYRwwuKms5NB3hHdf0MFZjK/fyskagxEA+P6DIwsNyyPRNVmTTmD1gEWlkZkz3vmm3We5nuy9Ow3MRf4RVud5HIG+U6HONCDnqQ0pXgvHHr4LfaFRnwtOoxB8Hmu1+S0Lucbcuz9+xCwGkIEjlyZLpK0fvaHGG02wKsmcB+bRKx1jayDhSui/J3TtUzvr8Yb1N/h+drk9isQiGg1Z/DY44GvrgFgclEnFTjqBFozcgy5+jL8Qo0vpcPt2cAdVCLIBQeoEmzzNc0GoMJwnOeyr6mgYvwzutCI61SJnyw0VzaJF8GeMvGcLrfeyzQ9+/JfCMJ574I+0mSWt7S+Z/kz/k6mhnD5JJzjHdF6FSpU1CL59xaD+HXVgdSpWKMzGHONc35RVtT/i1CHji2DGA0A1c6sn0pwRdwrfj1Jq0k5EubQlrQLAd1ZA8OvP7sn16ffArfyNT4pSqIKTHkao/3WikKxehCgfcoH+PXhQ8qfDYaIeTWnK/2EPwEtvNgXzQoCDxVwKo55TByi3qfI6+RAipiBYPZnGEyLWH8npx0RL2FXevo QzBbhhNU 9xX32oD3W2Xegz2Z+FnzUsnHmogU3zXje3Z20lrrPVG0/CReo694XBRawmJsUBfpj4bJu4oUuzWu0tm5PBWN4UubRAtsAjO8DA4cTQnDrEd1uL9GPTHEEKxsykwHy4KAgCM5GYY12qAAy7zdKL7SmF3Y6nFuUeQuBka2s71+1xp8Ud/CsmTW/WXlLwgMBtjhSKNA/7iz15KljtY6qFPKedSCMgGC+sheRgIKCl2XygSsckjMWnKpA7RV5MQSrUwR+kyKgBrkuWIKgY+KlcRq3InjCMCaIqkUg3T79L/HtfXnuu+M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kefeng Wang writes: > The check of THP mapped by multiple processes was introduced by commit > 04fa5d6a6547 ("mm: migrate: check page_count of THP before migrating") > and refactor by commit 340ef3902cf2 ("mm: numa: cleanup flow of transhuge > page migration"), which is out of date, since migrate_misplaced_page() > is now using the standard migrate_pages() for small pages and THPs, the > reference count checking is in folio_migrate_mapping(), so let's remove > the special check for THP. > > Suggested-by: Matthew Wilcox (Oracle) > Signed-off-by: Kefeng Wang Reviewed-by: "Huang, Ying" > --- > mm/migrate.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 646d8ee7f102..f2d86dfd8423 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2483,10 +2483,6 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page) > int nr_pages = thp_nr_pages(page); > int order = compound_order(page); > > - /* Do not migrate THP mapped by multiple processes */ > - if (PageTransHuge(page) && total_mapcount(page) > 1) > - return 0; > - > /* Avoid migrating to a node that is nearly full */ > if (!migrate_balanced_pgdat(pgdat, nr_pages)) { > int z;