From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0C1C4332F for ; Tue, 14 Nov 2023 16:43:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D64486B02F5; Tue, 14 Nov 2023 11:43:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D14B46B02F7; Tue, 14 Nov 2023 11:43:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDC076B02F8; Tue, 14 Nov 2023 11:43:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AE2AC6B02F5 for ; Tue, 14 Nov 2023 11:43:34 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8702BC0B4E for ; Tue, 14 Nov 2023 16:43:34 +0000 (UTC) X-FDA: 81457130748.18.9268123 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 3599A80029 for ; Tue, 14 Nov 2023 16:43:31 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ll4Uk5gG; spf=pass (imf02.hostedemail.com: domain of fweimer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=fweimer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699980212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7cok8Q3IObYPFL+9sXuypqM5Ca4C9SOJD0kAH42Df6o=; b=5gTIlJOVd0s0eN+5AwZzNr9e0jEHyMbkQgU3DI2OS5uXlMoFIW0w2bxTgJ32AWCVV9b/Al xQiTA45htKJU5pSZY3zs/wND6AkZg+M3L+2QHm1m6fI6aZ1/W2tlyWJ5K20Wr85zD5MyAA LMZvMy27IRwcoApjIxY227C9nc7dkjI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699980212; a=rsa-sha256; cv=none; b=8Md2NjtikbpMYyxwhLNN6QedApb5+pn7bKwG8FnshLi4VKo0t7gQ8ma559B+I06pX+IVOk W8BCpp5/1RaMk285T3u/ZVOFPd8m3FuXxrW4so3L9yyvVR8xzb3ZARzdFetO4WmCC2COIp FdW7qIwzo3PFGiA64WLBkDUfFhjCFkM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ll4Uk5gG; spf=pass (imf02.hostedemail.com: domain of fweimer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=fweimer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699980210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7cok8Q3IObYPFL+9sXuypqM5Ca4C9SOJD0kAH42Df6o=; b=Ll4Uk5gGBxyhpXkHvGre77btGJJPiN+PGlRha5bCOzEuq+VU/oA9PkmepXoluYxdR6rO8n c8l7PmPKbg+lHlukxjCYs+Ui+hMSJeu6TJx418dqTtSA6H8CnPMfY/eUWA8yc++fnACQ9m sP1yMIzPktPKnBc0U+xDr65t6rLdK14= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-KeUFTFdVMxGEvUF3WrroaQ-1; Tue, 14 Nov 2023 11:43:25 -0500 X-MC-Unique: KeUFTFdVMxGEvUF3WrroaQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 508C63827962; Tue, 14 Nov 2023 16:43:24 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 248331121307; Tue, 14 Nov 2023 16:43:21 +0000 (UTC) From: Florian Weimer To: Peter Zijlstra Cc: Xi Ruoyao , libc-alpha@sourceware.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Thomas Gleixner , =?utf-8?Q?Andr=C3=A9?= Almeida Subject: Re: Several tst-robust* tests time out with recent Linux kernel References: <4bda9f2e06512e375e045f9e72edb205104af19c.camel@xry111.site> <20231114153100.GY8262@noisy.programming.kicks-ass.net> <20231114154017.GI4779@noisy.programming.kicks-ass.net> Date: Tue, 14 Nov 2023 17:43:20 +0100 In-Reply-To: <20231114154017.GI4779@noisy.programming.kicks-ass.net> (Peter Zijlstra's message of "Tue, 14 Nov 2023 16:40:17 +0100") Message-ID: <87ttpowajb.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Rspamd-Queue-Id: 3599A80029 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: si774xas6rgu8htgrh5ohymhazi41yot X-HE-Tag: 1699980211-256289 X-HE-Meta: U2FsdGVkX1+zofKbnRt9m3e1eIe5+HRRYsszD6t3K33lwAZhCct97nenNU0wyqu1MyqN/P8oLoi/fHp/T8EGH7fSoHVV97T1dwnaumM3y58TyRbagnBEQde4HW8/vBF7x+3ipU+pFqTRx3Z8GyrQDmMdFB8kD01fRDKc0Wk9pqO9T5wOwTwBnncBqanD4Toz33oVxekp3q8slc7IU1hZZCMdw5M8CzJcjmkraYsNOTCe9d5HlrirOTUjfQof0MYZBJNOkbziF6FQHIAnFZB9xXMONYcLcYQqbeHJM16032Zlw0IUH9IglM/+pMxeGSLCiOMz8B+tRNeK6h8x3+HzIee4sLfGP8ib0Zdz1H1BjyJUxDpB8Bn3egjie2+Zmj0lVC+Su+NhXWPJvTRLEFAF9ng4+oOJKbX/R/gOEGLfiRpa+qXRTn46ThAwUVHHzMuqWhgXpAqyBEirFijceyl/Bs8S7E8ZG0SEgg4KWGD6aXgGOH9qnR3C79C9lqfk85apV3nH0HZRK1J9dwXj3lhwJ+qJyvxr/lKwZeZN0KkPe8MCt0mAnR+/vBMX2QGXGys/5gaTwYsuPRscreX9HoHRBFiAyD+Ivrj29sF9HclRx9Fx/D/aSGjMzYRlVMI3Kkome3xsgQMPHU932m6ZZhfGRDrYFhpRuWjrRbp++mUuFOzCqW9Rc5UuvXB/5QLW854xaCPUKO9UWyrVwE6MhN6bx0ai2uyGv61yTrr3pR32YPVd05myqFRQqS2Lq9QDWl/kYMVSiSjep7nSdeRqx7g5WD+MLNxbWhkiUukau8Y/00ZY5lGHODEvI9uzRRJlCeaH6hi1CfyQjmCsHuPkcvx6pBhshAivcHI24Zt1BYDAMkiST78qeOnL7yDiKP5iU27EZPVVxtQU6msH0weQMH6b07OXy28/hwPF2M63KiPvqxmd9hR8+cNx4HytDQ4yyWhqIxm9cw4uUNo9zDvH8zJ yPSkaE39 2JFxHdUpaXglBNdXsKkyIHdN8hsSFKnTREA+Dw+WdOlGXomlk9L1gJ1Rrza8ZidDknrwxYnaUv1xLESiZYzBG6Bcglo5XJ7b9I/NsMm1jv+kF698= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Peter Zijlstra: >> diff --git a/kernel/futex/futex.h b/kernel/futex/futex.h >> index b5379c0e6d6d..1a1f9301251f 100644 >> --- a/kernel/futex/futex.h >> +++ b/kernel/futex/futex.h >> @@ -17,7 +17,7 @@ >> * restarts. >> */ >> #ifdef CONFIG_MMU >> -# define FLAGS_SHARED 0x01 >> +# define FLAGS_SHARED 0x10 >> #else >> /* >> * NOMMU does not have per process address space. Let the compiler optimize > > Just the above seems sufficient. There are a few futex_wake calls which hard-code the flags argument as 1: kernel/futex/core.c=637=static int handle_futex_death(u32 __user *uaddr, struct task_struct *curr, -- kernel/futex/core.c-686- * this. kernel/futex/core.c-687- */ kernel/futex/core.c-688- owner = uval & FUTEX_TID_MASK; kernel/futex/core.c-689- kernel/futex/core.c-690- if (pending_op && !pi && !owner) { kernel/futex/core.c:691: futex_wake(uaddr, 1, 1, FUTEX_BITSET_MATCH_ANY); kernel/futex/core.c-692- return 0; kernel/futex/core.c-693- } kernel/futex/core.c-694- kernel/futex/core.c-695- if (owner != task_pid_vnr(curr)) kernel/futex/core.c-696- return 0; -- kernel/futex/core.c-739- /* kernel/futex/core.c-740- * Wake robust non-PI futexes here. The wakeup of kernel/futex/core.c-741- * PI futexes happens in exit_pi_state(): kernel/futex/core.c-742- */ kernel/futex/core.c-743- if (!pi && (uval & FUTEX_WAITERS)) kernel/futex/core.c:744: futex_wake(uaddr, 1, 1, FUTEX_BITSET_MATCH_ANY); kernel/futex/core.c-745- kernel/futex/core.c-746- return 0; kernel/futex/core.c-747-} kernel/futex/core.c-748- kernel/futex/core.c-749-/* Thanks, Florian