From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D47E1C48BC4 for ; Tue, 20 Feb 2024 04:13:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FD686B0085; Mon, 19 Feb 2024 23:13:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AC4D6B0087; Mon, 19 Feb 2024 23:13:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49B866B0088; Mon, 19 Feb 2024 23:13:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3A45B6B0085 for ; Mon, 19 Feb 2024 23:13:56 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 151661A0504 for ; Tue, 20 Feb 2024 04:13:56 +0000 (UTC) X-FDA: 81810864072.20.E541D19 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 337601C0008 for ; Tue, 20 Feb 2024 04:13:53 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="D1yghm/Y"; spf=pass (imf21.hostedemail.com: domain of chandanbabu@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chandanbabu@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708402434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=adOw0wa5Lks0mFvD0yTrSDmRmCBdIjbsQYNX19F+LYc=; b=c7VD6p/ihOe7hAZhVLc7eGCya6oICZu0NmHhHKntfK/3X4soeGcwU6b2hCnNgXlcxzk9dB O1iqeoWBQntCAaGotX9UuoZFlsY57caPUcpB45HugCP7qFRq1Hgy1iwSgS650yiMUZL8De cK0v/KkfnlCC08TXE8WRveYhnK29nOE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708402434; a=rsa-sha256; cv=none; b=xNyJEgsYJLTubCNCLDEXzW/nkEGU34xJwuCHjtU9nGMM4/Yf2lzT4ZgojZ6io7tameaMuO 3ajrljVQKBf8I0Ws95DjQfUx/3Baud3jIWetk/thovseinxGudpVuGlA+MYw4u/z0/MV1x CQK+0LX1/ExKGJ/rvI7IsULXduF7Cv0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="D1yghm/Y"; spf=pass (imf21.hostedemail.com: domain of chandanbabu@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chandanbabu@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 381FDCE149E; Tue, 20 Feb 2024 04:13:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F26FCC433C7; Tue, 20 Feb 2024 04:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708402430; bh=41CNtQgwX8RxHE1lX1LzPFYarVEK6rsM7apxC6t702I=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=D1yghm/YTt7NSMlPQdGpDB2z8J52y8jlUXumtuSJmah8n5cqQBSF8Bek2g7+iFEet by/D+4HR5hHZi254hNSpW3qMD440BiqZxW4rvMxnszde3U4N3hzPX2nvmP8Vo65ecU U1hRrREZWrQ/lDYQvqMt50zNYIaQyPdkJyor+y3fkk3GSO1aBwXpjy1loBEDN2D6yn aU+mIgZC8qrzdOZJ0fINW0RBgu8P9m4/t446Spzu46tjBRN7rqvRi6zEa2OHE9F7Uk cgFsvbPUV6BrBDv41Qt1OQw+3sX9CWLQNW67inPZw0/bEXlsuwKhfZzeOD04lZjgY6 6WdLpm6HRknOw== References: <20240219062730.3031391-1-hch@lst.de> User-agent: mu4e 1.10.8; emacs 27.1 From: Chandan Babu R To: Christoph Hellwig Cc: "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Hui Su , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: put the xfs xfile abstraction on a diet v4 Date: Tue, 20 Feb 2024 09:42:23 +0530 In-reply-to: <20240219062730.3031391-1-hch@lst.de> Message-ID: <87ttm3hix0.fsf@debian-BULLSEYE-live-builder-AMD64> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 337601C0008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qiyq5ux3fghnhyjyro547nogybbnt7a5 X-HE-Tag: 1708402433-361771 X-HE-Meta: U2FsdGVkX18/VQDf45nSEcf5gdt9uLqhfM7nHOGq5MEsHlN5nOPUDtgI5HLv11DQsx6VtWSqgOhr5tmh44oAXvwoQ5RtWEz1vNvJyUW5eOz4QNYtJuJp5J6lIINlAgkAQLjUVgLMa0+/79ih1A0Nhtw59harQQRQUOvvsYsD3BLhY9++6E8K/0KHbKWZ2YIZ4Oii2Hywa3zR6QswNyY8aJ7p8Uf1to2Ez84j7RAAMYe+zyxSkB91pIMPdjbyKW+N/zysenp4/60dxPInwMV1G4UhXsb0Qe1MzBUmOQS/VE1rOcBYZU+GOdEFp2QdMeBcu+fCouGbLAuXCWx/pwAXWe70tbIilg4qbyssXY9VeqLvYUtYeR4LqSlPOU58E2j8JyKFQHfURQFMdtfdDScVXaj9XeIBmxeC5bhWJh9XuL2iz201PoW3JU62AjiQmIvhwPGHFnIUiw0cT38m98uzeRJm/OCrYBUAIwfVcrDgAXil4xAryhl78s8Opl38P26wRHz28TuCdaw5f9Ne0NFrT6bWIuwr2W8jNx5NBlZntP5AVJ5MKy6QyXvUlapEIiWWa77F8NBrOAGOOAJtq97UG3OQjxuG1ds9aRqyKbqE8kYCv2jZ/dYbRcD03Mfmk41zbvKcnSpPFh5L9MA8gEWRTeXZca1KTxgENJGcDdDfUeUdxUvDp/vGayoy8sXmxBY6Wmq7sgoO6xSVQBUOc36nchokBOFaF+5zPcu0/ubFiaZQrnFo6q2g91x9o4v+mwiO68KfW3wXzoT8NP6qHDJxsRnIh2dKrQRFzBein6URifGMf5xg7SRL+irIcNQE8WsU0r5Hbogu1zhuFZAyPEOYNDbIlNRusGpayHhpGUlWZufJeg8SzcEh9kDhqAW2JwbgeKWjVTs4OyEI6Pz/ntQaljvRTlXccWowI7Icd3Hc908= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001082, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 07:27:08 AM +0100, Christoph Hellwig wrote: > Hi all, > > this series refactors and simplifies the code in the xfs xfile > abstraction, which is a thing layer on a kernel-use shmem file. > > To do this is needs a slighly lower level exports from shmem.c, > which I combined with improving an assert and documentation there. > > As per the previous discussion this should probably be merged through > the xfs tree. > Can XFS developers please review the following patches, xfs: use VM_NORESERVE in xfile_create xfs: use shmem_kernel_file_setup in xfile_create xfs: remove xfile_{get,put}_page -- Chandan