From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40AC1C25B7E for ; Tue, 4 Jun 2024 07:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63E5D6B0085; Tue, 4 Jun 2024 03:46:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C57B6B0088; Tue, 4 Jun 2024 03:46:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CA3F6B0089; Tue, 4 Jun 2024 03:46:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1C97F6B0085 for ; Tue, 4 Jun 2024 03:46:37 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 897951C1658 for ; Tue, 4 Jun 2024 07:46:36 +0000 (UTC) X-FDA: 82192423992.13.153E1FF Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf12.hostedemail.com (Postfix) with ESMTP id B780540019 for ; Tue, 4 Jun 2024 07:46:33 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Xo4YYdv4; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of jani.nikula@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=jani.nikula@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717487194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AcyKg7iMl+JqIsaNca1I/s3t8kuhO6GhuDHbYQmYNjc=; b=0qIa87hgWTVgHEB7zBr6zVFOMknGiQSRIRXQQsc5ZQJgHdwQZlJPEyVQ2OexiZPsWi8dbf ql7MjSPB4u6kQ6e4tbPs1LFoiJ5F2Hdl1tzTBWSEXsjORW+QzhEVc0E3aIlAxo9Vddm3dJ x1KmpwELQQ4V+Jvm2QLRvj2gD/tAV/M= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Xo4YYdv4; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of jani.nikula@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=jani.nikula@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717487194; a=rsa-sha256; cv=none; b=y2OzuHp4vi4GreXCS78EuNPSGaPBfubRE5EP7HvD2wnrMSJU/bMJJ8NTXAEa2xGtM1qi+w bCZmig5l4nOigoc6uNJK/kyEqOv0YJ+608PV24osXqZDen9PvJEij9mWsTAuPBTjF+5hrO QUYBYZfm/Z5HRB0/4IiZ1iUwD6X0umA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717487193; x=1749023193; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=72AZit+fGSAltF/zxrshQ3AcOBabtAGvP903E1S/6ZE=; b=Xo4YYdv4QOvQiRfYEcz9oSlqARCRLe0gdovF98NgLZlfLETw8vVxUnFe K+rxKBTxtkzmtORGJfOakqCUX7ZaACqV4mHAPddrQVq8NjeU0r2SrG7L6 k8bVQII0A1tzsLbsh9Vodh1v5A/zz4eH76RU+g4XoC1APCRSlTyMRt7h5 BqME4ZgTm/zV92Z0w+H1s5/YrtQF0jNcv7yIxaDKmrqKrmrtT6iptzFsZ jsqTBqP2GhIFMHLXtotzvVNnRZHqIskNXCBZ8XPjEKK7+o9ZVS7QL0WtF DWLPsp2HgXdj/mdjTMdwATF9uWURhf2fQK+7ddmiNF0oyf99IK4MtL13R g==; X-CSE-ConnectionGUID: xL/7mWOPRLCHFyU4IDLPBw== X-CSE-MsgGUID: HkXrNGa+TWSppcW35pJpXw== X-IronPort-AV: E=McAfee;i="6600,9927,11092"; a="25412066" X-IronPort-AV: E=Sophos;i="6.08,213,1712646000"; d="scan'208";a="25412066" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 00:46:30 -0700 X-CSE-ConnectionGUID: L1vS2iCsS0qNl7Ekvd+3Hw== X-CSE-MsgGUID: FcxQSXvDT6KeINvTUaFx8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,213,1712646000"; d="scan'208";a="37269403" Received: from mwiniars-desk2.ger.corp.intel.com (HELO localhost) ([10.245.246.102]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 00:45:40 -0700 From: Jani Nikula To: Andy Shevchenko , Andy Shevchenko , "Rafael J. Wysocki" , Greg Kroah-Hartman , Corey Minyard , Allen Pais , Sebastian Reichel , Perry Yuan , Giovanni Cabiddu , Herbert Xu , Nuno Sa , Guenter Roeck , Randy Dunlap , Andi Shyti , Heiner Kallweit , Lee Jones , Samuel Holland , Elad Nachman , Arseniy Krasnov , Johannes Berg , Gregory Greenman , Benjamin Berg , Bjorn Helgaas , Robert Richter , Vinod Koul , Chunfeng Yun , Linus Walleij , Hans de Goede , Ilpo =?utf-8?Q?J=C3=A4rvinen?= , Nikita Kravets , Jiri Slaby , Srinivas Pandruvada , Stanley Chang , Heikki Krogerus , Abdel Alkuor , Kent Overstreet , Eric Biggers , Kees Cook , Ingo Molnar , "Steven Rostedt (Google)" , Daniel Bristot de Oliveira , Andrew Morton , Hugh Dickins , Abel Wu , John Johansen , Mimi Zohar , Stefan Berger , Roberto Sassu , Eric Snowberg , Takashi Iwai , Takashi Sakamoto , Jiapeng Chong , Mark Brown , Kuninori Morimoto , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-acpi@vger.kernel.org, linux-ide@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, qat-linux@intel.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-leds@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-staging@lists.linux.dev, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-hardening@vger.kernel.org, cgroups@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Cc: Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , David Howells , "David S. Miller" , "Rafael J. Wysocki" , Len Brown , Sergey Shtylyov , Damien Le Moal , Niklas Cassel , Daniel Scally , Sakari Ailus , Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Heiko Stuebner , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Viresh Kumar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Karol Herbst , Lyude Paul , Danilo Krummrich , Jean Delvare , Alexander Shishkin , Pavel Machek , Chen-Yu Tsai , Jernej Skrabec , Tony Lindgren , Adrian Hunter , Hu Ziji , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Potnuri Bharat Teja , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Miri Korenblit , Kalle Valo , Mahesh J Salgaonkar , Oliver O'Halloran , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , JC Kuo , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Sebastian Reichel , Daniel Lezcano , Zhang Rui , Lukasz Luba , Thinh Nguyen , Helge Deller , Brian Foster , Zhihao Cheng , Tejun Heo , Zefan Li , Johannes Weiner , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Masami Hiramatsu , Mathieu Desnoyers , Jason Baron , Jim Cromie , Paul Moore , James Morris , "Serge E. Hallyn" , Dmitry Kasatkin , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Linus Torvalds Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string() In-Reply-To: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> Date: Tue, 04 Jun 2024 10:45:37 +0300 Message-ID: <87tti9cfry.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: B780540019 X-Stat-Signature: ptprsqjjooxteht7deay634157pb79xh X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717487193-152426 X-HE-Meta: U2FsdGVkX18gkiTi0DE9w0qrJNwaIx9IHoBrUx5K4ierZ9YRTr6ySUlpdfO41NmHeD+TwgwkouZKo/EdAf7VH9KCE+Y6rRcLklYGq4vvuHJaToYZ5d/DCvgxkgZlQG8iOlr4Q/DQ43pHsfM/iBkXmd0ecoEK5BaQBXFbXz6WHgvpksseUCebVocYPzQODPS2N9nrlel08hcl1C53Oh44KXBhQfFnjJmTq/RSknsF9e0UUGbTO386bsxvLlPA2HH1C81c2LZG5rIp2H+vDvGWAKtol8PVVT0pA3K7F1e/HG6ibSha6fkZubeYzu6D6A1hFGfmMXw9/Owb6Bf3o8zpuZo6a1WThGZE5gp79LBs1rqvl1VMw76y/E8IgPQrlEyOd+XyffdIxwXlxIfFOGbXRWHEteaXz3cpBp2IZHyengHkGOJl+1gEx3L8WrFKYiW3oAm4lho0Ocas4/fb7fjWHPvwkQTEHd3f+cVdxWXsUT2zK+rSCBkJYCRUl63ekkF7wGW4mZhAp3pWo90OUffvN35wy/nnZvATc7bzkBuDa3ESzwLRXImnsjaA9/KWivpxYUf43zppFDb7UWb2h+uN6MkcTKzexitwSEtpnCxLdWR56mWQyPN1aEqkjjXUqxmAfnR2E2YWHYNQu8lHEPhr7RF5NYhnKv7CwKt/RJhsV5dXsRE2XQkQ8/4P4HuIIV0seCNpr4ykCVVN+XloqmivHJ2yvyRMVp6Sam8dP9mjwKpTQFKXIU7umtTz3CW3+wirXtrpeVUFw11E0Gu48mJ87OXy6NZqwclYCiOrkuTzaOgEvKRNGSiG4YcKShj8W5WhMwFu0zsD/zmZW/Gbfm90QhaFR3EfPkoeL43PANwbX4yeU2Vf06oscfwyWhXEDgBSqPCC85mNxBXQhFgIQq2HHeS2si5rljGkq390P/sAbZg2bNkCSCRcjX0nQU/++BNuOr3anq2IQvsYMdb+ofm WGORBNYe Dmj9LJtjjN6wh9S5s/Get+VGx57AGbrCd+b4ceuoDA3R6YyU3JgqWQA5H8FUsitkVn4aW3ciHvUR1yjd0fUhhBOQDX/idr90ze4kLdHtj/cQAVm3vWS52eM2qIaDk2X/LWuXFyVHkHsBP4qwv/MD5i2RqImdAtWEVNMm55futq8hAYqMQOtpuXeUffq0rNOIDQSupj46IwoxqcJWPEZmKpzIEO+7l75x6I58+Dh4a55+p1Irpt01YW4yVEAWbgnn4nEXMoJDVp14LGJZdy7OHBH4yijYiAa8iKJJ4l7pmDE5b/SEeLKpzGTmxT0LFJGnhoPjGRTFKv/9ikUV8LZ/LFowr1d+nC0uNKfqnhE98YB4vOtFcXJMAyqEmHKOLvo9Qq2Wxl2CRIV7vErRtyz/3mSvL4LXZh1/94HLEwDu6RbVX9Yh/dz+BwuwPFZN+ssmKnTRGW56JdnmiXKbnT/NxxMTx3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 02 Jun 2024, Andy Shevchenko wrote: > Make two APIs look similar. Hence convert match_string() to be > a 2-argument macro. In order to avoid unneeded churn, convert > all users as well. There is no functional change intended. Why do we think it's a good idea to increase and normalize the use of double-underscore function names across the kernel, like __match_string() in this case? It should mean "reserved for the implementation, not to be called directly". If it's to be used directly, it should be named accordingly, right? Being in line with __sysfs_match_string() isn't a great argument alone, because this adds three times the number of __match_string() calls than there are __sysfs_match_string() calls. It's not a good model to follow. Arguably both should be renamed. BR, Jani. -- Jani Nikula, Intel