From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E08C3DA64 for ; Mon, 29 Jul 2024 01:06:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CA3F6B0083; Sun, 28 Jul 2024 21:06:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07A306B0089; Sun, 28 Jul 2024 21:06:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E82FF6B008A; Sun, 28 Jul 2024 21:06:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CA98D6B0083 for ; Sun, 28 Jul 2024 21:06:14 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3275FA1AF9 for ; Mon, 29 Jul 2024 01:06:14 +0000 (UTC) X-FDA: 82390999068.06.F73DF7C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by imf21.hostedemail.com (Postfix) with ESMTP id B54931C000B for ; Mon, 29 Jul 2024 01:06:10 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZIPTdz0E; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722215118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zAxLyV/ttWWGe68mA3DIbNDdBG3HuAAzjuGZOTqI/6U=; b=XjdrawR6euRP6Lc693+Wth/MjWswzvoC18mU5EgOPqQyjMJ4xlXEkjj+LpSD38eCAduJp4 zgXhpJJnHIup2MZL/FYBwYwmuEEz0b3aOR6kCPqNFOTlA7Yk7+R05fWRZfKlqVBNLLHpUD CurqztoDIuEo1yUFbxCj8qUxAAXyxig= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722215118; a=rsa-sha256; cv=none; b=q+GxUHwjjuKnl9XjiIEFAp1Cfit5tQsVuxiaUURXcSrHXAgRHX1ys33TwlN+Z6chxoFxKc h5aKJLx6TtG2/0T4UQxjVjiWTdacrkqn/U1VXvamkrN1+Rq/f64DyX5c0J7Ia5jIjShRE8 Z0vqwtBDd6dJnF/iDEjzDDdIUjQKBgw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZIPTdz0E; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.18 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722215171; x=1753751171; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=qOJ6RBRjTGLapV6xbEMAa8VeNCVtyRWlp19GF/AmzT4=; b=ZIPTdz0EUlzbZfOiHA3quGWWk/aerUoqZD1rRtJWEYd0MwhiirAFhpGL fZEr+xI7cO9g8insCsuQqpgYRH+RTn59SK7CfhkJ+wmFTBytx6L2xJ+wE 7Kz+FFvMFHodVgRK5klfPFXmSzJSr3vi2FFQVKDzD/urNkmWNMNh/r71p ozkBaJ+fof+r41Go6h/AEauIi8nZFfsk1L4WDE+ipsT+5H/WhMEjTCMp6 PAla0BM29lZqFRPaCZYXe96vqMdJrfSAsvVjDYTwKS+0Sj11YaDcSKGIa FLsRyk5JbuRliFJBJy59BoFpRGhy/XKGZx1uggkcAQ3nTf9gtnz7c8/Rs Q==; X-CSE-ConnectionGUID: 7vY03+IZRS6o1Gq3SGx6lw== X-CSE-MsgGUID: gB4vYnRoRO+W4D/k4ZmJYw== X-IronPort-AV: E=McAfee;i="6700,10204,11147"; a="20066502" X-IronPort-AV: E=Sophos;i="6.09,245,1716274800"; d="scan'208";a="20066502" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2024 18:06:09 -0700 X-CSE-ConnectionGUID: +N6szT4ZR1SD+KwFnQsw5w== X-CSE-MsgGUID: CSENE5+DSjyzmsJ3rI5SFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,245,1716274800"; d="scan'208";a="53774562" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2024 18:06:07 -0700 From: "Huang, Ying" To: Gregory Price Cc: linux-mm@kvack.org, akpm@linux-foundation.org, dave.jiang@intel.com, Jonathan.Cameron@huawei.com, horenchuang@bytedance.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dan.j.williams@intel.com, lenb@kernel.org Subject: Re: [PATCH] acpi/hmat,mm/memtier: always register hmat adist calculation callback In-Reply-To: <20240726215548.10653-1-gourry@gourry.net> (Gregory Price's message of "Fri, 26 Jul 2024 17:55:48 -0400") References: <20240726215548.10653-1-gourry@gourry.net> Date: Mon, 29 Jul 2024 09:02:33 +0800 Message-ID: <87ttg91046.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: syz1gcra7bnnnz93rpyroshwgymz8u5g X-Rspamd-Queue-Id: B54931C000B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1722215170-301105 X-HE-Meta: U2FsdGVkX18jAi6fc0lEGf/5O13e1XQEMY3S9LobW6PojlD7InEsnGbaCYldX2197MEYPCK5WW/tv0G63m7yhYi//pqOcXonchNHC1MDVPG72I3aCmLSPe9h0LUpMN3FWMvj+84rxcm7DBa47X84X02d+a+VgXBruOTVGOKGibK0q7d2kbr54A3Ca/gK2Pyf2W6J+WbVkGz6cP2e+hrCX/AirtsEfSJOytskkDxDl9VcvUHndidW+NvQkyM79XEP3ztjRFB3RT16VglWd/3IEs1FhdFDPwynaY8hae+SMBR3gYgp4arLL8V90v/cPtaf/dwLdoyoPCioEVjMPy1mMEZv4gA9zfzq+aIYDD86dTACrRAQ4CHrV3hfIO+QiDZiYvbBA1wNZ2HtAqvh34dvzGrIBlB6UlrO6uuS+8xEOQ4eLgQStvg220dYBvDs7Yhj7zPKfW0IDa8aYQ7Hcr3tyCf6WXhUylzifT0ZZuffk7MRS3os7HYdAWNpv+vFPCwKadberl2KUKZbD1r03NYobyLiLZtZeNiJfNYg4Jc1DUZX9OFfuRPoklPEXUQP0h1BWzYirJxZx51lH9sUfg2FmGjEpSt6u6MgzDboL9e4MFyZ+nDGBs6ZlbBppaAwHVqvN1VF/y9zZ5N940Yf0ISgb1sWJTEqoBWJ8F8g/JO3/c2tHc8gK/Dy3LGfA91fafrbXU4sZuId/lfR0UjEMMHaDqzQn2expmcKvuGRIljrR99QTojYGAHMLlZWjgWi++LosxD1yMmGROe4f7FdlPkD1HwSZHe6Csggwgog3XwrsUj4DClBIamUnYPyS2/n5v1Z+a3/jrORSho4q/gtMXULAnDuqb5xcTLFjSjlENxcSdhdQ/qlIPp16jlasQLuDGA26qn79F3mdCmnm5UKAi0TOQfpihS31meZHRVy/lEH1BBCIhNf/ZL9KDsZ3fpt6DbrLEWmRiqMtfl0gMvdajr oFzXqks3 QScFm07CecDnWa76JTyWAVs+pNMg9YG8e6lTSRwPoaM5pIbkol8daEqsFTZOa30kDWhtRArAaqqZxNg0nTfyXi7sm3DeSEs85SUyK1qldrJh5nuPNkiSMdsVkNdBrWaKjzzeAVgX5DR5aaCaZKmd2SGOt+OVaSbm3ZqupevqHXWDWQod593NdUAhVSZ7LisVJGGBCGquy5sFEK78= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Gregory Price writes: > In the event that hmat data is not available for the DRAM tier, > or if it is invalid (bandwidth or latency is 0), we can still register > a callback to calculate the abstract distance for non-cpu nodes > and simply assign it a different tier manually. > > In the case where DRAM HMAT values are missing or not sane we > manually assign adist=(MEMTIER_ADISTANCE_DRAM + MEMTIER_CHUNK_SIZE). > > If the HMAT data for the non-cpu tier is invalid (e.g. bw = 0), we > cannot reasonable determine where to place the tier, so it will default > to MEMTIER_ADISTANCE_DRAM (which is the existing behavior). Why do we need this? Do you have machines with broken HMAT table? Can you ask the vendor to fix the HMAT table? -- Best Regards, Huang, Ying > Signed-off-by: Gregory Price > --- > drivers/acpi/numa/hmat.c | 6 ++++-- > mm/memory-tiers.c | 10 ++++++++-- > 2 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c > index 2c8ccc91ebe6..1642d2bd83b5 100644 > --- a/drivers/acpi/numa/hmat.c > +++ b/drivers/acpi/numa/hmat.c > @@ -1080,8 +1080,10 @@ static __init int hmat_init(void) > if (hotplug_memory_notifier(hmat_callback, HMAT_CALLBACK_PRI)) > goto out_put; > > - if (!hmat_set_default_dram_perf()) > - register_mt_adistance_algorithm(&hmat_adist_nb); > + if (hmat_set_default_dram_perf()) > + pr_notice("Failed to set default dram perf\n"); > + > + register_mt_adistance_algorithm(&hmat_adist_nb); > > return 0; > out_put: > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index 6632102bd5c9..43bd508938ae 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -765,8 +765,14 @@ int mt_perf_to_adistance(struct access_coordinate *perf, int *adist) > perf->read_bandwidth + perf->write_bandwidth == 0) > return -EINVAL; > > - if (default_dram_perf_ref_nid == NUMA_NO_NODE) > - return -ENOENT; > + /* > + * If the DRAM tier did not have valid HMAT data, we can instead just > + * assume that the non-cpu numa nodes are 1 tier below cpu nodes > + */ > + if (default_dram_perf_ref_nid == NUMA_NO_NODE) { > + *adist = MEMTIER_ADISTANCE_DRAM + MEMTIER_CHUNK_SIZE; > + return 0; > + } > > /* > * The abstract distance of a memory node is in direct proportion to