From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45009CD4F4E for ; Thu, 5 Sep 2024 03:04:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 997946B0403; Wed, 4 Sep 2024 23:04:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9472B6B0404; Wed, 4 Sep 2024 23:04:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C30E6B0405; Wed, 4 Sep 2024 23:04:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 58CBD6B0403 for ; Wed, 4 Sep 2024 23:04:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B45A640256 for ; Thu, 5 Sep 2024 03:04:22 +0000 (UTC) X-FDA: 82529191164.09.8B9E84C Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by imf23.hostedemail.com (Postfix) with ESMTP id 6FD79140004 for ; Thu, 5 Sep 2024 03:04:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AWx4Xm1h; spf=pass (imf23.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725505436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ctj8c+T1CksO3IOMbc2YxWIOIFkvsmM75a3v3J6Hm3U=; b=BjP1h2y9eC+9AfAcL2m02lDtDAOqoCfBj/vEZ+i0upOZN8GiE26knd0VVUr00Ixv78/3/k Y6+RCbHbq2Ldvu6ddSXR8HFRoXDTqKlf6hqN5MZi3vpvIeLwL6zMi/lp9EOwFwbuj0pXuV Yakw7eznUr2q/Q3sNcsYmaH493sLWeY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AWx4Xm1h; spf=pass (imf23.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.13 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725505436; a=rsa-sha256; cv=none; b=s7zC6oWszVrYfchuDE55Me2phcV2SZsW3LH3PYiTt/4SSPx/8YBsG/2G5yRBUSHj8Fax0g Xi/47U/q0wQjJAEkT5VUGa/cdTb1Y7jttGrVlcXbjooC4giQv00ukyJ8ag5EHcaS0qfERk /9b+nruRBhDpCYdvhS5USumvINEtcpU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725505459; x=1757041459; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=0JSnG5HRLCKfbdDlK8qTrHejGQWFOx7ylq1ibs1Fn1c=; b=AWx4Xm1hOGJ1jXlIfObEZdFqbqZ19kXAdWTAvI2LVGOsAx+wGSmA3UJ2 IdEkij4QPor4bazqsT+oIfbH2L0gThwNDjVFEcRegfxA4Cd2bp8Qq2E+a r/Z8xGqbhtHo6uLU0VsFGOgshZkYds8kvMY3LFObuoL4mG7YaMuqhz94m gfv/BEtjWocDM/jZS41BNen6nHSxAnp+IQmWF1A1TRddJZOGS+/yWaB9Z 166jXPcO2DiOa3I+PYWQqzu3qGvP+NmTxFxTfPFUCoqNZFoSH64ErxdX8 mIRB69uTcQxF3pee+ZUPifXbxlka6pmKqLd+oRHqgXBFRRR8eXDPaG47Q g==; X-CSE-ConnectionGUID: v1QWsn8EReS3dhK4pOXOfg== X-CSE-MsgGUID: J6ozlDICQrWi75wYIpnTxw== X-IronPort-AV: E=McAfee;i="6700,10204,11185"; a="35357207" X-IronPort-AV: E=Sophos;i="6.10,203,1719903600"; d="scan'208";a="35357207" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2024 20:03:50 -0700 X-CSE-ConnectionGUID: Z8iGrkMfSI2AHVkBUG0Zeg== X-CSE-MsgGUID: ucmmtiruRcCC+/WXqLY2Sw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,203,1719903600"; d="scan'208";a="65516118" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2024 20:03:47 -0700 From: "Huang, Ying" To: Andy Shevchenko Cc: Andrew Morton , , , , Dan Williams , David Hildenbrand , "Davidlohr Bueso" , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , "Ira Weiny" , Alistair Popple , "Bjorn Helgaas" , Baoquan He Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory In-Reply-To: (Andy Shevchenko's message of "Wed, 4 Sep 2024 15:43:54 +0300") References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Thu, 05 Sep 2024 11:00:14 +0800 Message-ID: <87tteu6c01.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Stat-Signature: 8b8d9rneuxsmfxqzy73xcs6ptdsensoc X-Rspamd-Queue-Id: 6FD79140004 X-Rspamd-Server: rspam11 X-HE-Tag: 1725505459-309119 X-HE-Meta: U2FsdGVkX1/MGUGqMB6HtWueqkbBxKWRHOY/ky2NYQdwfkG6l4b+IvSEX8CkoIKxeoX9H/xuIC2AlS3HObQ+etHx+d4aOpMFBsKrGio6xqLC/fMCv8v5HyAm0raWBZxyb8R9C/EeOjhhiPf/CoGsyO1wkfvTo6B876MXCbKC7OZjdvZ3Tuo1p3RISb015xwI7Yvkdi2mAjeLj8iuKV1aAnq0O7MmMPytsU8Z9vqsILyvRWpeY+uYnhsDV4ci/dRn4lKvFTcNdriOIerzp9FqZDoFzqzcqyqcPC8QZkk2rs5i1YMyzwpZK8lSRxRgntgsy4YOmrm45KL3X8p0Q13Pz9e+1pya3ukMd6rfiDycl64RgrSt4dS8FcQ8b90EGQSugbgUWi2mIlwDiIqSqrDdxcxVIR1dmmZyXQ0nsxthl8UUMOyxNUdGeWoDTXLWuxSejaYyR+z+Gf1Amp749LX/LFG2OYrCWWCAFx6Ce+LvH10PVrclQ1GwAx8atTzw8W35/lVJHEtuDlXTR/P4YJ+XEHLq8QkZasa6aLQPBEDUZbsmk8P0pgFYUIbeIWaaURn7FvUMmQvdHSehzi30qOPK97rlcsClYm9NKZyZTEkao8jAg8Lzg0CxhiZT6m+LxhhbwK/9+RDu1ggewD1IjLr2P/PJurTtY0ei8zr96htkNbOP+fgjzrkZTrgla6anp39yOfyldAzfV6w5zpYvbOAuvN0ga4KYIKLMKkTyyWOH+ME8iLDjWYU3gEh6SFHKZDE/uvslrAUQ5Pxu94hKr3IBvOb6lTv43OtaRQwAuFlRrlXNhCI6EjBlWmJ6WBjgGeFxfOR+EwsNhcVWKxUzfECGshrx6/uxmdZUiIrzZJSOq3JrJGZi7Ci2OE2+KY/5+raIDGEyqOXoppjxiNicQCh3MEVAdqmFtuuFcAy7sru14ih452YZzd5eBZi3JqOunOrnc8dKzILeOYUbCUw2Y5c T8TMfau+ 7KlQ8ubwZOl2xBzHnRiRteZb3TMR8wiek8rL1wr1HKSXLzPyACLGKnQTnMc8+eK5ZRNCT5VzeKmMlRZ+2tQHX1LykEATenH00cFxeDhamBqnK4WTz+BV/vOcWsYcaBM/MfbesEeDSN9+U/8kEI7EPNbUSmm6k84i8LSOoeG2iVTU9lWdYRcy4EyMrwZI+3tAlrRSreDDEk+ZoYVr+dvI/MMdO+bSlzVj4aksGygF/GwOHR5mtGZ1COja4EFgJOH+VX/xSzFRNeMKeeAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andy Shevchenko writes: > On Wed, Sep 04, 2024 at 03:48:44PM +0800, Huang, Ying wrote: >> Andy Shevchenko writes: >> > On Mon, Aug 19, 2024 at 10:34:13AM +0800, Huang Ying wrote: > [snip] > >> >> + ostart = max(res.start, p->start); >> >> + oend = min(res.end, p->end); >> > >> > Isn't a reinvention of resource_intersection()? With that in place you may also >> > drop the above resource_overlaps(). >> >> sizeof(struct resource) == 8 * sizeof(unsigned long) >> >> Just want to avoid to define another struct resource on stack. > > Is it a problem? Not a serious problem. Just prefer to avoid too much stack usage. IMHO, the benefit isn't large too. -- Best Regards, Huang, Ying