From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F94CEE01FB for ; Wed, 11 Sep 2024 01:10:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DEBB900002; Tue, 10 Sep 2024 21:10:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7906B8D00E2; Tue, 10 Sep 2024 21:10:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62EA7900002; Tue, 10 Sep 2024 21:10:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 44BF58D00E2 for ; Tue, 10 Sep 2024 21:10:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 60FE6160F4E for ; Wed, 11 Sep 2024 01:10:33 +0000 (UTC) X-FDA: 82550677146.19.B20CE05 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf12.hostedemail.com (Postfix) with ESMTP id F05884000A for ; Wed, 11 Sep 2024 01:10:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KcdavCn5; spf=pass (imf12.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726016928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e7x9yG3MjxTUTUwuU+WLOJLFMEoaeBzsR5eSzlqSutM=; b=FbLMQIfJxDcPq9lZzaiAMuuqDhUDhs+4upO1hpEzmfdst0R/HP1jG+dvEi3KtsuAqCZNAY bsCyTD4tWlUZNM7azMSU9vNdgkqBZ03G224hg/HFKEyE8JM/AVkszERMyAznmvX8Z2yIfK 96kw+VxJiTOkrwPCopl/tdJzllFu9IQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726016928; a=rsa-sha256; cv=none; b=xLklf1Sm0paI3HgkbTPEtjcsSLOMVon9KhLzzhu43Ui1I0qc0S4C4IyvY5cSn9gg4L5uze faHaToCkwPAc4Kw74d2A8P2aGGW/C9gXF1CKwvf34WmxCued0tO+fAwxLjfy2zkhLbF3jo lDbosZNGGuPT1Wa0wtncnwnG8KzF5zA= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KcdavCn5; spf=pass (imf12.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726017030; x=1757553030; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=riNq3pM/DId4C30DQEIiavYhDshRICeniueLV2tGyug=; b=KcdavCn5ufJ9xxB+YV/l/6wBaojq9cFDNeMjhbHZ3tsive4EP+ShjeBq /0aoF8+TQIPfGVDbWV7tcKd4dKvuLFBvVAYOG18+7/ON6nQL67XRUMNYp 68b4ONZ9hz51oXH70Xsw2ajgM1efcRD6AxrT8DrKVTePvcGPVgei+MpUg j2EEqa6lsaQo1nOyE2OqkTRn3fdee6eikCiSudGjSUf4ACNTMHbMR+YS6 cM43szwWc0iUGczKhOWZBr9t1Yy3RTj129Z5nTaO9o2ylMtSItiYYGSMy Gubm5SJ1Lo27sXlNsHlk2oKc/J9zJR8bso4EkeytgaR2FsiNNEYRfV8bh Q==; X-CSE-ConnectionGUID: SiVlu9tGQruwVxBhwiaOTw== X-CSE-MsgGUID: KXtHy3NITn2Wz8PZY7k0Bg== X-IronPort-AV: E=McAfee;i="6700,10204,11191"; a="24662104" X-IronPort-AV: E=Sophos;i="6.10,218,1719903600"; d="scan'208";a="24662104" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2024 18:10:29 -0700 X-CSE-ConnectionGUID: dFNXcVp+QQ2VTJyJF8yO9A== X-CSE-MsgGUID: aG3CQ8UkRryMt0Evaq9njA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,218,1719903600"; d="scan'208";a="67218580" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2024 18:10:26 -0700 From: "Huang, Ying" To: Andrew Morton , Stephen Rothwell Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Thomas Gleixner Subject: Re: [linux-next:master 10352/10516] include/linux/mm.h:101:35: error: 'MAX_PHYSMEM_BITS' undeclared In-Reply-To: <20240910104056.343d7154134fb7fc6942075a@linux-foundation.org> (Andrew Morton's message of "Tue, 10 Sep 2024 10:40:56 -0700") References: <202409100913.RxkfrKU6-lkp@intel.com> <20240909204555.ab57c729531c83a0685cfa8e@linux-foundation.org> <87wmjkyshl.fsf@yhuang6-desk2.ccr.corp.intel.com> <20240910104056.343d7154134fb7fc6942075a@linux-foundation.org> Date: Wed, 11 Sep 2024 09:06:53 +0800 Message-ID: <87ttenvw0i.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: F05884000A X-Stat-Signature: ugby133spr3pmo47jw4jo3okbt4dpxmt X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1726017029-830769 X-HE-Meta: U2FsdGVkX1/b6y67VbiKIBbLdSjgoA8v/boGQgHponUUC1J5wij6X3ZmZcAY9jr+evnXneCPeXk1/ii11zG7ykCfH9bdjQH8Q0PNL5GMhpJg6+49MN1Os2B36hf4TIOkxnjDVfBUlUfEuBZc7Q+eRhervAD9o5MEO3o/TRbfn9UUs4yxn9RCn3Q7GL4GWHXn5kdK9UMeqG0f0Z6hJL0LJNXQXcjeALM0U/JzQbonaz8xISDsUwQcbveicjW62t3LHyglNDYxZecOgZpJ4417pyGV2q+P77whNIaZp+JWB7+tY1zhDuKKEdt8rvOW/OdPXaEF8cY2SZOW86TLSvtk0Tl7eZ+00sAcPp/KrKJdDMcyiccekATz2+WjicTYPlXX0MWbCTNUT1zK06P4mEcGHY+xEs1oAyPX9daZiEy2kJOP6aMLIjWmAd338LUsg1xeQla7IihoT7Dh9gCL5Qc620/hMAnsySmzrBylzhoTsGruEH2OenbvfhIlyoGGDN9TkkzZvJoztx3imyoIl+6dt3gqby9dVZ3iP/gNxSeXq8RRhzHNmDBCWOAxDelt9ywz2q7TS8zyhXL84PjQnLd+CWzhi7iEMXcxhKqHtazjnBlU7KQlU007ZBrruBzyh61/s8XwpI/a8GtlOEW4vrkSjm4gCYcFWQ0ekI4rSPEJcfSamz2hmbuhaDYEzmf359S8v7Ur67HOHT7FyPV7BuCFaECLxMfeql+e6jA6Obv9oFqEr8rON9NJ3/0qkbgjpMw6l2ogx6rp2JMY6Cf9p94+uhpGK58qLuyPrk6iWsG63Jfj1YBLU2Z8sDWf6UENGXNYzSehYrkHe+eImwrDWIAyIeNBNp7kHHKLVr6/v/X71kcPkN9lKKoLKeOhk/mB78xNVyKbWKCbYr7bh2pTkIVmnmk/S18JIG0j+Sc0V+bYp7mmEXoG5dQ1yVAzaHhUh24BRa+9HGk6oir13cCGSin YIFMkixh ACR8EtbZlsEGuYKyfedcZpMz7nq5GJwmEdQnQj4T1qjK01begKzzgO3/bWdL2kp5Zch0HN/4rML88KyI1ebPc9PeM2bYzGKTflLee4fSgtFOLroiMOVSeI81qV+ykK2WC11/Xyu6VckDazPRwinbIgVqYvtd676Iercmw9UK99UcRBIeEnax7V7WX1aEF5EdYtkWvFHiuVZD2nG/evIe4cdQmOeMeTVCGdLVJ9Pi2eZzgOJIumYlVcMzMcKMfzjkjSUsjwh5jA8YLXPpur0zoVf5veUXpshMQ9YCWrPCItubvloR1FXxZThiRj02UAgyFNhTyiqwjojEoKwCDlaFarGBvh1eVIZYT5wUXOxtcfQSlF11RLbGiSZvuB/joi9z+sw5mK/VRJ+mB9TI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andrew Morton writes: > On Tue, 10 Sep 2024 13:42:30 +0800 "Huang, Ying" wrote: > >> >> 93 | ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) >> >> | ^ >> > >> > Thanks. "resource, kunit: add test case for region_intersects" is the culprit. >> >> Yes. Although the definition in include/linux/mm.h introduced in >> >> commit ea72ce5da228 ("x86/kaslr: Expose and use the end of the physical memory address space") >> >> doesn't compile on m68k. There are no users of PHYSMEM_END before patch >> "resource, kunit: add test case for region_intersects". This can be >> fixed via the following patch. >> >> ---------------------------------8<-------------------------------------- >> >From 00d176e0cd07e3df1ea37a5e56ca576c819b585a Mon Sep 17 00:00:00 2001 >> From: Huang Ying >> Date: Tue, 10 Sep 2024 13:20:40 +0800 >> Subject: [PATCH] mm: fix PHYSMEM_END build error on m68k >> >> 0Day build system reported build error on m68k architecture for missing >> the definition of MAX_PHYSMEM_BITS when defining PHYSMEM_END. Fixed it >> via making PHYSMEM_END definition depends on MAX_PHYSMEM_BITS definition >> conditionally. >> >> Signed-off-by: "Huang, Ying" >> Cc: Thomas Gleixner >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202409100913.RxkfrKU6-lkp@intel.com/ >> --- >> include/linux/mm.h | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 147073601716..62bb7e7e0a17 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -98,7 +98,11 @@ extern int mmap_rnd_compat_bits __read_mostly; >> #endif >> >> #ifndef PHYSMEM_END >> -# define PHYSMEM_END ((1ULL << MAX_PHYSMEM_BITS) - 1) >> +# ifdef MAX_PHYSMEM_BITS >> +# define PHYSMEM_END ((1ULL << MAX_PHYSMEM_BITS) - 1) >> +# else >> +# define PHYSMEM_END (-1ULL) >> +# endif >> #endif >> >> #include > > I'm not really understanding. This patch (which I assume is against > linux-next?) requires the presence of ea72ce5da228 ("x86/kaslr: Expose > and use the end of the physical memory address space"), which is not > present in mm.git. Yet mm.git exhibits the build failure. The original test report is against linux-next tree instead mm tree. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git The first bad commit (bisection result) is: 5f445800cbdfc4b4185d496a43dfd78df63d2265 [10352/10516] Merge branch 'mm-everything' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm That is, mm tree is merged in linux-next, and commit ea72ce5da228 ("x86/kaslr: Expose and use the end of the physical memory address space") is merged in linux-next too. In fact, there's a merge conflict for MAX_PHYSMEM_BITS related code. Maybe this can be part of merge conflict resolving patch? Hi, Stephen, Can you use the patch above as part of merged conflict resolving patch for patch e2941fe697c8 ("resource, kunit: add test case for region_intersects()") You have resolved it in https://lore.kernel.org/lkml/20240909100043.60668995@canb.auug.org.au/ -- Best Regards, Huang, Ying