From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF12BD3ABEA for ; Mon, 11 Nov 2024 18:37:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D0336B0099; Mon, 11 Nov 2024 13:37:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27E4C6B009A; Mon, 11 Nov 2024 13:37:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 145706B009B; Mon, 11 Nov 2024 13:37:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E61D26B0099 for ; Mon, 11 Nov 2024 13:37:51 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 519121A1A57 for ; Mon, 11 Nov 2024 18:37:51 +0000 (UTC) X-FDA: 82774671294.08.7B7D50E Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by imf09.hostedemail.com (Postfix) with ESMTP id EB20714000F for ; Mon, 11 Nov 2024 18:37:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=krisman.be header.s=gm1 header.b="P/3XnOpF"; spf=pass (imf09.hostedemail.com: domain of gabriel@krisman.be designates 217.70.183.193 as permitted sender) smtp.mailfrom=gabriel@krisman.be; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731350078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UMZLU0glgskDaX19CHJonE0wxrjAf1oMMWUu0fOjAj4=; b=y3RCvJBrqtdEQgPcDm8o/y2ao+Kqiw5euzeZ3vLF2jfJuyH4is6dfpDyYdEZHcDbxPMCv/ DBlGaUbMKfMIX3SQbB9JOpl0fSJtXw+gyPbTR+Fq/XIumjblgBYV/fiKwdLmruE55HhPSn iJIMmzS4lEdc4va4bXWJ0LzT29UUlLU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=krisman.be header.s=gm1 header.b="P/3XnOpF"; spf=pass (imf09.hostedemail.com: domain of gabriel@krisman.be designates 217.70.183.193 as permitted sender) smtp.mailfrom=gabriel@krisman.be; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731350078; a=rsa-sha256; cv=none; b=rkc8DMPa07wnB3F8Y2GPY39zznOETG8n8W3uMKupx32rq8qWVKQy+asjC0hUby3CczE2dA 0MlSsgdItcS6cVPoE9lUL7TEmdqhY4Cj/OmNLQo/qnZ7slfuyWGEI1s9QY1knLqmx/lXzf R+oKT6RIFCcTPrj6quN3sUIdLgHUuIo= Received: by mail.gandi.net (Postfix) with ESMTPSA id BA4CB240003; Mon, 11 Nov 2024 18:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=krisman.be; s=gm1; t=1731350267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UMZLU0glgskDaX19CHJonE0wxrjAf1oMMWUu0fOjAj4=; b=P/3XnOpFuElSQsOmH0WVv9SF7oRRXP3TQaf+2ijN+ky2s5E8lE+x/FnUV4FHi7+BPIBAUC bk2piY45QOhtou8vBBb7najMkIDiDZlMgaoZf4M86e1b4JogGDvm1+qctJup0RSPsD/jIP R72p95NJ7rINvKBa7Mi9nAEAb0FA++oWiYiqaRqhRnsF51nrIapn/m+2k9Y84pKwzTXfmp BG7IhabwpSqhpShDQgD4+LV20NBTr8yIYhBicZDaiy8RzHFzAFF/aHD1KpDImbFNbs6tLS RRVepzLQjY0WCIWYdYObQNbp2Rx3fKHV4927tgnkQRelVrIP3PFkiPBS5euhEA== From: Gabriel Krisman Bertazi To: Karan Sanghavi Cc: Hugh Dickins , Andrew Morton , =?utf-8?Q?Andr=C3=A9?= Almeida , Christian Brauner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] mm: shmem: Fix variable type to int to evaluate negative conditions In-Reply-To: <20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com> (Karan Sanghavi's message of "Mon, 11 Nov 2024 17:10:14 +0000") References: <20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com> Date: Mon, 11 Nov 2024 13:37:43 -0500 Message-ID: <87ttcdwr9k.fsf@mailhost.krisman.be> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: gabriel@krisman.be X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EB20714000F X-Stat-Signature: xrkrcifspzs9tk354cenobqgtd86s967 X-Rspam-User: X-HE-Tag: 1731350240-906173 X-HE-Meta: U2FsdGVkX18KCl945QeZvL/R8B/aWnKL6IKMuVsgfhNmChj1m96LStByU7qu074iadC3vVX9g4cHpGd4fZ8OFH10HV/NPON0EXN7R9Rt101MwIvDQubIqcd+ItoriWZz96YE6ei+Bl4sr7F/P2/ZP3wuKwsYl4iOJ55qkmK2c0evRMm7Ux/D/WBKj0m0ubQx5bpjm4tW0aSDJIGSdN8J2tLmV8y0w5kD12aezqP8IpIjSp2ANJrUWpWErIU5A40e4MPoAYnUoRhMR5OpRmbLIPaMdNdR+dyNl109tH9EOJaY1WpmkuPUievhv6cM/dA8X8yDC2Zlb76H56Ky90TaBvC35HGJ8zw52qRngED2554JGeJI1LQDRnMA9CZ8JmQnDU0PevMVee/Oq7B0VZzDc4Zr1cxVyBwbZv/BIkPvMcKrEu4EO5y7b2TKeb1Fop5WWyAhy6abmKciOPExbChWLSjnrsmPml+hfSIsEopa4VegmFlIaz8o0Ljsn9O9k+vUIXnBb+6/1GerWPpkEDCNg9qtszwK8ehSRA+hov1xlzWFesSmWkkeUNnfnvxq9FSiFo2bfPaFTodCPMv1T9JNpGdNhGCmV5zGE807fQj0ZJTCU0SE9F8JLG82zMXxlLvNoJnnGUJu4uYKedhoLXV3e5mX4tNeAXgh3wi0QRNQYezFqIqGrCI32G2D+i0gwi92UV4sPRy6+vtG3Yvrwujf787rn7mLoSBZRKDITSBTO1OYorVw0fZFsI3DXiCtFVTMNeE2a6G1ZPSmFjZWBMtZ55Vjw4RWdbIwzec9dFrMvWxd1nm6dsisoi0YfCEXuId4U61zdIBF+NQkNfeYEbvSfKZ5roAp7CXQzel/rPhqfLle823xmoQzDO1Y3MKa6DB4AoW7jpsaOqxW2RLEAScgloyCYbivbIbmd6jy9WvRHU9h/LKAajCwPgDLHXAbqNLJzviT14hLuF66WaEom2Q C1wir5LB iX6hokiLHli/3msL84byxxAmC7C0h5WTrmaRLVSLMPNy+BxhtytQiWQdg1F3pmvSng84hJJmX/zvixH0/Ei2Xz+O93RRAbJ+NPVCP2aXXu0GUJ76wUY1SzSqpEV1xITRgaKsy0qhDz0WyR2KOD2YINj0Q2BDGxWiBfOqgCHlJaI4ZjjnzEhK6qBJJpa9m9nhySTJGKNACkq+i9VYztIVuSC3WDVnfWRN+5+X9M4oSF0NJG3YAYz0prR5QHM8tfRxR5clsxROzE4qHK+I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Karan Sanghavi writes: > version variable captures return value from utf8_parse_version > function which can be negative, but unsigned won't > let it capture, thus missing the further checks on negative values. > > Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support") > Signed-off-by: Karan Sanghavi > --- > Coverity Message: > CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT) > unsigned_compare: This less-than-zero comparison of an unsigned > value is never true. version < 0U Reviewed-by: Gabriel Krisman Bertazi > > Coverity Link: > https://scan7.scan.coverity.com/#/project-view/10043/11354?selectedIssue=1601569 > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 7987deb2be9b..17a1d4fa8870 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4367,7 +4367,7 @@ static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter * > bool latest_version) > { > struct shmem_options *ctx = fc->fs_private; > - unsigned int version = UTF8_LATEST; > + int version = UTF8_LATEST; > struct unicode_map *encoding; > char *version_str = param->string + 5; > > > --- > base-commit: 6d59cab07b8d74d0f0422b750038123334f6ecc2 > change-id: 20241111-unsignedcompare1601569-05b5932145ef > > Best regards, -- Gabriel Krisman Bertazi